#!/usr/bin/perl # Read two files produced by the stackusage script, and show the # delta between them. # # Currently, only shows changes for functions listed in both files. We # could add an option to show also functions which have vanished or # appeared (which would often be due to gcc making other inlining # decisions). # # Another possible option would be a minimum absolute value for the # delta. # # A third possibility is for sorting by delta, but that can be # achieved by piping to sort -k5,5g. sub read_stack_usage_file { my %su; my $f = shift; open(my $fh, '<', $f) or die "cannot open $f: $!"; while (<$fh>) { chomp; my ($file, $func, $size, $type) = split; # Old versions of gcc (at least 4.7) have an annoying quirk in # that a (static) function whose name has been changed into # for example ext4_find_unwritten_pgoff.isra.11 will show up # in the .su file with a name of just "11". Since such a # numeric suffix is likely to change across different # commits/compilers/.configs or whatever else we're trying to # tweak, we can't really track those functions, so we just # silently skip them. # # Newer gcc (at least 5.0) report the full name, so again, # since the suffix is likely to change, we strip it. next if $func =~ m/^[0-9]+$/; $func =~ s/\..*$//; # Line numbers are likely to change; strip those. $file =~ s/:[0-9]+$//; $su{"${file}\t${func}"} = {size => $size, type => $type}; } close($fh); return \%su; } @ARGV == 2 or die "usage: $0 "; my $old = read_stack_usage_file($ARGV[0]); my $new = read_stack_usage_file($ARGV[1]); my @common = sort grep {exists $new->{$_}} keys %$old; for (@common) { my $x = $old->{$_}{size}; my $y = $new->{$_}{size}; my $delta = $y - $x; if ($delta) { printf "%s\t%d\t%d\t%+d\n", $_, $x, $y, $delta; } } commitdiff
tion>
AgeCommit message (Expand)AuthorFilesLines
space:
mode:
authorBjorn Helgaas <bhelgaas@google.com>2017-01-27 15:00:45 -0600
committerBjorn Helgaas <bhelgaas@google.com>2017-01-27 15:00:45 -0600
commit030305d69fc6963c16003f50d7e8d74b02d0a143 (patch)
tree363a4e34d199178769b7e7eeb26ea2620a55847b /include/drm/drm_vma_manager.h
parent4d191b1b63c209e37bf27938ef365244d3c41084 (diff)
PCI/ASPM: Handle PCI-to-PCIe bridges as roots of PCIe hierarchies
In a struct pcie_link_state, link->root points to the pcie_link_state of the root of the PCIe hierarchy. For the topmost link, this points to itself (link->root = link). For others, we copy the pointer from the parent (link->root = link->parent->root). Previously we recognized that Root Ports originated PCIe hierarchies, but we treated PCI/PCI-X to PCIe Bridges as being in the middle of the hierarchy, and when we tried to copy the pointer from link->parent->root, there was no parent, and we dereferenced a NULL pointer: BUG: unable to handle kernel NULL pointer dereference at 0000000000000090 IP: [<ffffffff9e424350>] pcie_aspm_init_link_state+0x170/0x820 Recognize that PCI/PCI-X to PCIe Bridges originate PCIe hierarchies just like Root Ports do, so link->root for these devices should also point to itself. Fixes: 51ebfc92b72b ("PCI: Enumerate switches below PCI-to-PCIe bridges") Link: https://bugzilla.kernel.org/show_bug.cgi?id=193411 Link: https://bugzilla.opensuse.org/show_bug.cgi?id=1022181 Tested-by: lists@ssl-mail.com Tested-by: Jayachandran C. <jnair@caviumnetworks.com> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> CC: stable@vger.kernel.org # v4.2+
Diffstat (limited to 'include/drm/drm_vma_manager.h')