/* * Apple Onboard Audio Alsa helpers * * Copyright 2006 Johannes Berg * * GPL v2, can be found in COPYING. */ #include #include "alsa.h" static int index = -1; module_param(index, int, 0444); MODULE_PARM_DESC(index, "index for AOA sound card."); static struct aoa_card *aoa_card; int aoa_alsa_init(char *name, struct module *mod, struct device *dev) { struct snd_card *alsa_card; int err; if (aoa_card) /* cannot be EEXIST due to usage in aoa_fabric_register */ return -EBUSY; err = snd_card_new(dev, index, name, mod, sizeof(struct aoa_card), &alsa_card); if (err < 0) return err; aoa_card = alsa_card->private_data; aoa_card->alsa_card = alsa_card; strlcpy(alsa_card->driver, "AppleOnbdAudio", sizeof(alsa_card->driver)); strlcpy(alsa_card->shortname, name, sizeof(alsa_card->shortname)); strlcpy(alsa_card->longname, name, sizeof(alsa_card->longname)); strlcpy(alsa_card->mixername, name, sizeof(alsa_card->mixername)); err = snd_card_register(aoa_card->alsa_card); if (err < 0) { printk(KERN_ERR "snd-aoa: couldn't register alsa card\n"); snd_card_free(aoa_card->alsa_card); aoa_card = NULL; return err; } return 0; } struct snd_card *aoa_get_card(void) { if (aoa_card) return aoa_card->alsa_card; return NULL; } EXPORT_SYMBOL_GPL(aoa_get_card); void aoa_alsa_cleanup(void) { if (aoa_card) { snd_card_free(aoa_card->alsa_card); aoa_card = NULL; } } int aoa_snd_device_new(enum snd_device_type type, void * device_data, struct snd_device_ops * ops) { struct snd_card *card = aoa_get_card(); int err; if (!card) return -ENOMEM; err = snd_device_new(card, type, device_data, ops); if (err) { printk(KERN_ERR "snd-aoa: failed to create snd device (%d)\n", err); return err; } err = snd_device_register(card, device_data); if (err) { printk(KERN_ERR "snd-aoa: failed to register " "snd device (%d)\n", err); printk(KERN_ERR "snd-aoa: have you forgotten the " "dev_register callback?\n"); snd_device_free(card, device_data); } return err; } EXPORT_SYMBOL_GPL(aoa_snd_device_new); int aoa_snd_ctl_add(struct snd_kcontrol* control) { int err; if (!aoa_card) return -ENODEV; err = snd_ctl_add(aoa_card->alsa_card, control); if (err) printk(KERN_ERR "snd-aoa: failed to add alsa control (%d)\n", err); return err; } EXPORT_SYMBOL_GPL(aoa_snd_ctl_add); er'>committer
diff options
context:
space:
mode:
authorVincent <vincent.stehle@laposte.net>2017-01-30 15:06:43 +0100
committerDavid S. Miller <davem@davemloft.net>2017-01-31 13:07:40 -0500
commitc73e44269369e936165f0f9b61f1f09a11dae01c (patch)
treee2188e900ba06302f8ed2746cb07edd3efbc5c35 /net/ipv4/fou.c
parent040587af31228d82c52267f717c9fcdb65f36335 (diff)
net: thunderx: avoid dereferencing xcv when NULL
This fixes the following smatch and coccinelle warnings: drivers/net/ethernet/cavium/thunder/thunder_xcv.c:119 xcv_setup_link() error: we previously assumed 'xcv' could be null (see line 118) [smatch] drivers/net/ethernet/cavium/thunder/thunder_xcv.c:119:16-20: ERROR: xcv is NULL but dereferenced. [coccinelle] Fixes: 6465859aba1e66a5 ("net: thunderx: Add RGMII interface type support") Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net> Cc: Sunil Goutham <sgoutham@cavium.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/fou.c')