/* * digi00x-transaction.c - a part of driver for Digidesign Digi 002/003 family * * Copyright (c) 2014-2015 Takashi Sakamoto * * Licensed under the terms of the GNU General Public License, version 2. */ #include #include "digi00x.h" static int fill_midi_message(struct snd_rawmidi_substream *substream, u8 *buf) { int bytes; buf[0] = 0x80; bytes = snd_rawmidi_transmit_peek(substream, buf + 1, 2); if (bytes >= 0) buf[3] = 0xc0 | bytes; return bytes; } static void handle_midi_control(struct snd_dg00x *dg00x, __be32 *buf, unsigned int length) { struct snd_rawmidi_substream *substream; unsigned int i; unsigned int len; u8 *b; substream = ACCESS_ONCE(dg00x->in_control); if (substream == NULL) return; length /= 4; for (i = 0; i < length; i++) { b = (u8 *)&buf[i]; len = b[3] & 0xf; if (len > 0) snd_rawmidi_receive(dg00x->in_control, b + 1, len); } } static void handle_unknown_message(struct snd_dg00x *dg00x, unsigned long long offset, __be32 *buf) { unsigned long flags; spin_lock_irqsave(&dg00x->lock, flags); dg00x->msg = be32_to_cpu(*buf); spin_unlock_irqrestore(&dg00x->lock, flags); wake_up(&dg00x->hwdep_wait); } static void handle_message(struct fw_card *card, struct fw_request *request, int tcode, int destination, int source, int generation, unsigned long long offset, void *data, size_t length, void *callback_data) { struct snd_dg00x *dg00x = callback_data; __be32 *buf = (__be32 *)data; if (offset == dg00x->async_handler.offset) handle_unknown_message(dg00x, offset, buf); else if (offset == dg00x->async_handler.offset + 4) handle_midi_control(dg00x, buf, length); fw_send_response(card, request, RCODE_COMPLETE); } int snd_dg00x_transaction_reregister(struct snd_dg00x *dg00x) { struct fw_device *device = fw_parent_device(dg00x->unit); __be32 data[2]; int err; /* Unknown. 4bytes. */ data[0] = cpu_to_be32((device->card->node_id << 16) | (dg00x->async_handler.offset >> 32)); data[1] = cpu_to_be32(dg00x->async_handler.offset); err = snd_fw_transaction(dg00x->unit, TCODE_WRITE_BLOCK_REQUEST, DG00X_ADDR_BASE + DG00X_OFFSET_MESSAGE_ADDR, &data, sizeof(data), 0); if (err < 0) return err; /* Asynchronous transactions for MIDI control message. */ data[0] = cpu_to_be32((device->card->node_id << 16) | (dg00x->async_handler.offset >> 32)); data[1] = cpu_to_be32(dg00x->async_handler.offset + 4); return snd_fw_transaction(dg00x->unit, TCODE_WRITE_BLOCK_REQUEST, DG00X_ADDR_BASE + DG00X_OFFSET_MIDI_CTL_ADDR, &data, sizeof(data), 0); } int snd_dg00x_transaction_register(struct snd_dg00x *dg00x) { static const struct fw_address_region resp_register_region = { .start = 0xffffe0000000ull, .end = 0xffffe000ffffull, }; int err; dg00x->async_handler.length = 12; dg00x->async_handler.address_callback = handle_message; dg00x->async_handler.callback_data = dg00x; err = fw_core_add_address_handler(&dg00x->async_handler, &resp_register_region); if (err < 0) return err; err = snd_dg00x_transaction_reregister(dg00x); if (err < 0) goto error; err = snd_fw_async_midi_port_init(&dg00x->out_control, dg00x->unit, DG00X_ADDR_BASE + DG00X_OFFSET_MMC, 4, fill_midi_message); if (err < 0) goto error; return err; error: fw_core_remove_address_handler(&dg00x->async_handler); dg00x->async_handler.callback_data = NULL; return err; } void snd_dg00x_transaction_unregister(struct snd_dg00x *dg00x) { if (dg00x->async_handler.callback_data == NULL) return; snd_fw_async_midi_port_destroy(&dg00x->out_control); fw_core_remove_address_handler(&dg00x->async_handler); dg00x->async_handler.callback_data = NULL; } on>space:mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
commit39cb2c9a316e77f6dfba96c543e55b6672d5a37e (patch)
tree98fe974ee4e20121253de7f61fc8d01bdb3821c1 /sound/soc/codecs/cs42xx8.h
parent2c5d9555d6d937966d79d4c6529a5f7b9206e405 (diff)
drm/i915: Check for NULL i915_vma in intel_unpin_fb_obj()
I've seen this trigger twice now, where the i915_gem_object_to_ggtt() call in intel_unpin_fb_obj() returns NULL, resulting in an oops immediately afterwards as the (inlined) call to i915_vma_unpin_fence() tries to dereference it. It seems to be some race condition where the object is going away at shutdown time, since both times happened when shutting down the X server. The call chains were different: - VT ioctl(KDSETMODE, KD_TEXT): intel_cleanup_plane_fb+0x5b/0xa0 [i915] drm_atomic_helper_cleanup_planes+0x6f/0x90 [drm_kms_helper] intel_atomic_commit_tail+0x749/0xfe0 [i915] intel_atomic_commit+0x3cb/0x4f0 [i915] drm_atomic_commit+0x4b/0x50 [drm] restore_fbdev_mode+0x14c/0x2a0 [drm_kms_helper] drm_fb_helper_restore_fbdev_mode_unlocked+0x34/0x80 [drm_kms_helper] drm_fb_helper_set_par+0x2d/0x60 [drm_kms_helper] intel_fbdev_set_par+0x18/0x70 [i915] fb_set_var+0x236/0x460 fbcon_blank+0x30f/0x350 do_unblank_screen+0xd2/0x1a0 vt_ioctl+0x507/0x12a0 tty_ioctl+0x355/0xc30 do_vfs_ioctl+0xa3/0x5e0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x13/0x94 - i915 unpin_work workqueue: intel_unpin_work_fn+0x58/0x140 [i915] process_one_work+0x1f1/0x480 worker_thread+0x48/0x4d0 kthread+0x101/0x140 and this patch purely papers over the issue by adding a NULL pointer check and a WARN_ON_ONCE() to avoid the oops that would then generally make the machine unresponsive. Other callers of i915_gem_object_to_ggtt() seem to also check for the returned pointer being NULL and warn about it, so this clearly has happened before in other places. [ Reported it originally to the i915 developers on Jan 8, applying the ugly workaround on my own now after triggering the problem for the second time with no feedback. This is likely to be the same bug reported as https://bugs.freedesktop.org/show_bug.cgi?id=98829 https://bugs.freedesktop.org/show_bug.cgi?id=99134 which has a patch for the underlying problem, but it hasn't gotten to me, so I'm applying the workaround. ] Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'sound/soc/codecs/cs42xx8.h')