/* * digi00x.h - a part of driver for Digidesign Digi 002/003 family * * Copyright (c) 2014-2015 Takashi Sakamoto * * Licensed under the terms of the GNU General Public License, version 2. */ #ifndef SOUND_DIGI00X_H_INCLUDED #define SOUND_DIGI00X_H_INCLUDED #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include "../lib.h" #include "../iso-resources.h" #include "../amdtp-stream.h" struct snd_dg00x { struct snd_card *card; struct fw_unit *unit; struct mutex mutex; spinlock_t lock; bool registered; struct delayed_work dwork; struct amdtp_stream tx_stream; struct fw_iso_resources tx_resources; struct amdtp_stream rx_stream; struct fw_iso_resources rx_resources; unsigned int substreams_counter; /* for uapi */ int dev_lock_count; bool dev_lock_changed; wait_queue_head_t hwdep_wait; /* For asynchronous messages. */ struct fw_address_handler async_handler; u32 msg; /* For asynchronous MIDI controls. */ struct snd_rawmidi_substream *in_control; struct snd_fw_async_midi_port out_control; }; #define DG00X_ADDR_BASE 0xffffe0000000ull #define DG00X_OFFSET_STREAMING_STATE 0x0000 #define DG00X_OFFSET_STREAMING_SET 0x0004 #define DG00X_OFFSET_MIDI_CTL_ADDR 0x0008 /* For LSB of the address 0x000c */ /* unknown 0x0010 */ #define DG00X_OFFSET_MESSAGE_ADDR 0x0014 /* For LSB of the address 0x0018 */ /* unknown 0x001c */ /* unknown 0x0020 */ /* not used 0x0024--0x00ff */ #define DG00X_OFFSET_ISOC_CHANNELS 0x0100 /* unknown 0x0104 */ /* unknown 0x0108 */ /* unknown 0x010c */ #define DG00X_OFFSET_LOCAL_RATE 0x0110 #define DG00X_OFFSET_EXTERNAL_RATE 0x0114 #define DG00X_OFFSET_CLOCK_SOURCE 0x0118 #define DG00X_OFFSET_OPT_IFACE_MODE 0x011c /* unknown 0x0120 */ /* Mixer control on/off 0x0124 */ /* unknown 0x0128 */ #define DG00X_OFFSET_DETECT_EXTERNAL 0x012c /* unknown 0x0138 */ #define DG00X_OFFSET_MMC 0x0400 enum snd_dg00x_rate { SND_DG00X_RATE_44100 = 0, SND_DG00X_RATE_48000, SND_DG00X_RATE_88200, SND_DG00X_RATE_96000, SND_DG00X_RATE_COUNT, }; enum snd_dg00x_clock { SND_DG00X_CLOCK_INTERNAL = 0, SND_DG00X_CLOCK_SPDIF, SND_DG00X_CLOCK_ADAT, SND_DG00X_CLOCK_WORD, SND_DG00X_CLOCK_COUNT, }; enum snd_dg00x_optical_mode { SND_DG00X_OPT_IFACE_MODE_ADAT = 0, SND_DG00X_OPT_IFACE_MODE_SPDIF, SND_DG00X_OPT_IFACE_MODE_COUNT, }; #define DOT_MIDI_IN_PORTS 1 #define DOT_MIDI_OUT_PORTS 2 int amdtp_dot_init(struct amdtp_stream *s, struct fw_unit *unit, enum amdtp_stream_direction dir); int amdtp_dot_set_parameters(struct amdtp_stream *s, unsigned int rate, unsigned int pcm_channels); void amdtp_dot_reset(struct amdtp_stream *s); int amdtp_dot_add_pcm_hw_constraints(struct amdtp_stream *s, struct snd_pcm_runtime *runtime); void amdtp_dot_set_pcm_format(struct amdtp_stream *s, snd_pcm_format_t format); void amdtp_dot_midi_trigger(struct amdtp_stream *s, unsigned int port, struct snd_rawmidi_substream *midi); int snd_dg00x_transaction_register(struct snd_dg00x *dg00x); int snd_dg00x_transaction_reregister(struct snd_dg00x *dg00x); void snd_dg00x_transaction_unregister(struct snd_dg00x *dg00x); extern const unsigned int snd_dg00x_stream_rates[SND_DG00X_RATE_COUNT]; extern const unsigned int snd_dg00x_stream_pcm_channels[SND_DG00X_RATE_COUNT]; int snd_dg00x_stream_get_external_rate(struct snd_dg00x *dg00x, unsigned int *rate); int snd_dg00x_stream_get_local_rate(struct snd_dg00x *dg00x, unsigned int *rate); int snd_dg00x_stream_set_local_rate(struct snd_dg00x *dg00x, unsigned int rate); int snd_dg00x_stream_get_clock(struct snd_dg00x *dg00x, enum snd_dg00x_clock *clock); int snd_dg00x_stream_check_external_clock(struct snd_dg00x *dg00x, bool *detect); int snd_dg00x_stream_init_duplex(struct snd_dg00x *dg00x); int snd_dg00x_stream_start_duplex(struct snd_dg00x *dg00x, unsigned int rate); void snd_dg00x_stream_stop_duplex(struct snd_dg00x *dg00x); void snd_dg00x_stream_update_duplex(struct snd_dg00x *dg00x); void snd_dg00x_stream_destroy_duplex(struct snd_dg00x *dg00x); void snd_dg00x_stream_lock_changed(struct snd_dg00x *dg00x); int snd_dg00x_stream_lock_try(struct snd_dg00x *dg00x); void snd_dg00x_stream_lock_release(struct snd_dg00x *dg00x); void snd_dg00x_proc_init(struct snd_dg00x *dg00x); int snd_dg00x_create_pcm_devices(struct snd_dg00x *dg00x); int snd_dg00x_create_midi_devices(struct snd_dg00x *dg00x); int snd_dg00x_create_hwdep_device(struct snd_dg00x *dg00x); #endif 9cb2c9a316e77f6dfba96c543e55b6672d5a37e'>patch) tree98fe974ee4e20121253de7f61fc8d01bdb3821c1 /net/smc parent2c5d9555d6d937966d79d4c6529a5f7b9206e405 (diff)
drm/i915: Check for NULL i915_vma in intel_unpin_fb_obj()
I've seen this trigger twice now, where the i915_gem_object_to_ggtt() call in intel_unpin_fb_obj() returns NULL, resulting in an oops immediately afterwards as the (inlined) call to i915_vma_unpin_fence() tries to dereference it. It seems to be some race condition where the object is going away at shutdown time, since both times happened when shutting down the X server. The call chains were different: - VT ioctl(KDSETMODE, KD_TEXT): intel_cleanup_plane_fb+0x5b/0xa0 [i915] drm_atomic_helper_cleanup_planes+0x6f/0x90 [drm_kms_helper] intel_atomic_commit_tail+0x749/0xfe0 [i915] intel_atomic_commit+0x3cb/0x4f0 [i915] drm_atomic_commit+0x4b/0x50 [drm] restore_fbdev_mode+0x14c/0x2a0 [drm_kms_helper] drm_fb_helper_restore_fbdev_mode_unlocked+0x34/0x80 [drm_kms_helper] drm_fb_helper_set_par+0x2d/0x60 [drm_kms_helper] intel_fbdev_set_par+0x18/0x70 [i915] fb_set_var+0x236/0x460 fbcon_blank+0x30f/0x350 do_unblank_screen+0xd2/0x1a0 vt_ioctl+0x507/0x12a0 tty_ioctl+0x355/0xc30 do_vfs_ioctl+0xa3/0x5e0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x13/0x94 - i915 unpin_work workqueue: intel_unpin_work_fn+0x58/0x140 [i915] process_one_work+0x1f1/0x480 worker_thread+0x48/0x4d0 kthread+0x101/0x140 and this patch purely papers over the issue by adding a NULL pointer check and a WARN_ON_ONCE() to avoid the oops that would then generally make the machine unresponsive. Other callers of i915_gem_object_to_ggtt() seem to also check for the returned pointer being NULL and warn about it, so this clearly has happened before in other places. [ Reported it originally to the i915 developers on Jan 8, applying the ugly workaround on my own now after triggering the problem for the second time with no feedback. This is likely to be the same bug reported as https://bugs.freedesktop.org/show_bug.cgi?id=98829 https://bugs.freedesktop.org/show_bug.cgi?id=99134 which has a patch for the underlying problem, but it hasn't gotten to me, so I'm applying the workaround. ] Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'net/smc')