/* * oxfw.h - a part of driver for OXFW970/971 based devices * * Copyright (c) Clemens Ladisch * Licensed under the terms of the GNU General Public License, version 2. */ #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include "../lib.h" #include "../fcp.h" #include "../packets-buffer.h" #include "../iso-resources.h" #include "../amdtp-am824.h" #include "../cmp.h" /* This is an arbitrary number for convinience. */ #define SND_OXFW_STREAM_FORMAT_ENTRIES 10 struct snd_oxfw { struct snd_card *card; struct fw_unit *unit; struct mutex mutex; spinlock_t lock; bool registered; struct delayed_work dwork; bool wrong_dbs; bool has_output; u8 *tx_stream_formats[SND_OXFW_STREAM_FORMAT_ENTRIES]; u8 *rx_stream_formats[SND_OXFW_STREAM_FORMAT_ENTRIES]; bool assumed; struct cmp_connection out_conn; struct cmp_connection in_conn; struct amdtp_stream tx_stream; struct amdtp_stream rx_stream; unsigned int capture_substreams; unsigned int playback_substreams; unsigned int midi_input_ports; unsigned int midi_output_ports; int dev_lock_count; bool dev_lock_changed; wait_queue_head_t hwdep_wait; const struct ieee1394_device_id *entry; void *spec; }; /* * AV/C Stream Format Information Specification 1.1 Working Draft * (Apr 2005, 1394TA) */ int avc_stream_set_format(struct fw_unit *unit, enum avc_general_plug_dir dir, unsigned int pid, u8 *format, unsigned int len); int avc_stream_get_format(struct fw_unit *unit, enum avc_general_plug_dir dir, unsigned int pid, u8 *buf, unsigned int *len, unsigned int eid); static inline int avc_stream_get_format_single(struct fw_unit *unit, enum avc_general_plug_dir dir, unsigned int pid, u8 *buf, unsigned int *len) { return avc_stream_get_format(unit, dir, pid, buf, len, 0xff); } static inline int avc_stream_get_format_list(struct fw_unit *unit, enum avc_general_plug_dir dir, unsigned int pid, u8 *buf, unsigned int *len, unsigned int eid) { return avc_stream_get_format(unit, dir, pid, buf, len, eid); } /* * AV/C Digital Interface Command Set General Specification 4.2 * (Sep 2004, 1394TA) */ int avc_general_inquiry_sig_fmt(struct fw_unit *unit, unsigned int rate, enum avc_general_plug_dir dir, unsigned short pid); int snd_oxfw_stream_init_simplex(struct snd_oxfw *oxfw, struct amdtp_stream *stream); int snd_oxfw_stream_start_simplex(struct snd_oxfw *oxfw, struct amdtp_stream *stream, unsigned int rate, unsigned int pcm_channels); void snd_oxfw_stream_stop_simplex(struct snd_oxfw *oxfw, struct amdtp_stream *stream); void snd_oxfw_stream_destroy_simplex(struct snd_oxfw *oxfw, struct amdtp_stream *stream); void snd_oxfw_stream_update_simplex(struct snd_oxfw *oxfw, struct amdtp_stream *stream); struct snd_oxfw_stream_formation { unsigned int rate; unsigned int pcm; unsigned int midi; }; int snd_oxfw_stream_parse_format(u8 *format, struct snd_oxfw_stream_formation *formation); int snd_oxfw_stream_get_current_formation(struct snd_oxfw *oxfw, enum avc_general_plug_dir dir, struct snd_oxfw_stream_formation *formation); int snd_oxfw_stream_discover(struct snd_oxfw *oxfw); void snd_oxfw_stream_lock_changed(struct snd_oxfw *oxfw); int snd_oxfw_stream_lock_try(struct snd_oxfw *oxfw); void snd_oxfw_stream_lock_release(struct snd_oxfw *oxfw); int snd_oxfw_create_pcm(struct snd_oxfw *oxfw); void snd_oxfw_proc_init(struct snd_oxfw *oxfw); int snd_oxfw_create_midi(struct snd_oxfw *oxfw); int snd_oxfw_create_hwdep(struct snd_oxfw *oxfw); int snd_oxfw_add_spkr(struct snd_oxfw *oxfw, bool is_lacie); int snd_oxfw_scs1x_add(struct snd_oxfw *oxfw); void snd_oxfw_scs1x_update(struct snd_oxfw *oxfw); '>2016-12-14 12:45:25 -0800 commitd05c5f7ba164aed3db02fb188c26d0dd94f5455b (patch) tree1f31fa0312d525122ac601a321236d9d1cb695d2 parent7ae123edd37a47e178eb9a6631fe4a7108262c10 (diff)
vfs,mm: fix return value of read() at s_maxbytes
We truncated the possible read iterator to s_maxbytes in commit c2a9737f45e2 ("vfs,mm: fix a dead loop in truncate_inode_pages_range()"), but our end condition handling was wrong: it's not an error to try to read at the end of the file. Reading past the end should return EOF (0), not EINVAL. See for example https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1649342 http://lists.gnu.org/archive/html/bug-coreutils/2016-12/msg00008.html where a md5sum of a maximally sized file fails because the final read is exactly at s_maxbytes. Fixes: c2a9737f45e2 ("vfs,mm: fix a dead loop in truncate_inode_pages_range()") Reported-by: Joseph Salisbury <joseph.salisbury@canonical.com> Cc: Wei Fang <fangwei1@huawei.com> Cc: Christoph Hellwig <hch@infradead.org> Cc: Dave Chinner <david@fromorbit.com> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: stable@kernel.org Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat