/* * helpers for managing a buffer for many packets * * Copyright (c) Clemens Ladisch * Licensed under the terms of the GNU General Public License, version 2. */ #include #include #include #include "packets-buffer.h" /** * iso_packets_buffer_init - allocates the memory for packets * @b: the buffer structure to initialize * @unit: the device at the other end of the stream * @count: the number of packets * @packet_size: the (maximum) size of a packet, in bytes * @direction: %DMA_TO_DEVICE or %DMA_FROM_DEVICE */ int iso_packets_buffer_init(struct iso_packets_buffer *b, struct fw_unit *unit, unsigned int count, unsigned int packet_size, enum dma_data_direction direction) { unsigned int packets_per_page, pages; unsigned int i, page_index, offset_in_page; void *p; int err; b->packets = kmalloc(count * sizeof(*b->packets), GFP_KERNEL); if (!b->packets) { err = -ENOMEM; goto error; } packet_size = L1_CACHE_ALIGN(packet_size); packets_per_page = PAGE_SIZE / packet_size; if (WARN_ON(!packets_per_page)) { err = -EINVAL; goto error; } pages = DIV_ROUND_UP(count, packets_per_page); err = fw_iso_buffer_init(&b->iso_buffer, fw_parent_device(unit)->card, pages, direction); if (err < 0) goto err_packets; for (i = 0; i < count; ++i) { page_index = i / packets_per_page; p = page_address(b->iso_buffer.pages[page_index]); offset_in_page = (i % packets_per_page) * packet_size; b->packets[i].buffer = p + offset_in_page; b->packets[i].offset = page_index * PAGE_SIZE + offset_in_page; } return 0; err_packets: kfree(b->packets); error: return err; } EXPORT_SYMBOL(iso_packets_buffer_init); /** * iso_packets_buffer_destroy - frees packet buffer resources * @b: the buffer structure to free * @unit: the device at the other end of the stream */ void iso_packets_buffer_destroy(struct iso_packets_buffer *b, struct fw_unit *unit) { fw_iso_buffer_destroy(&b->iso_buffer, fw_parent_device(unit)->card); kfree(b->packets); } EXPORT_SYMBOL(iso_packets_buffer_destroy); e7b5c94eca944be9cd23dfc752'>commitdiff
diff options
context:
space:
mode:
authorChristoph Hellwig <hch@lst.de>2017-01-30 13:15:41 +0100
committerBjorn Helgaas <bhelgaas@google.com>2017-02-02 10:35:46 -0600
commitdfef358bd1beb4e7b5c94eca944be9cd23dfc752 (patch)
treeb9a2afb38a4c2ac8ad31f49ec0d71fe9e5b1994c /include/soc/nps/common.h
parent030305d69fc6963c16003f50d7e8d74b02d0a143 (diff)
PCI/MSI: Don't apply affinity if there aren't enough vectors left
Bart reported a problem wіth an out of bounds access in the low-level IRQ affinity code, which we root caused to the qla2xxx driver assigning all its MSI-X vectors to the pre and post vectors, and not having any left for the actually spread IRQs. Fix this issue by not asking for affinity assignment when there are no vectors to assign left. Fixes: 402723ad5c62 ("PCI/MSI: Provide pci_alloc_irq_vectors_affinity()") Link: https://lkml.kernel.org/r/1485359225.3093.3.camel@sandisk.com Reported-by: Bart Van Assche <bart.vanassche@sandisk.com> Tested-by: Bart Van Assche <bart.vanassche@sandisk.com> Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Diffstat (limited to 'include/soc/nps/common.h')