/* * Aztech AZT1605 Driver * Copyright (C) 2007,2010 Rene Herman * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation, either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program. If not, see . * */ #define AZT1605 #define CRD_NAME "Aztech AZT1605" #define DRV_NAME "AZT1605" #define DEV_NAME "azt1605" #define GALAXY_DSP_MAJOR 2 #define GALAXY_DSP_MINOR 1 #define GALAXY_CONFIG_SIZE 3 /* * 24-bit config register */ #define GALAXY_CONFIG_SBA_220 (0 << 0) #define GALAXY_CONFIG_SBA_240 (1 << 0) #define GALAXY_CONFIG_SBA_260 (2 << 0) #define GALAXY_CONFIG_SBA_280 (3 << 0) #define GALAXY_CONFIG_SBA_MASK GALAXY_CONFIG_SBA_280 #define GALAXY_CONFIG_MPUA_300 (0 << 2) #define GALAXY_CONFIG_MPUA_330 (1 << 2) #define GALAXY_CONFIG_MPU_ENABLE (1 << 3) #define GALAXY_CONFIG_GAME_ENABLE (1 << 4) #define GALAXY_CONFIG_CD_PANASONIC (1 << 5) #define GALAXY_CONFIG_CD_MITSUMI (1 << 6) #define GALAXY_CONFIG_CD_MASK (\ GALAXY_CONFIG_CD_PANASONIC | GALAXY_CONFIG_CD_MITSUMI) #define GALAXY_CONFIG_UNUSED (1 << 7) #define GALAXY_CONFIG_UNUSED_MASK GALAXY_CONFIG_UNUSED #define GALAXY_CONFIG_SBIRQ_2 (1 << 8) #define GALAXY_CONFIG_SBIRQ_3 (1 << 9) #define GALAXY_CONFIG_SBIRQ_5 (1 << 10) #define GALAXY_CONFIG_SBIRQ_7 (1 << 11) #define GALAXY_CONFIG_MPUIRQ_2 (1 << 12) #define GALAXY_CONFIG_MPUIRQ_3 (1 << 13) #define GALAXY_CONFIG_MPUIRQ_5 (1 << 14) #define GALAXY_CONFIG_MPUIRQ_7 (1 << 15) #define GALAXY_CONFIG_WSSA_530 (0 << 16) #define GALAXY_CONFIG_WSSA_604 (1 << 16) #define GALAXY_CONFIG_WSSA_E80 (2 << 16) #define GALAXY_CONFIG_WSSA_F40 (3 << 16) #define GALAXY_CONFIG_WSS_ENABLE (1 << 18) #define GALAXY_CONFIG_CDIRQ_11 (1 << 19) #define GALAXY_CONFIG_CDIRQ_12 (1 << 20) #define GALAXY_CONFIG_CDIRQ_15 (1 << 21) #define GALAXY_CONFIG_CDIRQ_MASK (\ GALAXY_CONFIG_CDIRQ_11 | GALAXY_CONFIG_CDIRQ_12 |\ GALAXY_CONFIG_CDIRQ_15) #define GALAXY_CONFIG_CDDMA_DISABLE (0 << 22) #define GALAXY_CONFIG_CDDMA_0 (1 << 22) #define GALAXY_CONFIG_CDDMA_1 (2 << 22) #define GALAXY_CONFIG_CDDMA_3 (3 << 22) #define GALAXY_CONFIG_CDDMA_MASK GALAXY_CONFIG_CDDMA_3 #define GALAXY_CONFIG_MASK (\ GALAXY_CONFIG_SBA_MASK | GALAXY_CONFIG_CD_MASK |\ GALAXY_CONFIG_UNUSED_MASK | GALAXY_CONFIG_CDIRQ_MASK |\ GALAXY_CONFIG_CDDMA_MASK) #include "galaxy.c" t?id=39cb2c9a316e77f6dfba96c543e55b6672d5a37e'>net/ipv6/reassembly.c
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
commit39cb2c9a316e77f6dfba96c543e55b6672d5a37e (patch)
tree98fe974ee4e20121253de7f61fc8d01bdb3821c1 /net/ipv6/reassembly.c
parent2c5d9555d6d937966d79d4c6529a5f7b9206e405 (diff)
drm/i915: Check for NULL i915_vma in intel_unpin_fb_obj()
I've seen this trigger twice now, where the i915_gem_object_to_ggtt() call in intel_unpin_fb_obj() returns NULL, resulting in an oops immediately afterwards as the (inlined) call to i915_vma_unpin_fence() tries to dereference it. It seems to be some race condition where the object is going away at shutdown time, since both times happened when shutting down the X server. The call chains were different: - VT ioctl(KDSETMODE, KD_TEXT): intel_cleanup_plane_fb+0x5b/0xa0 [i915] drm_atomic_helper_cleanup_planes+0x6f/0x90 [drm_kms_helper] intel_atomic_commit_tail+0x749/0xfe0 [i915] intel_atomic_commit+0x3cb/0x4f0 [i915] drm_atomic_commit+0x4b/0x50 [drm] restore_fbdev_mode+0x14c/0x2a0 [drm_kms_helper] drm_fb_helper_restore_fbdev_mode_unlocked+0x34/0x80 [drm_kms_helper] drm_fb_helper_set_par+0x2d/0x60 [drm_kms_helper] intel_fbdev_set_par+0x18/0x70 [i915] fb_set_var+0x236/0x460 fbcon_blank+0x30f/0x350 do_unblank_screen+0xd2/0x1a0 vt_ioctl+0x507/0x12a0 tty_ioctl+0x355/0xc30 do_vfs_ioctl+0xa3/0x5e0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x13/0x94 - i915 unpin_work workqueue: intel_unpin_work_fn+0x58/0x140 [i915] process_one_work+0x1f1/0x480 worker_thread+0x48/0x4d0 kthread+0x101/0x140 and this patch purely papers over the issue by adding a NULL pointer check and a WARN_ON_ONCE() to avoid the oops that would then generally make the machine unresponsive. Other callers of i915_gem_object_to_ggtt() seem to also check for the returned pointer being NULL and warn about it, so this clearly has happened before in other places. [ Reported it originally to the i915 developers on Jan 8, applying the ugly workaround on my own now after triggering the problem for the second time with no feedback. This is likely to be the same bug reported as https://bugs.freedesktop.org/show_bug.cgi?id=98829 https://bugs.freedesktop.org/show_bug.cgi?id=99134 which has a patch for the underlying problem, but it hasn't gotten to me, so I'm applying the workaround. ] Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'net/ipv6/reassembly.c')