/* * Initialisation code for Cyrix/NatSemi VSA1 softaudio * * (C) Copyright 2003 Red Hat Inc * * XpressAudio(tm) is used on the Cyrix MediaGX (now NatSemi Geode) systems. * The older version (VSA1) provides fairly good soundblaster emulation * although there are a couple of bugs: large DMA buffers break record, * and the MPU event handling seems suspect. VSA2 allows the native driver * to control the AC97 audio engine directly and requires a different driver. * * Thanks to National Semiconductor for providing the needed information * on the XpressAudio(tm) internals. * * This program is free software; you can redistribute it and/or modify it * under the terms of the GNU General Public License as published by the * Free Software Foundation; either version 2, or (at your option) any * later version. * * This program is distributed in the hope that it will be useful, but * WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * General Public License for more details. * * TO DO: * Investigate whether we can portably support Cognac (5520) in the * same manner. */ #include #include #include #include #include #include "sound_config.h" #include "sb.h" /* * Read a soundblaster compatible mixer register. * In this case we are actually reading an SMI trap * not real hardware. */ static u8 mixer_read(unsigned long io, u8 reg) { outb(reg, io + 4); udelay(20); reg = inb(io + 5); udelay(20); return reg; } static int probe_one(struct pci_dev *pdev, const struct pci_device_id *ent) { struct address_info *hw_config; unsigned long base; void __iomem *mem; unsigned long io; u16 map; u8 irq, dma8, dma16; int oldquiet; extern int sb_be_quiet; base = pci_resource_start(pdev, 0); if(base == 0UL) return 1; mem = ioremap(base, 128); if (!mem) return 1; map = readw(mem + 0x18); /* Read the SMI enables */ iounmap(mem); /* Map bits 0:1 * 0x20 + 0x200 = sb base 2 sb enable 3 adlib enable 5 MPU enable 0x330 6 MPU enable 0x300 The other bits may be used internally so must be masked */ io = 0x220 + 0x20 * (map & 3); if(map & (1<<2)) printk(KERN_INFO "kahlua: XpressAudio at 0x%lx\n", io); else return 1; if(map & (1<<5)) printk(KERN_INFO "kahlua: MPU at 0x300\n"); else if(map & (1<<6)) printk(KERN_INFO "kahlua: MPU at 0x330\n"); irq = mixer_read(io, 0x80) & 0x0F; dma8 = mixer_read(io, 0x81); // printk("IRQ=%x MAP=%x DMA=%x\n", irq, map, dma8); if(dma8 & 0x20) dma16 = 5; else if(dma8 & 0x40) dma16 = 6; else if(dma8 & 0x80) dma16 = 7; else { printk(KERN_ERR "kahlua: No 16bit DMA enabled.\n"); return 1; } if(dma8 & 0x01) dma8 = 0; else if(dma8 & 0x02) dma8 = 1; else if(dma8 & 0x08) dma8 = 3; else { printk(KERN_ERR "kahlua: No 8bit DMA enabled.\n"); return 1; } if(irq & 1) irq = 9; else if(irq & 2) irq = 5; else if(irq & 4) irq = 7; else if(irq & 8) irq = 10; else { printk(KERN_ERR "kahlua: SB IRQ not set.\n"); return 1; } printk(KERN_INFO "kahlua: XpressAudio on IRQ %d, DMA %d, %d\n", irq, dma8, dma16); hw_config = kzalloc(sizeof(struct address_info), GFP_KERNEL); if(hw_config == NULL) { printk(KERN_ERR "kahlua: out of memory.\n"); return 1; } pci_set_drvdata(pdev, hw_config); hw_config->io_base = io; hw_config->irq = irq; hw_config->dma = dma8; hw_config->dma2 = dma16; hw_config->name = "Cyrix XpressAudio"; hw_config->driver_use_1 = SB_NO_MIDI | SB_PCI_IRQ; if (!request_region(io, 16, "soundblaster")) goto err_out_free; if(sb_dsp_detect(hw_config, 0, 0, NULL)==0) { printk(KERN_ERR "kahlua: audio not responding.\n"); release_region(io, 16); goto err_out_free; } oldquiet = sb_be_quiet; sb_be_quiet = 1; if(sb_dsp_init(hw_config, THIS_MODULE)) { sb_be_quiet = oldquiet; goto err_out_free; } sb_be_quiet = oldquiet; return 0; err_out_free: kfree(hw_config); return 1; } static void remove_one(struct pci_dev *pdev) { struct address_info *hw_config = pci_get_drvdata(pdev); sb_dsp_unload(hw_config, 0); kfree(hw_config); } MODULE_AUTHOR("Alan Cox"); MODULE_DESCRIPTION("Kahlua VSA1 PCI Audio"); MODULE_LICENSE("GPL"); /* * 5530 only. The 5510/5520 decode is different. */ static const struct pci_device_id id_tbl[] = { { PCI_VDEVICE(CYRIX, PCI_DEVICE_ID_CYRIX_5530_AUDIO), 0 }, { } }; MODULE_DEVICE_TABLE(pci, id_tbl); static struct pci_driver kahlua_driver = { .name = "kahlua", .id_table = id_tbl, .probe = probe_one, .remove = remove_one, }; static int __init kahlua_init_module(void) { printk(KERN_INFO "Cyrix Kahlua VSA1 XpressAudio support (c) Copyright 2003 Red Hat Inc\n"); return pci_register_driver(&kahlua_driver); } static void kahlua_cleanup_module(void) { pci_unregister_driver(&kahlua_driver); } module_init(kahlua_init_module); module_exit(kahlua_cleanup_module); it/patch/fs/nfs/callback_xdr.c?id=39cb2c9a316e77f6dfba96c543e55b6672d5a37e'>patch) tree98fe974ee4e20121253de7f61fc8d01bdb3821c1 /fs/nfs/callback_xdr.c parent2c5d9555d6d937966d79d4c6529a5f7b9206e405 (diff)
drm/i915: Check for NULL i915_vma in intel_unpin_fb_obj()
I've seen this trigger twice now, where the i915_gem_object_to_ggtt() call in intel_unpin_fb_obj() returns NULL, resulting in an oops immediately afterwards as the (inlined) call to i915_vma_unpin_fence() tries to dereference it. It seems to be some race condition where the object is going away at shutdown time, since both times happened when shutting down the X server. The call chains were different: - VT ioctl(KDSETMODE, KD_TEXT): intel_cleanup_plane_fb+0x5b/0xa0 [i915] drm_atomic_helper_cleanup_planes+0x6f/0x90 [drm_kms_helper] intel_atomic_commit_tail+0x749/0xfe0 [i915] intel_atomic_commit+0x3cb/0x4f0 [i915] drm_atomic_commit+0x4b/0x50 [drm] restore_fbdev_mode+0x14c/0x2a0 [drm_kms_helper] drm_fb_helper_restore_fbdev_mode_unlocked+0x34/0x80 [drm_kms_helper] drm_fb_helper_set_par+0x2d/0x60 [drm_kms_helper] intel_fbdev_set_par+0x18/0x70 [i915] fb_set_var+0x236/0x460 fbcon_blank+0x30f/0x350 do_unblank_screen+0xd2/0x1a0 vt_ioctl+0x507/0x12a0 tty_ioctl+0x355/0xc30 do_vfs_ioctl+0xa3/0x5e0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x13/0x94 - i915 unpin_work workqueue: intel_unpin_work_fn+0x58/0x140 [i915] process_one_work+0x1f1/0x480 worker_thread+0x48/0x4d0 kthread+0x101/0x140 and this patch purely papers over the issue by adding a NULL pointer check and a WARN_ON_ONCE() to avoid the oops that would then generally make the machine unresponsive. Other callers of i915_gem_object_to_ggtt() seem to also check for the returned pointer being NULL and warn about it, so this clearly has happened before in other places. [ Reported it originally to the i915 developers on Jan 8, applying the ugly workaround on my own now after triggering the problem for the second time with no feedback. This is likely to be the same bug reported as https://bugs.freedesktop.org/show_bug.cgi?id=98829 https://bugs.freedesktop.org/show_bug.cgi?id=99134 which has a patch for the underlying problem, but it hasn't gotten to me, so I'm applying the workaround. ] Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/nfs/callback_xdr.c')