/***************************************************************************** AudioScience HPI driver Copyright (C) 1997-2011 AudioScience Inc. This program is free software; you can redistribute it and/or modify it under the terms of version 2 of the GNU General Public License as published by the Free Software Foundation; This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA Host Interface module for an ASI6205 based bus mastering PCI adapter. Copyright AudioScience, Inc., 2003 ******************************************************************************/ #ifndef _HPI6205_H_ #define _HPI6205_H_ #include "hpi_internal.h" /*********************************************************** Defines used for basic messaging ************************************************************/ #define H620_HIF_RESET 0 #define H620_HIF_IDLE 1 #define H620_HIF_GET_RESP 2 #define H620_HIF_DATA_DONE 3 #define H620_HIF_DATA_MASK 0x10 #define H620_HIF_SEND_DATA 0x14 #define H620_HIF_GET_DATA 0x15 #define H620_HIF_UNKNOWN 0x0000ffff /*********************************************************** Types used for mixer control caching ************************************************************/ #define H620_MAX_ISTREAMS 32 #define H620_MAX_OSTREAMS 32 #define HPI_NMIXER_CONTROLS 2048 /********************************************************************* This is used for dynamic control cache allocation **********************************************************************/ struct controlcache_6205 { u32 number_of_controls; u32 physical_address32; u32 size_in_bytes; }; /********************************************************************* This is used for dynamic allocation of async event array **********************************************************************/ struct async_event_buffer_6205 { u32 physical_address32; u32 spare; struct hpi_fifo_buffer b; }; /*********************************************************** The Host located memory buffer that the 6205 will bus master in and out of. ************************************************************/ #define HPI6205_SIZEOF_DATA (16*1024) struct message_buffer_6205 { struct hpi_message message; char data[256]; }; struct response_buffer_6205 { struct hpi_response response; char data[256]; }; union buffer_6205 { struct message_buffer_6205 message_buffer; struct response_buffer_6205 response_buffer; u8 b_data[HPI6205_SIZEOF_DATA]; }; struct bus_master_interface { u32 host_cmd; u32 dsp_ack; u32 transfer_size_in_bytes; union buffer_6205 u; struct controlcache_6205 control_cache; struct async_event_buffer_6205 async_buffer; struct hpi_hostbuffer_status instream_host_buffer_status[H620_MAX_ISTREAMS]; struct hpi_hostbuffer_status outstream_host_buffer_status[H620_MAX_OSTREAMS]; }; #endif commit/tools/testing/selftests/powerpc?id=39cb2c9a316e77f6dfba96c543e55b6672d5a37e'>powerpc/benchmarks
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
commit39cb2c9a316e77f6dfba96c543e55b6672d5a37e (patch)
tree98fe974ee4e20121253de7f61fc8d01bdb3821c1 /tools/testing/selftests/powerpc/benchmarks
parent2c5d9555d6d937966d79d4c6529a5f7b9206e405 (diff)
drm/i915: Check for NULL i915_vma in intel_unpin_fb_obj()
I've seen this trigger twice now, where the i915_gem_object_to_ggtt() call in intel_unpin_fb_obj() returns NULL, resulting in an oops immediately afterwards as the (inlined) call to i915_vma_unpin_fence() tries to dereference it. It seems to be some race condition where the object is going away at shutdown time, since both times happened when shutting down the X server. The call chains were different: - VT ioctl(KDSETMODE, KD_TEXT): intel_cleanup_plane_fb+0x5b/0xa0 [i915] drm_atomic_helper_cleanup_planes+0x6f/0x90 [drm_kms_helper] intel_atomic_commit_tail+0x749/0xfe0 [i915] intel_atomic_commit+0x3cb/0x4f0 [i915] drm_atomic_commit+0x4b/0x50 [drm] restore_fbdev_mode+0x14c/0x2a0 [drm_kms_helper] drm_fb_helper_restore_fbdev_mode_unlocked+0x34/0x80 [drm_kms_helper] drm_fb_helper_set_par+0x2d/0x60 [drm_kms_helper] intel_fbdev_set_par+0x18/0x70 [i915] fb_set_var+0x236/0x460 fbcon_blank+0x30f/0x350 do_unblank_screen+0xd2/0x1a0 vt_ioctl+0x507/0x12a0 tty_ioctl+0x355/0xc30 do_vfs_ioctl+0xa3/0x5e0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x13/0x94 - i915 unpin_work workqueue: intel_unpin_work_fn+0x58/0x140 [i915] process_one_work+0x1f1/0x480 worker_thread+0x48/0x4d0 kthread+0x101/0x140 and this patch purely papers over the issue by adding a NULL pointer check and a WARN_ON_ONCE() to avoid the oops that would then generally make the machine unresponsive. Other callers of i915_gem_object_to_ggtt() seem to also check for the returned pointer being NULL and warn about it, so this clearly has happened before in other places. [ Reported it originally to the i915 developers on Jan 8, applying the ugly workaround on my own now after triggering the problem for the second time with no feedback. This is likely to be the same bug reported as https://bugs.freedesktop.org/show_bug.cgi?id=98829 https://bugs.freedesktop.org/show_bug.cgi?id=99134 which has a patch for the underlying problem, but it hasn't gotten to me, so I'm applying the workaround. ] Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'tools/testing/selftests/powerpc/benchmarks')