/***************************************************************************** AudioScience HPI driver Copyright (C) 1997-2011 AudioScience Inc. This program is free software; you can redistribute it and/or modify it under the terms of version 2 of the GNU General Public License as published by the Free Software Foundation; This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA Host Interface module for an ASI6205 based bus mastering PCI adapter. Copyright AudioScience, Inc., 2003 ******************************************************************************/ #ifndef _HPI6205_H_ #define _HPI6205_H_ #include "hpi_internal.h" /*********************************************************** Defines used for basic messaging ************************************************************/ #define H620_HIF_RESET 0 #define H620_HIF_IDLE 1 #define H620_HIF_GET_RESP 2 #define H620_HIF_DATA_DONE 3 #define H620_HIF_DATA_MASK 0x10 #define H620_HIF_SEND_DATA 0x14 #define H620_HIF_GET_DATA 0x15 #define H620_HIF_UNKNOWN 0x0000ffff /*********************************************************** Types used for mixer control caching ************************************************************/ #define H620_MAX_ISTREAMS 32 #define H620_MAX_OSTREAMS 32 #define HPI_NMIXER_CONTROLS 2048 /********************************************************************* This is used for dynamic control cache allocation **********************************************************************/ struct controlcache_6205 { u32 number_of_controls; u32 physical_address32; u32 size_in_bytes; }; /********************************************************************* This is used for dynamic allocation of async event array **********************************************************************/ struct async_event_buffer_6205 { u32 physical_address32; u32 spare; struct hpi_fifo_buffer b; }; /*********************************************************** The Host located memory buffer that the 6205 will bus master in and out of. ************************************************************/ #define HPI6205_SIZEOF_DATA (16*1024) struct message_buffer_6205 { struct hpi_message message; char data[256]; }; struct response_buffer_6205 { struct hpi_response response; char data[256]; }; union buffer_6205 { struct message_buffer_6205 message_buffer; struct response_buffer_6205 response_buffer; u8 b_data[HPI6205_SIZEOF_DATA]; }; struct bus_master_interface { u32 host_cmd; u32 dsp_ack; u32 transfer_size_in_bytes; union buffer_6205 u; struct controlcache_6205 control_cache; struct async_event_buffer_6205 async_buffer; struct hpi_hostbuffer_status instream_host_buffer_status[H620_MAX_ISTREAMS]; struct hpi_hostbuffer_status outstream_host_buffer_status[H620_MAX_OSTREAMS]; }; #endif i/linux/net-next.git/commit/include/soc/tegra?h=nds-private-remove&id=91539eb1fda2d530d3b268eef542c5414e54bf1a'>tegra/ahb.h
diff options
context:
space:
mode:
authorIago Abal <mail@iagoabal.eu>2017-01-11 14:00:21 +0100
committerVinod Koul <vinod.koul@intel.com>2017-01-25 15:35:11 +0530
commit91539eb1fda2d530d3b268eef542c5414e54bf1a (patch)
tree960f5ca6342ad20837aff18aad6e8ecd7da32fd6 /include/soc/tegra/ahb.h
parent6610d0edf6dc7ee97e46ab3a538a565c79d26199 (diff)
dmaengine: pl330: fix double lock
The static bug finder EBA (http://www.iagoabal.eu/eba/) reported the following double-lock bug: Double lock: 1. spin_lock_irqsave(pch->lock, flags) at pl330_free_chan_resources:2236; 2. call to function `pl330_release_channel' immediately after; 3. call to function `dma_pl330_rqcb' in line 1753; 4. spin_lock_irqsave(pch->lock, flags) at dma_pl330_rqcb:1505. I have fixed it as suggested by Marek Szyprowski. First, I have replaced `pch->lock' with `pl330->lock' in functions `pl330_alloc_chan_resources' and `pl330_free_chan_resources'. This avoids the double-lock by acquiring a different lock than `dma_pl330_rqcb'. NOTE that, as a result, `pl330_free_chan_resources' executes `list_splice_tail_init' on `pch->work_list' under lock `pl330->lock', whereas in the rest of the code `pch->work_list' is protected by `pch->lock'. I don't know if this may cause race conditions. Similarly `pch->cyclic' is written by `pl330_alloc_chan_resources' under `pl330->lock' but read by `pl330_tx_submit' under `pch->lock'. Second, I have removed locking from `pl330_request_channel' and `pl330_release_channel' functions. Function `pl330_request_channel' is only called from `pl330_alloc_chan_resources', so the lock is already held. Function `pl330_release_channel' is called from `pl330_free_chan_resources', which already holds the lock, and from `pl330_del'. Function `pl330_del' is called in an error path of `pl330_probe' and at the end of `pl330_remove', but I assume that there cannot be concurrent accesses to the protected data at those points. Signed-off-by: Iago Abal <mail@iagoabal.eu> Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'include/soc/tegra/ahb.h')