/****************************************************************************** AudioScience HPI driver Copyright (C) 1997-2014 AudioScience Inc. This program is free software; you can redistribute it and/or modify it under the terms of version 2 of the GNU General Public License as published by the Free Software Foundation; This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA Hardware Programming Interface (HPI) Utility functions. (C) Copyright AudioScience Inc. 2007 *******************************************************************************/ #include "hpi_internal.h" #include "hpimsginit.h" /* The actual message size for each object type */ static u16 msg_size[HPI_OBJ_MAXINDEX + 1] = HPI_MESSAGE_SIZE_BY_OBJECT; /* The actual response size for each object type */ static u16 res_size[HPI_OBJ_MAXINDEX + 1] = HPI_RESPONSE_SIZE_BY_OBJECT; /* Flag to enable alternate message type for SSX2 bypass. */ static u16 gwSSX2_bypass; /** \internal * initialize the HPI message structure */ static void hpi_init_message(struct hpi_message *phm, u16 object, u16 function) { u16 size; if ((object > 0) && (object <= HPI_OBJ_MAXINDEX)) size = msg_size[object]; else size = sizeof(*phm); memset(phm, 0, size); phm->size = size; if (gwSSX2_bypass) phm->type = HPI_TYPE_SSX2BYPASS_MESSAGE; else phm->type = HPI_TYPE_REQUEST; phm->object = object; phm->function = function; phm->version = 0; phm->adapter_index = HPI_ADAPTER_INDEX_INVALID; /* Expect actual adapter index to be set by caller */ } /** \internal * initialize the HPI response structure */ void hpi_init_response(struct hpi_response *phr, u16 object, u16 function, u16 error) { u16 size; if ((object > 0) && (object <= HPI_OBJ_MAXINDEX)) size = res_size[object]; else size = sizeof(*phr); memset(phr, 0, sizeof(*phr)); phr->size = size; phr->type = HPI_TYPE_RESPONSE; phr->object = object; phr->function = function; phr->error = error; phr->specific_error = 0; phr->version = 0; } void hpi_init_message_response(struct hpi_message *phm, struct hpi_response *phr, u16 object, u16 function) { hpi_init_message(phm, object, function); /* default error return if the response is not filled in by the callee */ hpi_init_response(phr, object, function, HPI_ERROR_PROCESSING_MESSAGE); } static void hpi_init_messageV1(struct hpi_message_header *phm, u16 size, u16 object, u16 function) { memset(phm, 0, size); if ((object > 0) && (object <= HPI_OBJ_MAXINDEX)) { phm->size = size; phm->type = HPI_TYPE_REQUEST; phm->object = object; phm->function = function; phm->version = 1; /* Expect adapter index to be set by caller */ } } void hpi_init_responseV1(struct hpi_response_header *phr, u16 size, u16 object, u16 function) { (void)object; (void)function; memset(phr, 0, size); phr->size = size; phr->version = 1; phr->type = HPI_TYPE_RESPONSE; phr->error = HPI_ERROR_PROCESSING_MESSAGE; } void hpi_init_message_responseV1(struct hpi_message_header *phm, u16 msg_size, struct hpi_response_header *phr, u16 res_size, u16 object, u16 function) { hpi_init_messageV1(phm, msg_size, object, function); hpi_init_responseV1(phr, res_size, object, function); } n value='8'>8space:mode:
authorTejun Heo <tj@kernel.org>2017-01-26 16:47:28 -0500
committerTejun Heo <tj@kernel.org>2017-01-26 16:47:28 -0500
commit07cd12945551b63ecb1a349d50a6d69d1d6feb4a (patch)
tree75f65eba7eac9277971082a2d5a4cf1370562c0c /include/net/transp_v6.h
parent7ce7d89f48834cefece7804d38fc5d85382edf77 (diff)
cgroup: don't online subsystems before cgroup_name/path() are operational
While refactoring cgroup creation, a5bca2152036 ("cgroup: factor out cgroup_create() out of cgroup_mkdir()") incorrectly onlined subsystems before the new cgroup is associated with it kernfs_node. This is fine for cgroup proper but cgroup_name/path() depend on the associated kernfs_node and if a subsystem makes the new cgroup_subsys_state visible, which they're allowed to after onlining, it can lead to NULL dereference. The current code performs cgroup creation and subsystem onlining in cgroup_create() and cgroup_mkdir() makes the cgroup and subsystems visible afterwards. There's no reason to online the subsystems early and we can simply drop cgroup_apply_control_enable() call from cgroup_create() so that the subsystems are onlined and made visible at the same time. Signed-off-by: Tejun Heo <tj@kernel.org> Reported-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru> Fixes: a5bca2152036 ("cgroup: factor out cgroup_create() out of cgroup_mkdir()") Cc: stable@vger.kernel.org # v4.6+
Diffstat (limited to 'include/net/transp_v6.h')