/* * Copyright 10/16/2005 Tilman Kranz * Creative Audio MIDI, for the CA0106 Driver * Version: 0.0.1 * * Changelog: * See ca_midi.c * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA * */ #include #include #include #define CA_MIDI_MODE_INPUT MPU401_MODE_INPUT #define CA_MIDI_MODE_OUTPUT MPU401_MODE_OUTPUT struct snd_ca_midi { struct snd_rawmidi *rmidi; struct snd_rawmidi_substream *substream_input; struct snd_rawmidi_substream *substream_output; void *dev_id; spinlock_t input_lock; spinlock_t output_lock; spinlock_t open_lock; unsigned int channel; unsigned int midi_mode; int port; int tx_enable, rx_enable; int ipr_tx, ipr_rx; int input_avail, output_ready; int ack, reset, enter_uart; void (*interrupt)(struct snd_ca_midi *midi, unsigned int status); void (*interrupt_enable)(struct snd_ca_midi *midi, int intr); void (*interrupt_disable)(struct snd_ca_midi *midi, int intr); unsigned char (*read)(struct snd_ca_midi *midi, int idx); void (*write)(struct snd_ca_midi *midi, int data, int idx); /* get info from dev_id */ struct snd_card *(*get_dev_id_card)(void *dev_id); int (*get_dev_id_port)(void *dev_id); }; int ca_midi_init(void *card, struct snd_ca_midi *midi, int device, char *name); nux/net-next.git/diff/sound/soc/sirf?id=07cd12945551b63ecb1a349d50a6d69d1d6feb4a'>diff
diff options
context:
space:
mode:
authorTejun Heo <tj@kernel.org>2017-01-26 16:47:28 -0500
committerTejun Heo <tj@kernel.org>2017-01-26 16:47:28 -0500
commit07cd12945551b63ecb1a349d50a6d69d1d6feb4a (patch)
tree75f65eba7eac9277971082a2d5a4cf1370562c0c /sound/soc/sirf
parent7ce7d89f48834cefece7804d38fc5d85382edf77 (diff)
cgroup: don't online subsystems before cgroup_name/path() are operational
While refactoring cgroup creation, a5bca2152036 ("cgroup: factor out cgroup_create() out of cgroup_mkdir()") incorrectly onlined subsystems before the new cgroup is associated with it kernfs_node. This is fine for cgroup proper but cgroup_name/path() depend on the associated kernfs_node and if a subsystem makes the new cgroup_subsys_state visible, which they're allowed to after onlining, it can lead to NULL dereference. The current code performs cgroup creation and subsystem onlining in cgroup_create() and cgroup_mkdir() makes the cgroup and subsystems visible afterwards. There's no reason to online the subsystems early and we can simply drop cgroup_apply_control_enable() call from cgroup_create() so that the subsystems are onlined and made visible at the same time. Signed-off-by: Tejun Heo <tj@kernel.org> Reported-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru> Fixes: a5bca2152036 ("cgroup: factor out cgroup_create() out of cgroup_mkdir()") Cc: stable@vger.kernel.org # v4.6+
Diffstat (limited to 'sound/soc/sirf')