#ifndef __SOUND_EWS_H #define __SOUND_EWS_H /* * ALSA driver for ICEnsemble ICE1712 (Envy24) * * Lowlevel functions for Terratec EWS88MT/D, EWX24/96, DMX 6Fire * * Copyright (c) 2000 Jaroslav Kysela * 2002 Takashi Iwai * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA * */ #define EWS_DEVICE_DESC \ "{TerraTec,EWX 24/96},"\ "{TerraTec,EWS 88MT},"\ "{TerraTec,EWS 88D},"\ "{TerraTec,DMX 6Fire},"\ "{TerraTec,Phase 88}," \ "{terrasoniq,TS 88}," #define ICE1712_SUBDEVICE_EWX2496 0x3b153011 #define ICE1712_SUBDEVICE_EWS88MT 0x3b151511 #define ICE1712_SUBDEVICE_EWS88MT_NEW 0x3b152511 #define ICE1712_SUBDEVICE_EWS88D 0x3b152b11 #define ICE1712_SUBDEVICE_DMX6FIRE 0x3b153811 #define ICE1712_SUBDEVICE_PHASE88 0x3b155111 #define ICE1712_SUBDEVICE_TS88 0x3b157c11 /* entry point */ extern struct snd_ice1712_card_info snd_ice1712_ews_cards[]; /* TerraTec EWX 24/96 configuration definitions */ #define ICE1712_EWX2496_AK4524_CS 0x01 /* AK4524 chip select; low = active */ #define ICE1712_EWX2496_AIN_SEL 0x02 /* input sensitivity switch; high = louder */ #define ICE1712_EWX2496_AOUT_SEL 0x04 /* output sensitivity switch; high = louder */ #define ICE1712_EWX2496_RW 0x08 /* read/write switch for i2c; high = write */ #define ICE1712_EWX2496_SERIAL_DATA 0x10 /* i2c & ak4524 data */ #define ICE1712_EWX2496_SERIAL_CLOCK 0x20 /* i2c & ak4524 clock */ #define ICE1712_EWX2496_TX2 0x40 /* MIDI2 (not used) */ #define ICE1712_EWX2496_RX2 0x80 /* MIDI2 (not used) */ /* TerraTec EWS 88MT/D configuration definitions */ /* RW, SDA snd SCLK are identical with EWX24/96 */ #define ICE1712_EWS88_CS8414_RATE 0x07 /* CS8414 sample rate: gpio 0-2 */ #define ICE1712_EWS88_RW 0x08 /* read/write switch for i2c; high = write */ #define ICE1712_EWS88_SERIAL_DATA 0x10 /* i2c & ak4524 data */ #define ICE1712_EWS88_SERIAL_CLOCK 0x20 /* i2c & ak4524 clock */ #define ICE1712_EWS88_TX2 0x40 /* MIDI2 (only on 88D) */ #define ICE1712_EWS88_RX2 0x80 /* MIDI2 (only on 88D) */ /* i2c address */ #define ICE1712_EWS88MT_CS8404_ADDR (0x40>>1) #define ICE1712_EWS88MT_INPUT_ADDR (0x46>>1) #define ICE1712_EWS88MT_OUTPUT_ADDR (0x48>>1) #define ICE1712_EWS88MT_OUTPUT_SENSE 0x40 /* mask */ #define ICE1712_EWS88D_PCF_ADDR (0x40>>1) /* TerraTec DMX 6Fire configuration definitions */ #define ICE1712_6FIRE_AK4524_CS_MASK 0x07 /* AK4524 chip select #1-#3 */ #define ICE1712_6FIRE_RW 0x08 /* read/write switch for i2c; high = write */ #define ICE1712_6FIRE_SERIAL_DATA 0x10 /* i2c & ak4524 data */ #define ICE1712_6FIRE_SERIAL_CLOCK 0x20 /* i2c & ak4524 clock */ #define ICE1712_6FIRE_TX2 0x40 /* MIDI2 */ #define ICE1712_6FIRE_RX2 0x80 /* MIDI2 */ #define ICE1712_6FIRE_PCF9554_ADDR (0x40>>1) #define ICE1712_6FIRE_CS8427_ADDR (0x22) #endif /* __SOUND_EWS_H */ ommit/sound/firewire/oxfw/Makefile?h=nds-private-remove&id=91539eb1fda2d530d3b268eef542c5414e54bf1a'>Makefile
diff options
context:
space:
mode:
authorIago Abal <mail@iagoabal.eu>2017-01-11 14:00:21 +0100
committerVinod Koul <vinod.koul@intel.com>2017-01-25 15:35:11 +0530
commit91539eb1fda2d530d3b268eef542c5414e54bf1a (patch)
tree960f5ca6342ad20837aff18aad6e8ecd7da32fd6 /sound/firewire/oxfw/Makefile
parent6610d0edf6dc7ee97e46ab3a538a565c79d26199 (diff)
dmaengine: pl330: fix double lock
The static bug finder EBA (http://www.iagoabal.eu/eba/) reported the following double-lock bug: Double lock: 1. spin_lock_irqsave(pch->lock, flags) at pl330_free_chan_resources:2236; 2. call to function `pl330_release_channel' immediately after; 3. call to function `dma_pl330_rqcb' in line 1753; 4. spin_lock_irqsave(pch->lock, flags) at dma_pl330_rqcb:1505. I have fixed it as suggested by Marek Szyprowski. First, I have replaced `pch->lock' with `pl330->lock' in functions `pl330_alloc_chan_resources' and `pl330_free_chan_resources'. This avoids the double-lock by acquiring a different lock than `dma_pl330_rqcb'. NOTE that, as a result, `pl330_free_chan_resources' executes `list_splice_tail_init' on `pch->work_list' under lock `pl330->lock', whereas in the rest of the code `pch->work_list' is protected by `pch->lock'. I don't know if this may cause race conditions. Similarly `pch->cyclic' is written by `pl330_alloc_chan_resources' under `pl330->lock' but read by `pl330_tx_submit' under `pch->lock'. Second, I have removed locking from `pl330_request_channel' and `pl330_release_channel' functions. Function `pl330_request_channel' is only called from `pl330_alloc_chan_resources', so the lock is already held. Function `pl330_release_channel' is called from `pl330_free_chan_resources', which already holds the lock, and from `pl330_del'. Function `pl330_del' is called in an error path of `pl330_probe' and at the end of `pl330_remove', but I assume that there cannot be concurrent accesses to the protected data at those points. Signed-off-by: Iago Abal <mail@iagoabal.eu> Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'sound/firewire/oxfw/Makefile')