/* * sam9x5_wm8731 -- SoC audio for AT91SAM9X5-based boards * that are using WM8731 as codec. * * Copyright (C) 2011 Atmel, * Nicolas Ferre * * Copyright (C) 2013 Paratronic, * Richard Genoud * * Based on sam9g20_wm8731.c by: * Sedji Gaouaou * * This program is free software; you can redistribute it and/or modify it * under the terms of the GNU General Public License as published by the * Free Software Foundation; either version 2 of the License, or (at your * option) any later version. * */ #include #include #include #include #include #include #include #include #include #include "../codecs/wm8731.h" #include "atmel_ssc_dai.h" #define MCLK_RATE 12288000 #define DRV_NAME "sam9x5-snd-wm8731" struct sam9x5_drvdata { int ssc_id; }; /* * Logic for a wm8731 as connected on a at91sam9x5ek based board. */ static int sam9x5_wm8731_init(struct snd_soc_pcm_runtime *rtd) { struct snd_soc_dai *codec_dai = rtd->codec_dai; struct device *dev = rtd->dev; int ret; dev_dbg(dev, "ASoC: %s called\n", __func__); /* set the codec system clock for DAC and ADC */ ret = snd_soc_dai_set_sysclk(codec_dai, WM8731_SYSCLK_XTAL, MCLK_RATE, SND_SOC_CLOCK_IN); if (ret < 0) { dev_err(dev, "ASoC: Failed to set WM8731 SYSCLK: %d\n", ret); return ret; } return 0; } /* * Audio paths on at91sam9x5ek board: * * |A| ------------> | | ---R----> Headphone Jack * |T| <----\ | WM | ---L--/ * |9| ---> CLK <--> | 8731 | <--R----- Line In Jack * |1| <------------ | | <--L--/ */ static const struct snd_soc_dapm_widget sam9x5_dapm_widgets[] = { SND_SOC_DAPM_HP("Headphone Jack", NULL), SND_SOC_DAPM_LINE("Line In Jack", NULL), }; static int sam9x5_wm8731_driver_probe(struct platform_device *pdev) { struct device_node *np = pdev->dev.of_node; struct device_node *codec_np, *cpu_np; struct snd_soc_card *card; struct snd_soc_dai_link *dai; struct sam9x5_drvdata *priv; int ret; if (!np) { dev_err(&pdev->dev, "No device node supplied\n"); return -EINVAL; } card = devm_kzalloc(&pdev->dev, sizeof(*card), GFP_KERNEL); priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); dai = devm_kzalloc(&pdev->dev, sizeof(*dai), GFP_KERNEL); if (!dai || !card || !priv) { ret = -ENOMEM; goto out; } snd_soc_card_set_drvdata(card, priv); card->dev = &pdev->dev; card->owner = THIS_MODULE; card->dai_link = dai; card->num_links = 1; card->dapm_widgets = sam9x5_dapm_widgets; card->num_dapm_widgets = ARRAY_SIZE(sam9x5_dapm_widgets); dai->name = "WM8731"; dai->stream_name = "WM8731 PCM"; dai->codec_dai_name = "wm8731-hifi"; dai->init = sam9x5_wm8731_init; dai->dai_fmt = SND_SOC_DAIFMT_DSP_A | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBM_CFM; ret = snd_soc_of_parse_card_name(card, "atmel,model"); if (ret) { dev_err(&pdev->dev, "atmel,model node missing\n"); goto out; } ret = snd_soc_of_parse_audio_routing(card, "atmel,audio-routing"); if (ret) { dev_err(&pdev->dev, "atmel,audio-routing node missing\n"); goto out; } codec_np = of_parse_phandle(np, "atmel,audio-codec", 0); if (!codec_np) { dev_err(&pdev->dev, "atmel,audio-codec node missing\n"); ret = -EINVAL; goto out; } dai->codec_of_node = codec_np; cpu_np = of_parse_phandle(np, "atmel,ssc-controller", 0); if (!cpu_np) { dev_err(&pdev->dev, "atmel,ssc-controller node missing\n"); ret = -EINVAL; goto out; } dai->cpu_of_node = cpu_np; dai->platform_of_node = cpu_np; priv->ssc_id = of_alias_get_id(cpu_np, "ssc"); ret = atmel_ssc_set_audio(priv->ssc_id); if (ret != 0) { dev_err(&pdev->dev, "ASoC: Failed to set SSC %d for audio: %d\n", ret, priv->ssc_id); goto out; } of_node_put(codec_np); of_node_put(cpu_np); ret = snd_soc_register_card(card); if (ret) { dev_err(&pdev->dev, "ASoC: Platform device allocation failed\n"); goto out_put_audio; } dev_dbg(&pdev->dev, "ASoC: %s ok\n", __func__); return ret; out_put_audio: atmel_ssc_put_audio(priv->ssc_id); out: return ret; } static int sam9x5_wm8731_driver_remove(struct platform_device *pdev) { struct snd_soc_card *card = platform_get_drvdata(pdev); struct sam9x5_drvdata *priv = card->drvdata; snd_soc_unregister_card(card); atmel_ssc_put_audio(priv->ssc_id); return 0; } static const struct of_device_id sam9x5_wm8731_of_match[] = { { .compatible = "atmel,sam9x5-wm8731-audio", }, {}, }; MODULE_DEVICE_TABLE(of, sam9x5_wm8731_of_match); static struct platform_driver sam9x5_wm8731_driver = { .driver = { .name = DRV_NAME, .of_match_table = of_match_ptr(sam9x5_wm8731_of_match), }, .probe = sam9x5_wm8731_driver_probe, .remove = sam9x5_wm8731_driver_remove, }; module_platform_driver(sam9x5_wm8731_driver); /* Module information */ MODULE_AUTHOR("Nicolas Ferre "); MODULE_AUTHOR("Richard Genoud "); MODULE_DESCRIPTION("ALSA SoC machine driver for AT91SAM9x5 - WM8731"); MODULE_LICENSE("GPL"); MODULE_ALIAS("platform:" DRV_NAME); 9a316e77f6dfba96c543e55b6672d5a37e'>patch) tree98fe974ee4e20121253de7f61fc8d01bdb3821c1 /sound/soc/codecs/ssm2602.c parent2c5d9555d6d937966d79d4c6529a5f7b9206e405 (diff)
drm/i915: Check for NULL i915_vma in intel_unpin_fb_obj()
I've seen this trigger twice now, where the i915_gem_object_to_ggtt() call in intel_unpin_fb_obj() returns NULL, resulting in an oops immediately afterwards as the (inlined) call to i915_vma_unpin_fence() tries to dereference it. It seems to be some race condition where the object is going away at shutdown time, since both times happened when shutting down the X server. The call chains were different: - VT ioctl(KDSETMODE, KD_TEXT): intel_cleanup_plane_fb+0x5b/0xa0 [i915] drm_atomic_helper_cleanup_planes+0x6f/0x90 [drm_kms_helper] intel_atomic_commit_tail+0x749/0xfe0 [i915] intel_atomic_commit+0x3cb/0x4f0 [i915] drm_atomic_commit+0x4b/0x50 [drm] restore_fbdev_mode+0x14c/0x2a0 [drm_kms_helper] drm_fb_helper_restore_fbdev_mode_unlocked+0x34/0x80 [drm_kms_helper] drm_fb_helper_set_par+0x2d/0x60 [drm_kms_helper] intel_fbdev_set_par+0x18/0x70 [i915] fb_set_var+0x236/0x460 fbcon_blank+0x30f/0x350 do_unblank_screen+0xd2/0x1a0 vt_ioctl+0x507/0x12a0 tty_ioctl+0x355/0xc30 do_vfs_ioctl+0xa3/0x5e0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x13/0x94 - i915 unpin_work workqueue: intel_unpin_work_fn+0x58/0x140 [i915] process_one_work+0x1f1/0x480 worker_thread+0x48/0x4d0 kthread+0x101/0x140 and this patch purely papers over the issue by adding a NULL pointer check and a WARN_ON_ONCE() to avoid the oops that would then generally make the machine unresponsive. Other callers of i915_gem_object_to_ggtt() seem to also check for the returned pointer being NULL and warn about it, so this clearly has happened before in other places. [ Reported it originally to the i915 developers on Jan 8, applying the ugly workaround on my own now after triggering the problem for the second time with no feedback. This is likely to be the same bug reported as https://bugs.freedesktop.org/show_bug.cgi?id=98829 https://bugs.freedesktop.org/show_bug.cgi?id=99134 which has a patch for the underlying problem, but it hasn't gotten to me, so I'm applying the workaround. ] Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'sound/soc/codecs/ssm2602.c')