/* * Machine driver for EVAL-ADAV801 and EVAL-ADAV803 on Analog Devices bfin * evaluation boards. * * Copyright 2011 Analog Devices Inc. * Author: Lars-Peter Clausen * * Licensed under the GPL-2 or later. */ #include #include #include #include #include #include #include "../codecs/adav80x.h" static const struct snd_soc_dapm_widget bfin_eval_adav80x_dapm_widgets[] = { SND_SOC_DAPM_LINE("Line Out", NULL), SND_SOC_DAPM_LINE("Line In", NULL), }; static const struct snd_soc_dapm_route bfin_eval_adav80x_dapm_routes[] = { { "Line Out", NULL, "VOUTL" }, { "Line Out", NULL, "VOUTR" }, { "VINL", NULL, "Line In" }, { "VINR", NULL, "Line In" }, }; static int bfin_eval_adav80x_hw_params(struct snd_pcm_substream *substream, struct snd_pcm_hw_params *params) { struct snd_soc_pcm_runtime *rtd = substream->private_data; struct snd_soc_dai *codec_dai = rtd->codec_dai; int ret; ret = snd_soc_dai_set_pll(codec_dai, ADAV80X_PLL1, ADAV80X_PLL_SRC_XTAL, 27000000, params_rate(params) * 256); if (ret) return ret; ret = snd_soc_dai_set_sysclk(codec_dai, ADAV80X_CLK_PLL1, params_rate(params) * 256, SND_SOC_CLOCK_IN); return ret; } static int bfin_eval_adav80x_codec_init(struct snd_soc_pcm_runtime *rtd) { struct snd_soc_dai *codec_dai = rtd->codec_dai; snd_soc_dai_set_sysclk(codec_dai, ADAV80X_CLK_SYSCLK1, 0, SND_SOC_CLOCK_OUT); snd_soc_dai_set_sysclk(codec_dai, ADAV80X_CLK_SYSCLK2, 0, SND_SOC_CLOCK_OUT); snd_soc_dai_set_sysclk(codec_dai, ADAV80X_CLK_SYSCLK3, 0, SND_SOC_CLOCK_OUT); snd_soc_dai_set_sysclk(codec_dai, ADAV80X_CLK_XTAL, 2700000, 0); return 0; } static struct snd_soc_ops bfin_eval_adav80x_ops = { .hw_params = bfin_eval_adav80x_hw_params, }; static struct snd_soc_dai_link bfin_eval_adav80x_dais[] = { { .name = "adav80x", .stream_name = "ADAV80x HiFi", .cpu_dai_name = "bfin-i2s.0", .codec_dai_name = "adav80x-hifi", .platform_name = "bfin-i2s-pcm-audio", .init = bfin_eval_adav80x_codec_init, .ops = &bfin_eval_adav80x_ops, .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBM_CFM, }, }; static struct snd_soc_card bfin_eval_adav80x = { .name = "bfin-eval-adav80x", .owner = THIS_MODULE, .dai_link = bfin_eval_adav80x_dais, .num_links = ARRAY_SIZE(bfin_eval_adav80x_dais), .dapm_widgets = bfin_eval_adav80x_dapm_widgets, .num_dapm_widgets = ARRAY_SIZE(bfin_eval_adav80x_dapm_widgets), .dapm_routes = bfin_eval_adav80x_dapm_routes, .num_dapm_routes = ARRAY_SIZE(bfin_eval_adav80x_dapm_routes), }; enum bfin_eval_adav80x_type { BFIN_EVAL_ADAV801, BFIN_EVAL_ADAV803, }; static int bfin_eval_adav80x_probe(struct platform_device *pdev) { struct snd_soc_card *card = &bfin_eval_adav80x; const char *codec_name; switch (platform_get_device_id(pdev)->driver_data) { case BFIN_EVAL_ADAV801: codec_name = "spi0.1"; break; case BFIN_EVAL_ADAV803: codec_name = "adav803.0-0034"; break; default: return -EINVAL; } bfin_eval_adav80x_dais[0].codec_name = codec_name; card->dev = &pdev->dev; return devm_snd_soc_register_card(&pdev->dev, &bfin_eval_adav80x); } static const struct platform_device_id bfin_eval_adav80x_ids[] = { { "bfin-eval-adav801", BFIN_EVAL_ADAV801 }, { "bfin-eval-adav803", BFIN_EVAL_ADAV803 }, { }, }; MODULE_DEVICE_TABLE(platform, bfin_eval_adav80x_ids); static struct platform_driver bfin_eval_adav80x_driver = { .driver = { .name = "bfin-eval-adav80x", .pm = &snd_soc_pm_ops, }, .probe = bfin_eval_adav80x_probe, .id_table = bfin_eval_adav80x_ids, }; module_platform_driver(bfin_eval_adav80x_driver); MODULE_AUTHOR("Lars-Peter Clausen "); MODULE_DESCRIPTION("ALSA SoC bfin adav80x driver"); MODULE_LICENSE("GPL"); space:mode:
authorIago Abal <mail@iagoabal.eu>2017-01-11 14:00:21 +0100
committerVinod Koul <vinod.koul@intel.com>2017-01-25 15:35:11 +0530
commit91539eb1fda2d530d3b268eef542c5414e54bf1a (patch)
tree960f5ca6342ad20837aff18aad6e8ecd7da32fd6 /tools/testing/selftests/x86/Makefile
parent6610d0edf6dc7ee97e46ab3a538a565c79d26199 (diff)
dmaengine: pl330: fix double lock
The static bug finder EBA (http://www.iagoabal.eu/eba/) reported the following double-lock bug: Double lock: 1. spin_lock_irqsave(pch->lock, flags) at pl330_free_chan_resources:2236; 2. call to function `pl330_release_channel' immediately after; 3. call to function `dma_pl330_rqcb' in line 1753; 4. spin_lock_irqsave(pch->lock, flags) at dma_pl330_rqcb:1505. I have fixed it as suggested by Marek Szyprowski. First, I have replaced `pch->lock' with `pl330->lock' in functions `pl330_alloc_chan_resources' and `pl330_free_chan_resources'. This avoids the double-lock by acquiring a different lock than `dma_pl330_rqcb'. NOTE that, as a result, `pl330_free_chan_resources' executes `list_splice_tail_init' on `pch->work_list' under lock `pl330->lock', whereas in the rest of the code `pch->work_list' is protected by `pch->lock'. I don't know if this may cause race conditions. Similarly `pch->cyclic' is written by `pl330_alloc_chan_resources' under `pl330->lock' but read by `pl330_tx_submit' under `pch->lock'. Second, I have removed locking from `pl330_request_channel' and `pl330_release_channel' functions. Function `pl330_request_channel' is only called from `pl330_alloc_chan_resources', so the lock is already held. Function `pl330_release_channel' is called from `pl330_free_chan_resources', which already holds the lock, and from `pl330_del'. Function `pl330_del' is called in an error path of `pl330_probe' and at the end of `pl330_remove', but I assume that there cannot be concurrent accesses to the protected data at those points. Signed-off-by: Iago Abal <mail@iagoabal.eu> Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'tools/testing/selftests/x86/Makefile')