/* * cs35l32.h -- CS35L32 ALSA SoC audio driver * * Copyright 2014 CirrusLogic, Inc. * * Author: Brian Austin * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2 as * published by the Free Software Foundation. * */ #ifndef __CS35L32_H__ #define __CS35L32_H__ struct cs35l32_platform_data { /* Low Battery Threshold */ unsigned int batt_thresh; /* Low Battery Recovery */ unsigned int batt_recov; /* LED Current Management*/ unsigned int led_mng; /* Audio Gain w/ LED */ unsigned int audiogain_mng; /* Boost Management */ unsigned int boost_mng; /* Data CFG for DUAL device */ unsigned int sdout_datacfg; /* SDOUT Sharing */ unsigned int sdout_share; }; #define CS35L32_CHIP_ID 0x00035A32 #define CS35L32_DEVID_AB 0x01 /* Device ID A & B [RO] */ #define CS35L32_DEVID_CD 0x02 /* Device ID C & D [RO] */ #define CS35L32_DEVID_E 0x03 /* Device ID E [RO] */ #define CS35L32_FAB_ID 0x04 /* Fab ID [RO] */ #define CS35L32_REV_ID 0x05 /* Revision ID [RO] */ #define CS35L32_PWRCTL1 0x06 /* Power Ctl 1 */ #define CS35L32_PWRCTL2 0x07 /* Power Ctl 2 */ #define CS35L32_CLK_CTL 0x08 /* Clock Ctl */ #define CS35L32_BATT_THRESHOLD 0x09 /* Low Battery Threshold */ #define CS35L32_VMON 0x0A /* Voltage Monitor [RO] */ #define CS35L32_BST_CPCP_CTL 0x0B /* Conv Peak Curr Protection CTL */ #define CS35L32_IMON_SCALING 0x0C /* IMON Scaling */ #define CS35L32_AUDIO_LED_MNGR 0x0D /* Audio/LED Pwr Manager */ #define CS35L32_ADSP_CTL 0x0F /* Serial Port Control */ #define CS35L32_CLASSD_CTL 0x10 /* Class D Amp CTL */ #define CS35L32_PROTECT_CTL 0x11 /* Protection Release CTL */ #define CS35L32_INT_MASK_1 0x12 /* Interrupt Mask 1 */ #define CS35L32_INT_MASK_2 0x13 /* Interrupt Mask 2 */ #define CS35L32_INT_MASK_3 0x14 /* Interrupt Mask 3 */ #define CS35L32_INT_STATUS_1 0x15 /* Interrupt Status 1 [RO] */ #define CS35L32_INT_STATUS_2 0x16 /* Interrupt Status 2 [RO] */ #define CS35L32_INT_STATUS_3 0x17 /* Interrupt Status 3 [RO] */ #define CS35L32_LED_STATUS 0x18 /* LED Lighting Status [RO] */ #define CS35L32_FLASH_MODE 0x19 /* LED Flash Mode Current */ #define CS35L32_MOVIE_MODE 0x1A /* LED Movie Mode Current */ #define CS35L32_FLASH_TIMER 0x1B /* LED Flash Timer */ #define CS35L32_FLASH_INHIBIT 0x1C /* LED Flash Inhibit Current */ #define CS35L32_MAX_REGISTER 0x1C #define CS35L32_MCLK_DIV2 0x01 #define CS35L32_MCLK_RATIO 0x01 #define CS35L32_MCLKDIS 0x80 #define CS35L32_PDN_ALL 0x01 #define CS35L32_PDN_AMP 0x80 #define CS35L32_PDN_BOOST 0x04 #define CS35L32_PDN_IMON 0x40 #define CS35L32_PDN_VMON 0x80 #define CS35L32_PDN_VPMON 0x20 #define CS35L32_PDN_ADSP 0x08 #define CS35L32_MCLK_DIV2_MASK 0x40 #define CS35L32_MCLK_RATIO_MASK 0x01 #define CS35L32_MCLK_MASK 0x41 #define CS35L32_ADSP_MASTER_MASK 0x40 #define CS35L32_BOOST_MASK 0x03 #define CS35L32_GAIN_MGR_MASK 0x08 #define CS35L32_ADSP_SHARE_MASK 0x08 #define CS35L32_ADSP_DATACFG_MASK 0x30 #define CS35L32_SDOUT_3ST 0x08 #define CS35L32_BATT_REC_MASK 0x0E #define CS35L32_BATT_THRESH_MASK 0x30 #define CS35L32_RATES (SNDRV_PCM_RATE_48000) #define CS35L32_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | \ SNDRV_PCM_FMTBIT_S24_LE | \ SNDRV_PCM_FMTBIT_S32_LE) #endif f542c5414e54bf1a'>soc/codecs/tlv320aic26.h
diff options
context:
space:
mode:
authorIago Abal <mail@iagoabal.eu>2017-01-11 14:00:21 +0100
committerVinod Koul <vinod.koul@intel.com>2017-01-25 15:35:11 +0530
commit91539eb1fda2d530d3b268eef542c5414e54bf1a (patch)
tree960f5ca6342ad20837aff18aad6e8ecd7da32fd6 /sound/soc/codecs/tlv320aic26.h
parent6610d0edf6dc7ee97e46ab3a538a565c79d26199 (diff)
dmaengine: pl330: fix double lock
The static bug finder EBA (http://www.iagoabal.eu/eba/) reported the following double-lock bug: Double lock: 1. spin_lock_irqsave(pch->lock, flags) at pl330_free_chan_resources:2236; 2. call to function `pl330_release_channel' immediately after; 3. call to function `dma_pl330_rqcb' in line 1753; 4. spin_lock_irqsave(pch->lock, flags) at dma_pl330_rqcb:1505. I have fixed it as suggested by Marek Szyprowski. First, I have replaced `pch->lock' with `pl330->lock' in functions `pl330_alloc_chan_resources' and `pl330_free_chan_resources'. This avoids the double-lock by acquiring a different lock than `dma_pl330_rqcb'. NOTE that, as a result, `pl330_free_chan_resources' executes `list_splice_tail_init' on `pch->work_list' under lock `pl330->lock', whereas in the rest of the code `pch->work_list' is protected by `pch->lock'. I don't know if this may cause race conditions. Similarly `pch->cyclic' is written by `pl330_alloc_chan_resources' under `pl330->lock' but read by `pl330_tx_submit' under `pch->lock'. Second, I have removed locking from `pl330_request_channel' and `pl330_release_channel' functions. Function `pl330_request_channel' is only called from `pl330_alloc_chan_resources', so the lock is already held. Function `pl330_release_channel' is called from `pl330_free_chan_resources', which already holds the lock, and from `pl330_del'. Function `pl330_del' is called in an error path of `pl330_probe' and at the end of `pl330_remove', but I assume that there cannot be concurrent accesses to the protected data at those points. Signed-off-by: Iago Abal <mail@iagoabal.eu> Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'sound/soc/codecs/tlv320aic26.h')