/* * L3 code * * Copyright (C) 2008, Christian Pellegrin * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2 as * published by the Free Software Foundation. * * * based on: * * L3 bus algorithm module. * * Copyright (C) 2001 Russell King, All Rights Reserved. * * */ #include #include #include #include #include #include /* * Send one byte of data to the chip. Data is latched into the chip on * the rising edge of the clock. */ static void sendbyte(struct l3_pins *adap, unsigned int byte) { int i; for (i = 0; i < 8; i++) { adap->setclk(adap, 0); udelay(adap->data_hold); adap->setdat(adap, byte & 1); udelay(adap->data_setup); adap->setclk(adap, 1); udelay(adap->clock_high); byte >>= 1; } } /* * Send a set of bytes to the chip. We need to pulse the MODE line * between each byte, but never at the start nor at the end of the * transfer. */ static void sendbytes(struct l3_pins *adap, const u8 *buf, int len) { int i; for (i = 0; i < len; i++) { if (i) { udelay(adap->mode_hold); adap->setmode(adap, 0); udelay(adap->mode); } adap->setmode(adap, 1); udelay(adap->mode_setup); sendbyte(adap, buf[i]); } } int l3_write(struct l3_pins *adap, u8 addr, u8 *data, int len) { adap->setclk(adap, 1); adap->setdat(adap, 1); adap->setmode(adap, 1); udelay(adap->mode); adap->setmode(adap, 0); udelay(adap->mode_setup); sendbyte(adap, addr); udelay(adap->mode_hold); sendbytes(adap, data, len); adap->setclk(adap, 1); adap->setdat(adap, 1); adap->setmode(adap, 0); return len; } EXPORT_SYMBOL_GPL(l3_write); static void l3_set_clk(struct l3_pins *adap, int val) { gpio_set_value(adap->gpio_clk, val); } static void l3_set_data(struct l3_pins *adap, int val) { gpio_set_value(adap->gpio_data, val); } static void l3_set_mode(struct l3_pins *adap, int val) { gpio_set_value(adap->gpio_mode, val); } int l3_set_gpio_ops(struct device *dev, struct l3_pins *adap) { int ret; if (!adap->use_gpios) return -EINVAL; ret = devm_gpio_request_one(dev, adap->gpio_data, GPIOF_OUT_INIT_LOW, "l3_data"); if (ret < 0) return ret; adap->setdat = l3_set_data; ret = devm_gpio_request_one(dev, adap->gpio_clk, GPIOF_OUT_INIT_LOW, "l3_clk"); if (ret < 0) return ret; adap->setclk = l3_set_clk; ret = devm_gpio_request_one(dev, adap->gpio_mode, GPIOF_OUT_INIT_LOW, "l3_mode"); if (ret < 0) return ret; adap->setmode = l3_set_mode; return 0; } EXPORT_SYMBOL_GPL(l3_set_gpio_ops); MODULE_DESCRIPTION("L3 bit-banging driver"); MODULE_AUTHOR("Christian Pellegrin "); MODULE_LICENSE("GPL"); /net-next.git/commit/include?id=966d2b04e070bc040319aaebfec09e0144dc3341'>include/rdma/ib_addr.h
diff options
context:
space:
mode:
authorDouglas Miller <dougmill@linux.vnet.ibm.com>2017-01-28 06:42:20 -0600
committerTejun Heo <tj@kernel.org>2017-01-28 07:49:42 -0500
commit966d2b04e070bc040319aaebfec09e0144dc3341 (patch)
tree4b96156e3d1dd4dfd6039b7c219c9dc4616da52d /include/rdma/ib_addr.h
parent1b1bc42c1692e9b62756323c675a44cb1a1f9dbd (diff)
percpu-refcount: fix reference leak during percpu-atomic transition
percpu_ref_tryget() and percpu_ref_tryget_live() should return "true" IFF they acquire a reference. But the return value from atomic_long_inc_not_zero() is a long and may have high bits set, e.g. PERCPU_COUNT_BIAS, and the return value of the tryget routines is bool so the reference may actually be acquired but the routines return "false" which results in a reference leak since the caller assumes it does not need to do a corresponding percpu_ref_put(). This was seen when performing CPU hotplug during I/O, as hangs in blk_mq_freeze_queue_wait where percpu_ref_kill (blk_mq_freeze_queue_start) raced with percpu_ref_tryget (blk_mq_timeout_work). Sample stack trace: __switch_to+0x2c0/0x450 __schedule+0x2f8/0x970 schedule+0x48/0xc0 blk_mq_freeze_queue_wait+0x94/0x120 blk_mq_queue_reinit_work+0xb8/0x180 blk_mq_queue_reinit_prepare+0x84/0xa0 cpuhp_invoke_callback+0x17c/0x600 cpuhp_up_callbacks+0x58/0x150 _cpu_up+0xf0/0x1c0 do_cpu_up+0x120/0x150 cpu_subsys_online+0x64/0xe0 device_online+0xb4/0x120 online_store+0xb4/0xc0 dev_attr_store+0x68/0xa0 sysfs_kf_write+0x80/0xb0 kernfs_fop_write+0x17c/0x250 __vfs_write+0x6c/0x1e0 vfs_write+0xd0/0x270 SyS_write+0x6c/0x110 system_call+0x38/0xe0 Examination of the queue showed a single reference (no PERCPU_COUNT_BIAS, and __PERCPU_REF_DEAD, __PERCPU_REF_ATOMIC set) and no requests. However, conditions at the time of the race are count of PERCPU_COUNT_BIAS + 0 and __PERCPU_REF_DEAD and __PERCPU_REF_ATOMIC set. The fix is to make the tryget routines use an actual boolean internally instead of the atomic long result truncated to a int. Fixes: e625305b3907 percpu-refcount: make percpu_ref based on longs instead of ints Link: https://bugzilla.kernel.org/show_bug.cgi?id=190751 Signed-off-by: Douglas Miller <dougmill@linux.vnet.ibm.com> Reviewed-by: Jens Axboe <axboe@fb.com> Signed-off-by: Tejun Heo <tj@kernel.org> Fixes: e625305b3907 ("percpu-refcount: make percpu_ref based on longs instead of ints") Cc: stable@vger.kernel.org # v3.18+
Diffstat (limited to 'include/rdma/ib_addr.h')