/* * Load Analog Devices SigmaStudio firmware files * * Copyright 2009-2011 Analog Devices Inc. * * Licensed under the GPL-2 or later. */ #include #include #include #include #include #include "sigmadsp.h" static int sigmadsp_write_i2c(void *control_data, unsigned int addr, const uint8_t data[], size_t len) { uint8_t *buf; int ret; buf = kzalloc(2 + len, GFP_KERNEL | GFP_DMA); if (!buf) return -ENOMEM; put_unaligned_be16(addr, buf); memcpy(buf + 2, data, len); ret = i2c_master_send(control_data, buf, len + 2); kfree(buf); if (ret < 0) return ret; return 0; } static int sigmadsp_read_i2c(void *control_data, unsigned int addr, uint8_t data[], size_t len) { struct i2c_client *client = control_data; struct i2c_msg msgs[2]; uint8_t buf[2]; int ret; put_unaligned_be16(addr, buf); msgs[0].addr = client->addr; msgs[0].len = sizeof(buf); msgs[0].buf = buf; msgs[0].flags = 0; msgs[1].addr = client->addr; msgs[1].len = len; msgs[1].buf = data; msgs[1].flags = I2C_M_RD; ret = i2c_transfer(client->adapter, msgs, ARRAY_SIZE(msgs)); if (ret < 0) return ret; else if (ret != ARRAY_SIZE(msgs)) return -EIO; return 0; } /** * devm_sigmadsp_init_i2c() - Initialize SigmaDSP instance * @client: The parent I2C device * @ops: The sigmadsp_ops to use for this instance * @firmware_name: Name of the firmware file to load * * Allocates a SigmaDSP instance and loads the specified firmware file. * * Returns a pointer to a struct sigmadsp on success, or a PTR_ERR() on error. */ struct sigmadsp *devm_sigmadsp_init_i2c(struct i2c_client *client, const struct sigmadsp_ops *ops, const char *firmware_name) { struct sigmadsp *sigmadsp; sigmadsp = devm_sigmadsp_init(&client->dev, ops, firmware_name); if (IS_ERR(sigmadsp)) return sigmadsp; sigmadsp->control_data = client; sigmadsp->write = sigmadsp_write_i2c; sigmadsp->read = sigmadsp_read_i2c; return sigmadsp; } EXPORT_SYMBOL_GPL(devm_sigmadsp_init_i2c); MODULE_AUTHOR("Lars-Peter Clausen "); MODULE_DESCRIPTION("SigmaDSP I2C firmware loader"); MODULE_LICENSE("GPL"); a href='/cgit.cgi/linux/net-next.git/diff/sound/soc/kirkwood/kirkwood.h?h=nds-private-remove&id=09f2ba0b0b7c44ecea49cf69a708203b76ba5535'>diff
diff options
context:
space:
mode:
authorJisheng Zhang <jszhang@marvell.com>2016-11-10 17:21:29 +0800
committerMark Brown <broonie@kernel.org>2016-11-11 15:38:08 +0000
commit09f2ba0b0b7c44ecea49cf69a708203b76ba5535 (patch)
tree042df33ac99f77d8b86ac427431e267c33561c35 /sound/soc/kirkwood/kirkwood.h
parent1001354ca34179f3db924eb66672442a173147dc (diff)
regulator: gpio: properly check return value of of_get_named_gpio
The function of_get_named_gpio() could return -ENOENT, -EPROBE_DEFER -EINVAL and so on. Currently, for the optional property "enable-gpio", we only check -EPROBE_DEFER, this is not enough since there may be misconfigured "enable-gpio" in the DTB, of_get_named_gpio() will return -EINVAL in this case, we should return immediately here. And for the optional property "gpios", we didn't check the return value, the driver will continue to the point where gpio_request_array() is called, it doesn't make sense to continue if we got -EPROBE_DEFER or -EINVAL here. This patch tries to address these two issues by properly checking the return value of of_get_named_gpio. Signed-off-by: Jisheng Zhang <jszhang@marvell.com> Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/kirkwood/kirkwood.h')