/* * Load Analog Devices SigmaStudio firmware files * * Copyright 2009-2011 Analog Devices Inc. * * Licensed under the GPL-2 or later. */ #include #include #include #include "sigmadsp.h" static int sigmadsp_write_regmap(void *control_data, unsigned int addr, const uint8_t data[], size_t len) { return regmap_raw_write(control_data, addr, data, len); } static int sigmadsp_read_regmap(void *control_data, unsigned int addr, uint8_t data[], size_t len) { return regmap_raw_read(control_data, addr, data, len); } /** * devm_sigmadsp_init_i2c() - Initialize SigmaDSP instance * @dev: The parent device * @regmap: Regmap instance to use * @ops: The sigmadsp_ops to use for this instance * @firmware_name: Name of the firmware file to load * * Allocates a SigmaDSP instance and loads the specified firmware file. * * Returns a pointer to a struct sigmadsp on success, or a PTR_ERR() on error. */ struct sigmadsp *devm_sigmadsp_init_regmap(struct device *dev, struct regmap *regmap, const struct sigmadsp_ops *ops, const char *firmware_name) { struct sigmadsp *sigmadsp; sigmadsp = devm_sigmadsp_init(dev, ops, firmware_name); if (IS_ERR(sigmadsp)) return sigmadsp; sigmadsp->control_data = regmap; sigmadsp->write = sigmadsp_write_regmap; sigmadsp->read = sigmadsp_read_regmap; return sigmadsp; } EXPORT_SYMBOL_GPL(devm_sigmadsp_init_regmap); MODULE_AUTHOR("Lars-Peter Clausen "); MODULE_DESCRIPTION("SigmaDSP regmap firmware loader"); MODULE_LICENSE("GPL"); /refs/?id=91539eb1fda2d530d3b268eef542c5414e54bf1a'>refslogtreecommitdiff
path: root/net/xfrm/Makefile
diff options
context:
space:
mode:
authorIago Abal <mail@iagoabal.eu>2017-01-11 14:00:21 +0100
committerVinod Koul <vinod.koul@intel.com>2017-01-25 15:35:11 +0530
commit91539eb1fda2d530d3b268eef542c5414e54bf1a (patch)
tree960f5ca6342ad20837aff18aad6e8ecd7da32fd6 /net/xfrm/Makefile
parent6610d0edf6dc7ee97e46ab3a538a565c79d26199 (diff)
dmaengine: pl330: fix double lock
The static bug finder EBA (http://www.iagoabal.eu/eba/) reported the following double-lock bug: Double lock: 1. spin_lock_irqsave(pch->lock, flags) at pl330_free_chan_resources:2236; 2. call to function `pl330_release_channel' immediately after; 3. call to function `dma_pl330_rqcb' in line 1753; 4. spin_lock_irqsave(pch->lock, flags) at dma_pl330_rqcb:1505. I have fixed it as suggested by Marek Szyprowski. First, I have replaced `pch->lock' with `pl330->lock' in functions `pl330_alloc_chan_resources' and `pl330_free_chan_resources'. This avoids the double-lock by acquiring a different lock than `dma_pl330_rqcb'. NOTE that, as a result, `pl330_free_chan_resources' executes `list_splice_tail_init' on `pch->work_list' under lock `pl330->lock', whereas in the rest of the code `pch->work_list' is protected by `pch->lock'. I don't know if this may cause race conditions. Similarly `pch->cyclic' is written by `pl330_alloc_chan_resources' under `pl330->lock' but read by `pl330_tx_submit' under `pch->lock'. Second, I have removed locking from `pl330_request_channel' and `pl330_release_channel' functions. Function `pl330_request_channel' is only called from `pl330_alloc_chan_resources', so the lock is already held. Function `pl330_release_channel' is called from `pl330_free_chan_resources', which already holds the lock, and from `pl330_del'. Function `pl330_del' is called in an error path of `pl330_probe' and at the end of `pl330_remove', but I assume that there cannot be concurrent accesses to the protected data at those points. Signed-off-by: Iago Abal <mail@iagoabal.eu> Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'net/xfrm/Makefile')