/* * Copyright (C) 2014 Marvell * * Thomas Petazzoni * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License as * published by the Free Software Foundation; either version 2 of the * License, or (at your option) any later version. */ #include #include #include #include #include #include #include #include #include "../codecs/cs42l51.h" static int a370db_hw_params(struct snd_pcm_substream *substream, struct snd_pcm_hw_params *params) { struct snd_soc_pcm_runtime *rtd = substream->private_data; struct snd_soc_dai *codec_dai = rtd->codec_dai; unsigned int freq; switch (params_rate(params)) { default: case 44100: freq = 11289600; break; case 48000: freq = 12288000; break; case 96000: freq = 24576000; break; } return snd_soc_dai_set_sysclk(codec_dai, 0, freq, SND_SOC_CLOCK_IN); } static const struct snd_soc_ops a370db_ops = { .hw_params = a370db_hw_params, }; static const struct snd_soc_dapm_widget a370db_dapm_widgets[] = { SND_SOC_DAPM_HP("Out Jack", NULL), SND_SOC_DAPM_LINE("In Jack", NULL), }; static const struct snd_soc_dapm_route a370db_route[] = { { "Out Jack", NULL, "HPL" }, { "Out Jack", NULL, "HPR" }, { "AIN1L", NULL, "In Jack" }, { "AIN1L", NULL, "In Jack" }, }; static struct snd_soc_dai_link a370db_dai[] = { { .name = "CS42L51", .stream_name = "analog", .cpu_dai_name = "i2s", .codec_dai_name = "cs42l51-hifi", .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_CBS_CFS, .ops = &a370db_ops, }, { .name = "S/PDIF out", .stream_name = "spdif-out", .cpu_dai_name = "spdif", .codec_dai_name = "dit-hifi", .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_CBS_CFS, }, { .name = "S/PDIF in", .stream_name = "spdif-in", .cpu_dai_name = "spdif", .codec_dai_name = "dir-hifi", .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_CBS_CFS, }, }; static struct snd_soc_card a370db = { .name = "a370db", .owner = THIS_MODULE, .dai_link = a370db_dai, .num_links = ARRAY_SIZE(a370db_dai), .dapm_widgets = a370db_dapm_widgets, .num_dapm_widgets = ARRAY_SIZE(a370db_dapm_widgets), .dapm_routes = a370db_route, .num_dapm_routes = ARRAY_SIZE(a370db_route), }; static int a370db_probe(struct platform_device *pdev) { struct snd_soc_card *card = &a370db; card->dev = &pdev->dev; a370db_dai[0].cpu_of_node = of_parse_phandle(pdev->dev.of_node, "marvell,audio-controller", 0); a370db_dai[0].platform_of_node = a370db_dai[0].cpu_of_node; a370db_dai[0].codec_of_node = of_parse_phandle(pdev->dev.of_node, "marvell,audio-codec", 0); a370db_dai[1].cpu_of_node = a370db_dai[0].cpu_of_node; a370db_dai[1].platform_of_node = a370db_dai[0].cpu_of_node; a370db_dai[1].codec_of_node = of_parse_phandle(pdev->dev.of_node, "marvell,audio-codec", 1); a370db_dai[2].cpu_of_node = a370db_dai[0].cpu_of_node; a370db_dai[2].platform_of_node = a370db_dai[0].cpu_of_node; a370db_dai[2].codec_of_node = of_parse_phandle(pdev->dev.of_node, "marvell,audio-codec", 2); return devm_snd_soc_register_card(card->dev, card); } static const struct of_device_id a370db_dt_ids[] = { { .compatible = "marvell,a370db-audio" }, { }, }; MODULE_DEVICE_TABLE(of, a370db_dt_ids); static struct platform_driver a370db_driver = { .driver = { .name = "a370db-audio", .of_match_table = of_match_ptr(a370db_dt_ids), }, .probe = a370db_probe, }; module_platform_driver(a370db_driver); MODULE_AUTHOR("Thomas Petazzoni "); MODULE_DESCRIPTION("ALSA SoC a370db audio client"); MODULE_LICENSE("GPL"); MODULE_ALIAS("platform:a370db-audio"); class='label'>context:space:mode:
authorIago Abal <mail@iagoabal.eu>2017-01-11 14:00:21 +0100
committerVinod Koul <vinod.koul@intel.com>2017-01-25 15:35:11 +0530
commit91539eb1fda2d530d3b268eef542c5414e54bf1a (patch)
tree960f5ca6342ad20837aff18aad6e8ecd7da32fd6 /sound/soc/codecs/wm9090.h
parent6610d0edf6dc7ee97e46ab3a538a565c79d26199 (diff)
dmaengine: pl330: fix double lock
The static bug finder EBA (http://www.iagoabal.eu/eba/) reported the following double-lock bug: Double lock: 1. spin_lock_irqsave(pch->lock, flags) at pl330_free_chan_resources:2236; 2. call to function `pl330_release_channel' immediately after; 3. call to function `dma_pl330_rqcb' in line 1753; 4. spin_lock_irqsave(pch->lock, flags) at dma_pl330_rqcb:1505. I have fixed it as suggested by Marek Szyprowski. First, I have replaced `pch->lock' with `pl330->lock' in functions `pl330_alloc_chan_resources' and `pl330_free_chan_resources'. This avoids the double-lock by acquiring a different lock than `dma_pl330_rqcb'. NOTE that, as a result, `pl330_free_chan_resources' executes `list_splice_tail_init' on `pch->work_list' under lock `pl330->lock', whereas in the rest of the code `pch->work_list' is protected by `pch->lock'. I don't know if this may cause race conditions. Similarly `pch->cyclic' is written by `pl330_alloc_chan_resources' under `pl330->lock' but read by `pl330_tx_submit' under `pch->lock'. Second, I have removed locking from `pl330_request_channel' and `pl330_release_channel' functions. Function `pl330_request_channel' is only called from `pl330_alloc_chan_resources', so the lock is already held. Function `pl330_release_channel' is called from `pl330_free_chan_resources', which already holds the lock, and from `pl330_del'. Function `pl330_del' is called in an error path of `pl330_probe' and at the end of `pl330_remove', but I assume that there cannot be concurrent accesses to the protected data at those points. Signed-off-by: Iago Abal <mail@iagoabal.eu> Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'sound/soc/codecs/wm9090.h')