/* * Copyright (c) 2010 Nuvoton technology corporation. * * Wan ZongShun * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation;version 2 of the License. * */ #ifndef _NUC900_AUDIO_H #define _NUC900_AUDIO_H #include /* Audio Control Registers */ #define ACTL_CON 0x00 #define ACTL_RESET 0x04 #define ACTL_RDSTB 0x08 #define ACTL_RDST_LENGTH 0x0C #define ACTL_RDSTC 0x10 #define ACTL_RSR 0x14 #define ACTL_PDSTB 0x18 #define ACTL_PDST_LENGTH 0x1C #define ACTL_PDSTC 0x20 #define ACTL_PSR 0x24 #define ACTL_IISCON 0x28 #define ACTL_ACCON 0x2C #define ACTL_ACOS0 0x30 #define ACTL_ACOS1 0x34 #define ACTL_ACOS2 0x38 #define ACTL_ACIS0 0x3C #define ACTL_ACIS1 0x40 #define ACTL_ACIS2 0x44 #define ACTL_COUNTER 0x48 /* bit definition of REG_ACTL_CON register */ #define R_DMA_IRQ 0x1000 #define T_DMA_IRQ 0x0800 #define IIS_AC_PIN_SEL 0x0100 #define FIFO_TH 0x0080 #define ADC_EN 0x0010 #define M80_EN 0x0008 #define ACLINK_EN 0x0004 #define IIS_EN 0x0002 /* bit definition of REG_ACTL_RESET register */ #define W5691_PLAY 0x20000 #define ACTL_RESET_BIT 0x10000 #define RECORD_RIGHT_CHNNEL 0x08000 #define RECORD_LEFT_CHNNEL 0x04000 #define PLAY_RIGHT_CHNNEL 0x02000 #define PLAY_LEFT_CHNNEL 0x01000 #define DAC_PLAY 0x00800 #define ADC_RECORD 0x00400 #define M80_PLAY 0x00200 #define AC_RECORD 0x00100 #define AC_PLAY 0x00080 #define IIS_RECORD 0x00040 #define IIS_PLAY 0x00020 #define DAC_RESET 0x00010 #define ADC_RESET 0x00008 #define M80_RESET 0x00004 #define AC_RESET 0x00002 #define IIS_RESET 0x00001 /* bit definition of REG_ACTL_ACCON register */ #define AC_BCLK_PU_EN 0x20 #define AC_R_FINISH 0x10 #define AC_W_FINISH 0x08 #define AC_W_RES 0x04 #define AC_C_RES 0x02 /* bit definition of ACTL_RSR register */ #define R_FIFO_EMPTY 0x04 #define R_DMA_END_IRQ 0x02 #define R_DMA_MIDDLE_IRQ 0x01 /* bit definition of ACTL_PSR register */ #define P_FIFO_EMPTY 0x04 #define P_DMA_END_IRQ 0x02 #define P_DMA_MIDDLE_IRQ 0x01 /* bit definition of ACTL_ACOS0 register */ #define SLOT1_VALID 0x01 #define SLOT2_VALID 0x02 #define SLOT3_VALID 0x04 #define SLOT4_VALID 0x08 #define VALID_FRAME 0x10 /* bit definition of ACTL_ACOS1 register */ #define R_WB 0x80 #define CODEC_READY 0x10 #define RESET_PRSR 0x00 #define AUDIO_WRITE(addr, val) __raw_writel(val, addr) #define AUDIO_READ(addr) __raw_readl(addr) struct nuc900_audio { void __iomem *mmio; spinlock_t lock; unsigned long irq_num; struct resource *res; struct clk *clk; struct device *dev; }; extern struct nuc900_audio *nuc900_ac97_data; #endif /*end _NUC900_AUDIO_H */ t?id=39cb2c9a316e77f6dfba96c543e55b6672d5a37e'>net/llc/llc_sap.c
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
commit39cb2c9a316e77f6dfba96c543e55b6672d5a37e (patch)
tree98fe974ee4e20121253de7f61fc8d01bdb3821c1 /net/llc/llc_sap.c
parent2c5d9555d6d937966d79d4c6529a5f7b9206e405 (diff)
drm/i915: Check for NULL i915_vma in intel_unpin_fb_obj()
I've seen this trigger twice now, where the i915_gem_object_to_ggtt() call in intel_unpin_fb_obj() returns NULL, resulting in an oops immediately afterwards as the (inlined) call to i915_vma_unpin_fence() tries to dereference it. It seems to be some race condition where the object is going away at shutdown time, since both times happened when shutting down the X server. The call chains were different: - VT ioctl(KDSETMODE, KD_TEXT): intel_cleanup_plane_fb+0x5b/0xa0 [i915] drm_atomic_helper_cleanup_planes+0x6f/0x90 [drm_kms_helper] intel_atomic_commit_tail+0x749/0xfe0 [i915] intel_atomic_commit+0x3cb/0x4f0 [i915] drm_atomic_commit+0x4b/0x50 [drm] restore_fbdev_mode+0x14c/0x2a0 [drm_kms_helper] drm_fb_helper_restore_fbdev_mode_unlocked+0x34/0x80 [drm_kms_helper] drm_fb_helper_set_par+0x2d/0x60 [drm_kms_helper] intel_fbdev_set_par+0x18/0x70 [i915] fb_set_var+0x236/0x460 fbcon_blank+0x30f/0x350 do_unblank_screen+0xd2/0x1a0 vt_ioctl+0x507/0x12a0 tty_ioctl+0x355/0xc30 do_vfs_ioctl+0xa3/0x5e0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x13/0x94 - i915 unpin_work workqueue: intel_unpin_work_fn+0x58/0x140 [i915] process_one_work+0x1f1/0x480 worker_thread+0x48/0x4d0 kthread+0x101/0x140 and this patch purely papers over the issue by adding a NULL pointer check and a WARN_ON_ONCE() to avoid the oops that would then generally make the machine unresponsive. Other callers of i915_gem_object_to_ggtt() seem to also check for the returned pointer being NULL and warn about it, so this clearly has happened before in other places. [ Reported it originally to the i915 developers on Jan 8, applying the ugly workaround on my own now after triggering the problem for the second time with no feedback. This is likely to be the same bug reported as https://bugs.freedesktop.org/show_bug.cgi?id=98829 https://bugs.freedesktop.org/show_bug.cgi?id=99134 which has a patch for the underlying problem, but it hasn't gotten to me, so I'm applying the workaround. ] Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'net/llc/llc_sap.c')