/* * linux/sound/soc/pxa/mmp-pcm.c * * Copyright (C) 2011 Marvell International Ltd. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * */ #include #include #include #include #include #include #include #include #include #include #include #include #include #include struct mmp_dma_data { int ssp_id; struct resource *dma_res; }; #define MMP_PCM_INFO (SNDRV_PCM_INFO_MMAP | \ SNDRV_PCM_INFO_MMAP_VALID | \ SNDRV_PCM_INFO_INTERLEAVED | \ SNDRV_PCM_INFO_PAUSE | \ SNDRV_PCM_INFO_RESUME | \ SNDRV_PCM_INFO_NO_PERIOD_WAKEUP) static struct snd_pcm_hardware mmp_pcm_hardware[] = { { .info = MMP_PCM_INFO, .period_bytes_min = 1024, .period_bytes_max = 2048, .periods_min = 2, .periods_max = 32, .buffer_bytes_max = 4096, .fifo_size = 32, }, { .info = MMP_PCM_INFO, .period_bytes_min = 1024, .period_bytes_max = 2048, .periods_min = 2, .periods_max = 32, .buffer_bytes_max = 4096, .fifo_size = 32, }, }; static int mmp_pcm_hw_params(struct snd_pcm_substream *substream, struct snd_pcm_hw_params *params) { struct dma_chan *chan = snd_dmaengine_pcm_get_chan(substream); struct dma_slave_config slave_config; int ret; ret = snd_dmaengine_pcm_prepare_slave_config(substream, params, &slave_config); if (ret) return ret; ret = dmaengine_slave_config(chan, &slave_config); if (ret) return ret; snd_pcm_set_runtime_buffer(substream, &substream->dma_buffer); return 0; } static bool filter(struct dma_chan *chan, void *param) { struct mmp_dma_data *dma_data = param; bool found = false; char *devname; devname = kasprintf(GFP_KERNEL, "%s.%d", dma_data->dma_res->name, dma_data->ssp_id); if ((strcmp(dev_name(chan->device->dev), devname) == 0) && (chan->chan_id == dma_data->dma_res->start)) { found = true; } kfree(devname); return found; } static int mmp_pcm_open(struct snd_pcm_substream *substream) { struct snd_soc_pcm_runtime *rtd = substream->private_data; struct platform_device *pdev = to_platform_device(rtd->platform->dev); struct snd_soc_dai *cpu_dai = rtd->cpu_dai; struct mmp_dma_data dma_data; struct resource *r; r = platform_get_resource(pdev, IORESOURCE_DMA, substream->stream); if (!r) return -EBUSY; snd_soc_set_runtime_hwparams(substream, &mmp_pcm_hardware[substream->stream]); dma_data.dma_res = r; dma_data.ssp_id = cpu_dai->id; return snd_dmaengine_pcm_open_request_chan(substream, filter, &dma_data); } static int mmp_pcm_mmap(struct snd_pcm_substream *substream, struct vm_area_struct *vma) { struct snd_pcm_runtime *runtime = substream->runtime; unsigned long off = vma->vm_pgoff; vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot); return remap_pfn_range(vma, vma->vm_start, __phys_to_pfn(runtime->dma_addr) + off, vma->vm_end - vma->vm_start, vma->vm_page_prot); } static struct snd_pcm_ops mmp_pcm_ops = { .open = mmp_pcm_open, .close = snd_dmaengine_pcm_close_release_chan, .ioctl = snd_pcm_lib_ioctl, .hw_params = mmp_pcm_hw_params, .trigger = snd_dmaengine_pcm_trigger, .pointer = snd_dmaengine_pcm_pointer, .mmap = mmp_pcm_mmap, }; static void mmp_pcm_free_dma_buffers(struct snd_pcm *pcm) { struct snd_pcm_substream *substream; struct snd_dma_buffer *buf; int stream; struct gen_pool *gpool; gpool = sram_get_gpool("asram"); if (!gpool) return; for (stream = 0; stream < 2; stream++) { size_t size = mmp_pcm_hardware[stream].buffer_bytes_max; substream = pcm->streams[stream].substream; if (!substream) continue; buf = &substream->dma_buffer; if (!buf->area) continue; gen_pool_free(gpool, (unsigned long)buf->area, size); buf->area = NULL; } return; } static int mmp_pcm_preallocate_dma_buffer(struct snd_pcm_substream *substream, int stream) { struct snd_dma_buffer *buf = &substream->dma_buffer; size_t size = mmp_pcm_hardware[stream].buffer_bytes_max; struct gen_pool *gpool; buf->dev.type = SNDRV_DMA_TYPE_DEV; buf->dev.dev = substream->pcm->card->dev; buf->private_data = NULL; gpool = sram_get_gpool("asram"); if (!gpool) return -ENOMEM; buf->area = gen_pool_dma_alloc(gpool, size, &buf->addr); if (!buf->area) return -ENOMEM; buf->bytes = size; return 0; } static int mmp_pcm_new(struct snd_soc_pcm_runtime *rtd) { struct snd_pcm_substream *substream; struct snd_pcm *pcm = rtd->pcm; int ret = 0, stream; for (stream = 0; stream < 2; stream++) { substream = pcm->streams[stream].substream; ret = mmp_pcm_preallocate_dma_buffer(substream, stream); if (ret) goto err; } return 0; err: mmp_pcm_free_dma_buffers(pcm); return ret; } static struct snd_soc_platform_driver mmp_soc_platform = { .ops = &mmp_pcm_ops, .pcm_new = mmp_pcm_new, .pcm_free = mmp_pcm_free_dma_buffers, }; static int mmp_pcm_probe(struct platform_device *pdev) { struct mmp_audio_platdata *pdata = pdev->dev.platform_data; if (pdata) { mmp_pcm_hardware[SNDRV_PCM_STREAM_PLAYBACK].buffer_bytes_max = pdata->buffer_max_playback; mmp_pcm_hardware[SNDRV_PCM_STREAM_PLAYBACK].period_bytes_max = pdata->period_max_playback; mmp_pcm_hardware[SNDRV_PCM_STREAM_CAPTURE].buffer_bytes_max = pdata->buffer_max_capture; mmp_pcm_hardware[SNDRV_PCM_STREAM_CAPTURE].period_bytes_max = pdata->period_max_capture; } return devm_snd_soc_register_platform(&pdev->dev, &mmp_soc_platform); } static struct platform_driver mmp_pcm_driver = { .driver = { .name = "mmp-pcm-audio", }, .probe = mmp_pcm_probe, }; module_platform_driver(mmp_pcm_driver); MODULE_AUTHOR("Leo Yan "); MODULE_DESCRIPTION("MMP Soc Audio DMA module"); MODULE_LICENSE("GPL"); MODULE_ALIAS("platform:mmp-pcm-audio"); ux/net-next.git/diff/sound/oss/waveartist.h?h=nds-private-remove&id=39cb2c9a316e77f6dfba96c543e55b6672d5a37e&id2=2c5d9555d6d937966d79d4c6529a5f7b9206e405'>diff)
drm/i915: Check for NULL i915_vma in intel_unpin_fb_obj()
I've seen this trigger twice now, where the i915_gem_object_to_ggtt() call in intel_unpin_fb_obj() returns NULL, resulting in an oops immediately afterwards as the (inlined) call to i915_vma_unpin_fence() tries to dereference it. It seems to be some race condition where the object is going away at shutdown time, since both times happened when shutting down the X server. The call chains were different: - VT ioctl(KDSETMODE, KD_TEXT): intel_cleanup_plane_fb+0x5b/0xa0 [i915] drm_atomic_helper_cleanup_planes+0x6f/0x90 [drm_kms_helper] intel_atomic_commit_tail+0x749/0xfe0 [i915] intel_atomic_commit+0x3cb/0x4f0 [i915] drm_atomic_commit+0x4b/0x50 [drm] restore_fbdev_mode+0x14c/0x2a0 [drm_kms_helper] drm_fb_helper_restore_fbdev_mode_unlocked+0x34/0x80 [drm_kms_helper] drm_fb_helper_set_par+0x2d/0x60 [drm_kms_helper] intel_fbdev_set_par+0x18/0x70 [i915] fb_set_var+0x236/0x460 fbcon_blank+0x30f/0x350 do_unblank_screen+0xd2/0x1a0 vt_ioctl+0x507/0x12a0 tty_ioctl+0x355/0xc30 do_vfs_ioctl+0xa3/0x5e0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x13/0x94 - i915 unpin_work workqueue: intel_unpin_work_fn+0x58/0x140 [i915] process_one_work+0x1f1/0x480 worker_thread+0x48/0x4d0 kthread+0x101/0x140 and this patch purely papers over the issue by adding a NULL pointer check and a WARN_ON_ONCE() to avoid the oops that would then generally make the machine unresponsive. Other callers of i915_gem_object_to_ggtt() seem to also check for the returned pointer being NULL and warn about it, so this clearly has happened before in other places. [ Reported it originally to the i915 developers on Jan 8, applying the ugly workaround on my own now after triggering the problem for the second time with no feedback. This is likely to be the same bug reported as https://bugs.freedesktop.org/show_bug.cgi?id=98829 https://bugs.freedesktop.org/show_bug.cgi?id=99134 which has a patch for the underlying problem, but it hasn't gotten to me, so I'm applying the workaround. ] Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'sound/oss/waveartist.h')