/* * Copyright (c) 2003 Simtec Electronics * http://www.simtec.co.uk/products/SWLINUX/ * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2 as * published by the Free Software Foundation. * * S3C2410 IIS register definition */ #ifndef __SAMSUNG_REGS_IIS_H__ #define __SAMSUNG_REGS_IIS_H__ #define S3C2410_IISCON (0x00) #define S3C2410_IISCON_LRINDEX (1 << 8) #define S3C2410_IISCON_TXFIFORDY (1 << 7) #define S3C2410_IISCON_RXFIFORDY (1 << 6) #define S3C2410_IISCON_TXDMAEN (1 << 5) #define S3C2410_IISCON_RXDMAEN (1 << 4) #define S3C2410_IISCON_TXIDLE (1 << 3) #define S3C2410_IISCON_RXIDLE (1 << 2) #define S3C2410_IISCON_PSCEN (1 << 1) #define S3C2410_IISCON_IISEN (1 << 0) #define S3C2410_IISMOD (0x04) #define S3C2440_IISMOD_MPLL (1 << 9) #define S3C2410_IISMOD_SLAVE (1 << 8) #define S3C2410_IISMOD_NOXFER (0 << 6) #define S3C2410_IISMOD_RXMODE (1 << 6) #define S3C2410_IISMOD_TXMODE (2 << 6) #define S3C2410_IISMOD_TXRXMODE (3 << 6) #define S3C2410_IISMOD_LR_LLOW (0 << 5) #define S3C2410_IISMOD_LR_RLOW (1 << 5) #define S3C2410_IISMOD_IIS (0 << 4) #define S3C2410_IISMOD_MSB (1 << 4) #define S3C2410_IISMOD_8BIT (0 << 3) #define S3C2410_IISMOD_16BIT (1 << 3) #define S3C2410_IISMOD_BITMASK (1 << 3) #define S3C2410_IISMOD_256FS (0 << 2) #define S3C2410_IISMOD_384FS (1 << 2) #define S3C2410_IISMOD_16FS (0 << 0) #define S3C2410_IISMOD_32FS (1 << 0) #define S3C2410_IISMOD_48FS (2 << 0) #define S3C2410_IISMOD_FS_MASK (3 << 0) #define S3C2410_IISPSR (0x08) #define S3C2410_IISPSR_INTMASK (31 << 5) #define S3C2410_IISPSR_INTSHIFT (5) #define S3C2410_IISPSR_EXTMASK (31 << 0) #define S3C2410_IISPSR_EXTSHFIT (0) #define S3C2410_IISFCON (0x0c) #define S3C2410_IISFCON_TXDMA (1 << 15) #define S3C2410_IISFCON_RXDMA (1 << 14) #define S3C2410_IISFCON_TXENABLE (1 << 13) #define S3C2410_IISFCON_RXENABLE (1 << 12) #define S3C2410_IISFCON_TXMASK (0x3f << 6) #define S3C2410_IISFCON_TXSHIFT (6) #define S3C2410_IISFCON_RXMASK (0x3f) #define S3C2410_IISFCON_RXSHIFT (0) #define S3C2410_IISFIFO (0x10) #endif /* __SAMSUNG_REGS_IIS_H__ */ >
path: root/sound/soc/pxa/z2.c
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
commit39cb2c9a316e77f6dfba96c543e55b6672d5a37e (patch)
tree98fe974ee4e20121253de7f61fc8d01bdb3821c1 /sound/soc/pxa/z2.c
parent2c5d9555d6d937966d79d4c6529a5f7b9206e405 (diff)
drm/i915: Check for NULL i915_vma in intel_unpin_fb_obj()
I've seen this trigger twice now, where the i915_gem_object_to_ggtt() call in intel_unpin_fb_obj() returns NULL, resulting in an oops immediately afterwards as the (inlined) call to i915_vma_unpin_fence() tries to dereference it. It seems to be some race condition where the object is going away at shutdown time, since both times happened when shutting down the X server. The call chains were different: - VT ioctl(KDSETMODE, KD_TEXT): intel_cleanup_plane_fb+0x5b/0xa0 [i915] drm_atomic_helper_cleanup_planes+0x6f/0x90 [drm_kms_helper] intel_atomic_commit_tail+0x749/0xfe0 [i915] intel_atomic_commit+0x3cb/0x4f0 [i915] drm_atomic_commit+0x4b/0x50 [drm] restore_fbdev_mode+0x14c/0x2a0 [drm_kms_helper] drm_fb_helper_restore_fbdev_mode_unlocked+0x34/0x80 [drm_kms_helper] drm_fb_helper_set_par+0x2d/0x60 [drm_kms_helper] intel_fbdev_set_par+0x18/0x70 [i915] fb_set_var+0x236/0x460 fbcon_blank+0x30f/0x350 do_unblank_screen+0xd2/0x1a0 vt_ioctl+0x507/0x12a0 tty_ioctl+0x355/0xc30 do_vfs_ioctl+0xa3/0x5e0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x13/0x94 - i915 unpin_work workqueue: intel_unpin_work_fn+0x58/0x140 [i915] process_one_work+0x1f1/0x480 worker_thread+0x48/0x4d0 kthread+0x101/0x140 and this patch purely papers over the issue by adding a NULL pointer check and a WARN_ON_ONCE() to avoid the oops that would then generally make the machine unresponsive. Other callers of i915_gem_object_to_ggtt() seem to also check for the returned pointer being NULL and warn about it, so this clearly has happened before in other places. [ Reported it originally to the i915 developers on Jan 8, applying the ugly workaround on my own now after triggering the problem for the second time with no feedback. This is likely to be the same bug reported as https://bugs.freedesktop.org/show_bug.cgi?id=98829 https://bugs.freedesktop.org/show_bug.cgi?id=99134 which has a patch for the underlying problem, but it hasn't gotten to me, so I'm applying the workaround. ] Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'sound/soc/pxa/z2.c')