#include #include #include #include "list.h" #include "nosy-dump.h" #define CSR_FCP_COMMAND 0xfffff0000b00ull #define CSR_FCP_RESPONSE 0xfffff0000d00ull static const char * const ctype_names[] = { [0x0] = "control", [0x8] = "not implemented", [0x1] = "status", [0x9] = "accepted", [0x2] = "specific inquiry", [0xa] = "rejected", [0x3] = "notify", [0xb] = "in transition", [0x4] = "general inquiry", [0xc] = "stable", [0x5] = "(reserved 0x05)", [0xd] = "changed", [0x6] = "(reserved 0x06)", [0xe] = "(reserved 0x0e)", [0x7] = "(reserved 0x07)", [0xf] = "interim", }; static const char * const subunit_type_names[] = { [0x00] = "monitor", [0x10] = "(reserved 0x10)", [0x01] = "audio", [0x11] = "(reserved 0x11)", [0x02] = "printer", [0x12] = "(reserved 0x12)", [0x03] = "disc", [0x13] = "(reserved 0x13)", [0x04] = "tape recorder/player",[0x14] = "(reserved 0x14)", [0x05] = "tuner", [0x15] = "(reserved 0x15)", [0x06] = "ca", [0x16] = "(reserved 0x16)", [0x07] = "camera", [0x17] = "(reserved 0x17)", [0x08] = "(reserved 0x08)", [0x18] = "(reserved 0x18)", [0x09] = "panel", [0x19] = "(reserved 0x19)", [0x0a] = "bulletin board", [0x1a] = "(reserved 0x1a)", [0x0b] = "camera storage", [0x1b] = "(reserved 0x1b)", [0x0c] = "(reserved 0x0c)", [0x1c] = "vendor unique", [0x0d] = "(reserved 0x0d)", [0x1d] = "all subunit types", [0x0e] = "(reserved 0x0e)", [0x1e] = "subunit_type extended to next byte", [0x0f] = "(reserved 0x0f)", [0x1f] = "unit", }; struct avc_enum { int value; const char *name; }; struct avc_field { const char *name; /* Short name for field. */ int offset; /* Location of field, specified in bits; */ /* negative means from end of packet. */ int width; /* Width of field, 0 means use data_length. */ struct avc_enum *names; }; struct avc_opcode_info { const char *name; struct avc_field fields[8]; }; struct avc_enum power_field_names[] = { { 0x70, "on" }, { 0x60, "off" }, { } }; static const struct avc_opcode_info opcode_info[256] = { /* TA Document 1999026 */ /* AV/C Digital Interface Command Set General Specification 4.0 */ [0xb2] = { "power", { { "state", 0, 8, power_field_names } } }, [0x30] = { "unit info", { { "foo", 0, 8 }, { "unit_type", 8, 5 }, { "unit", 13, 3 }, { "company id", 16, 24 }, } }, [0x31] = { "subunit info" }, [0x01] = { "reserve" }, [0xb0] = { "version" }, [0x00] = { "vendor dependent" }, [0x02] = { "plug info" }, [0x12] = { "channel usage" }, [0x24] = { "connect" }, [0x20] = { "connect av" }, [0x22] = { "connections" }, [0x11] = { "digital input" }, [0x10] = { "digital output" }, [0x25] = { "disconnect" }, [0x21] = { "disconnect av" }, [0x19] = { "input plug signal format" }, [0x18] = { "output plug signal format" }, [0x1f] = { "general bus setup" }, /* TA Document 1999025 */ /* AV/C Descriptor Mechanism Specification Version 1.0 */ [0x0c] = { "create descriptor" }, [0x08] = { "open descriptor" }, [0x09] = { "read descriptor" }, [0x0a] = { "write descriptor" }, [0x05] = { "open info block" }, [0x06] = { "read info block" }, [0x07] = { "write info block" }, [0x0b] = { "search descriptor" }, [0x0d] = { "object number select" }, /* TA Document 1999015 */ /* AV/C Command Set for Rate Control of Isochronous Data Flow 1.0 */ [0xb3] = { "rate", { { "subfunction", 0, 8 }, { "result", 8, 8 }, { "plug_type", 16, 8 }, { "plug_id", 16, 8 }, } }, /* TA Document 1999008 */ /* AV/C Audio Subunit Specification 1.0 */ [0xb8] = { "function block" }, /* TA Document 2001001 */ /* AV/C Panel Subunit Specification 1.1 */ [0x7d] = { "gui update" }, [0x7e] = { "push gui data" }, [0x7f] = { "user action" }, [0x7c] = { "pass through" }, /* */ [0x26] = { "asynchronous connection" }, }; struct avc_frame { uint32_t operand0:8; uint32_t opcode:8; uint32_t subunit_id:3; uint32_t subunit_type:5; uint32_t ctype:4; uint32_t cts:4; }; static void decode_avc(struct link_transaction *t) { struct avc_frame *frame = (struct avc_frame *) t->request->packet.write_block.data; const struct avc_opcode_info *info; const char *name; char buffer[32]; int i; info = &opcode_info[frame->opcode]; if (info->name == NULL) { snprintf(buffer, sizeof(buffer), "(unknown opcode 0x%02x)", frame->opcode); name = buffer; } else { name = info->name; } printf("av/c %s, subunit_type=%s, subunit_id=%d, opcode=%s", ctype_names[frame->ctype], subunit_type_names[frame->subunit_type], frame->subunit_id, name); for (i = 0; info->fields[i].name != NULL; i++) printf(", %s", info->fields[i].name); printf("\n"); } int decode_fcp(struct link_transaction *t) { struct avc_frame *frame = (struct avc_frame *) t->request->packet.write_block.data; unsigned long long offset = ((unsigned long long) t->request->packet.common.offset_high << 32) | t->request->packet.common.offset_low; if (t->request->packet.common.tcode != TCODE_WRITE_BLOCK_REQUEST) return 0; if (offset == CSR_FCP_COMMAND || offset == CSR_FCP_RESPONSE) { switch (frame->cts) { case 0x00: decode_avc(t); break; case 0x01: printf("cal fcp frame (cts=0x01)\n"); break; case 0x02: printf("ehs fcp frame (cts=0x02)\n"); break; case 0x03: printf("havi fcp frame (cts=0x03)\n"); break; case 0x0e: printf("vendor specific fcp frame (cts=0x0e)\n"); break; case 0x0f: printf("extended cts\n"); break; default: printf("reserved fcp frame (ctx=0x%02x)\n", frame->cts); break; } return 1; } return 0; } a href='/cgit.cgi/linux/net-next.git/tree/include/uapi/linux/input-event-codes.h?id=39cb2c9a316e77f6dfba96c543e55b6672d5a37e'>include/uapi/linux/input-event-codes.h parent2c5d9555d6d937966d79d4c6529a5f7b9206e405 (diff)
drm/i915: Check for NULL i915_vma in intel_unpin_fb_obj()
I've seen this trigger twice now, where the i915_gem_object_to_ggtt() call in intel_unpin_fb_obj() returns NULL, resulting in an oops immediately afterwards as the (inlined) call to i915_vma_unpin_fence() tries to dereference it. It seems to be some race condition where the object is going away at shutdown time, since both times happened when shutting down the X server. The call chains were different: - VT ioctl(KDSETMODE, KD_TEXT): intel_cleanup_plane_fb+0x5b/0xa0 [i915] drm_atomic_helper_cleanup_planes+0x6f/0x90 [drm_kms_helper] intel_atomic_commit_tail+0x749/0xfe0 [i915] intel_atomic_commit+0x3cb/0x4f0 [i915] drm_atomic_commit+0x4b/0x50 [drm] restore_fbdev_mode+0x14c/0x2a0 [drm_kms_helper] drm_fb_helper_restore_fbdev_mode_unlocked+0x34/0x80 [drm_kms_helper] drm_fb_helper_set_par+0x2d/0x60 [drm_kms_helper] intel_fbdev_set_par+0x18/0x70 [i915] fb_set_var+0x236/0x460 fbcon_blank+0x30f/0x350 do_unblank_screen+0xd2/0x1a0 vt_ioctl+0x507/0x12a0 tty_ioctl+0x355/0xc30 do_vfs_ioctl+0xa3/0x5e0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x13/0x94 - i915 unpin_work workqueue: intel_unpin_work_fn+0x58/0x140 [i915] process_one_work+0x1f1/0x480 worker_thread+0x48/0x4d0 kthread+0x101/0x140 and this patch purely papers over the issue by adding a NULL pointer check and a WARN_ON_ONCE() to avoid the oops that would then generally make the machine unresponsive. Other callers of i915_gem_object_to_ggtt() seem to also check for the returned pointer being NULL and warn about it, so this clearly has happened before in other places. [ Reported it originally to the i915 developers on Jan 8, applying the ugly workaround on my own now after triggering the problem for the second time with no feedback. This is likely to be the same bug reported as https://bugs.freedesktop.org/show_bug.cgi?id=98829 https://bugs.freedesktop.org/show_bug.cgi?id=99134 which has a patch for the underlying problem, but it hasn't gotten to me, so I'm applying the workaround. ] Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'include/uapi/linux/input-event-codes.h')