#ifndef _LIBLOCKDEP_MUTEX_H #define _LIBLOCKDEP_MUTEX_H #include #include "common.h" struct liblockdep_pthread_mutex { pthread_mutex_t mutex; struct lockdep_map dep_map; }; typedef struct liblockdep_pthread_mutex liblockdep_pthread_mutex_t; #define LIBLOCKDEP_PTHREAD_MUTEX_INITIALIZER(mtx) \ (const struct liblockdep_pthread_mutex) { \ .mutex = PTHREAD_MUTEX_INITIALIZER, \ .dep_map = STATIC_LOCKDEP_MAP_INIT(#mtx, &((&(mtx))->dep_map)), \ } static inline int __mutex_init(liblockdep_pthread_mutex_t *lock, const char *name, struct lock_class_key *key, const pthread_mutexattr_t *__mutexattr) { lockdep_init_map(&lock->dep_map, name, key, 0); return pthread_mutex_init(&lock->mutex, __mutexattr); } #define liblockdep_pthread_mutex_init(mutex, mutexattr) \ ({ \ static struct lock_class_key __key; \ \ __mutex_init((mutex), #mutex, &__key, (mutexattr)); \ }) static inline int liblockdep_pthread_mutex_lock(liblockdep_pthread_mutex_t *lock) { lock_acquire(&lock->dep_map, 0, 0, 0, 1, NULL, (unsigned long)_RET_IP_); return pthread_mutex_lock(&lock->mutex); } static inline int liblockdep_pthread_mutex_unlock(liblockdep_pthread_mutex_t *lock) { lock_release(&lock->dep_map, 0, (unsigned long)_RET_IP_); return pthread_mutex_unlock(&lock->mutex); } static inline int liblockdep_pthread_mutex_trylock(liblockdep_pthread_mutex_t *lock) { lock_acquire(&lock->dep_map, 0, 1, 0, 1, NULL, (unsigned long)_RET_IP_); return pthread_mutex_trylock(&lock->mutex) == 0 ? 1 : 0; } static inline int liblockdep_pthread_mutex_destroy(liblockdep_pthread_mutex_t *lock) { return pthread_mutex_destroy(&lock->mutex); } #ifdef __USE_LIBLOCKDEP #define pthread_mutex_t liblockdep_pthread_mutex_t #define pthread_mutex_init liblockdep_pthread_mutex_init #define pthread_mutex_lock liblockdep_pthread_mutex_lock #define pthread_mutex_unlock liblockdep_pthread_mutex_unlock #define pthread_mutex_trylock liblockdep_pthread_mutex_trylock #define pthread_mutex_destroy liblockdep_pthread_mutex_destroy #endif #endif emove&id=c8f325a59cfc718d13a50fbc746ed9b415c25e92'>commitdiff
path: root/sound/soc/pxa/imote2.c
diff options
context:
space:
mode:
authorArd Biesheuvel <ard.biesheuvel@linaro.org>2017-02-01 17:45:02 +0000
committerIngo Molnar <mingo@kernel.org>2017-02-01 21:17:49 +0100
commitc8f325a59cfc718d13a50fbc746ed9b415c25e92 (patch)
treed53fbdac9d0781e39a13b2ac6b2bd258cf3b4140 /sound/soc/pxa/imote2.c
parentbf29bddf0417a4783da3b24e8c9e017ac649326f (diff)
efi/fdt: Avoid FDT manipulation after ExitBootServices()
Some AArch64 UEFI implementations disable the MMU in ExitBootServices(), after which unaligned accesses to RAM are no longer supported. Commit: abfb7b686a3e ("efi/libstub/arm*: Pass latest memory map to the kernel") fixed an issue in the memory map handling of the stub FDT code, but inadvertently created an issue with such firmware, by moving some of the FDT manipulation to after the invocation of ExitBootServices(). Given that the stub's libfdt implementation uses the ordinary, accelerated string functions, which rely on hardware handling of unaligned accesses, manipulating the FDT with the MMU off may result in alignment faults. So fix the situation by moving the update_fdt_memmap() call into the callback function invoked by efi_exit_boot_services() right before it calls the ExitBootServices() UEFI service (which is arguably a better place for it anyway) Note that disabling the MMU in ExitBootServices() is not compliant with the UEFI spec, and carries great risk due to the fact that switching from cached to uncached memory accesses halfway through compiler generated code (i.e., involving a stack) can never be done in a way that is architecturally safe. Fixes: abfb7b686a3e ("efi/libstub/arm*: Pass latest memory map to the kernel") Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Tested-by: Riku Voipio <riku.voipio@linaro.org> Cc: <stable@vger.kernel.org> Cc: mark.rutland@arm.com Cc: linux-efi@vger.kernel.org Cc: matt@codeblueprint.co.uk Cc: leif.lindholm@linaro.org Cc: linux-arm-kernel@lists.infradead.org Link: http://lkml.kernel.org/r/1485971102-23330-2-git-send-email-ard.biesheuvel@linaro.org Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'sound/soc/pxa/imote2.c')