/* * Copyright (C) 2015 Josh Poimboeuf * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License * as published by the Free Software Foundation; either version 2 * of the License, or (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, see . */ /* * objtool: * * The 'check' subcmd analyzes every .o file and ensures the validity of its * stack trace metadata. It enforces a set of rules on asm code and C inline * assembly code so that stack traces can be reliable. * * For more information, see tools/objtool/Documentation/stack-validation.txt. */ #include #include #include #include #include #include #include "builtin.h" #define ARRAY_SIZE(x) (sizeof(x)/sizeof(x[0])) struct cmd_struct { const char *name; int (*fn)(int, const char **); const char *help; }; static const char objtool_usage_string[] = "objtool [OPTIONS] COMMAND [ARGS]"; static struct cmd_struct objtool_cmds[] = { {"check", cmd_check, "Perform stack metadata validation on an object file" }, }; bool help; static void cmd_usage(void) { unsigned int i, longest = 0; printf("\n usage: %s\n\n", objtool_usage_string); for (i = 0; i < ARRAY_SIZE(objtool_cmds); i++) { if (longest < strlen(objtool_cmds[i].name)) longest = strlen(objtool_cmds[i].name); } puts(" Commands:"); for (i = 0; i < ARRAY_SIZE(objtool_cmds); i++) { printf(" %-*s ", longest, objtool_cmds[i].name); puts(objtool_cmds[i].help); } printf("\n"); exit(1); } static void handle_options(int *argc, const char ***argv) { while (*argc > 0) { const char *cmd = (*argv)[0]; if (cmd[0] != '-') break; if (!strcmp(cmd, "--help") || !strcmp(cmd, "-h")) { help = true; break; } else { fprintf(stderr, "Unknown option: %s\n", cmd); fprintf(stderr, "\n Usage: %s\n", objtool_usage_string); exit(1); } (*argv)++; (*argc)--; } } static void handle_internal_command(int argc, const char **argv) { const char *cmd = argv[0]; unsigned int i, ret; for (i = 0; i < ARRAY_SIZE(objtool_cmds); i++) { struct cmd_struct *p = objtool_cmds+i; if (strcmp(p->name, cmd)) continue; ret = p->fn(argc, argv); exit(ret); } cmd_usage(); } int main(int argc, const char **argv) { static const char *UNUSED = "OBJTOOL_NOT_IMPLEMENTED"; /* libsubcmd init */ exec_cmd_init("objtool", UNUSED, UNUSED, UNUSED); pager_init(UNUSED); argv++; argc--; handle_options(&argc, &argv); if (!argc || help) cmd_usage(); handle_internal_command(argc, argv); return 0; } 77f6dfba96c543e55b6672d5a37e'>root/tools/testing/selftests/memfd
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
commit39cb2c9a316e77f6dfba96c543e55b6672d5a37e (patch)
tree98fe974ee4e20121253de7f61fc8d01bdb3821c1 /tools/testing/selftests/memfd
parent2c5d9555d6d937966d79d4c6529a5f7b9206e405 (diff)
drm/i915: Check for NULL i915_vma in intel_unpin_fb_obj()
I've seen this trigger twice now, where the i915_gem_object_to_ggtt() call in intel_unpin_fb_obj() returns NULL, resulting in an oops immediately afterwards as the (inlined) call to i915_vma_unpin_fence() tries to dereference it. It seems to be some race condition where the object is going away at shutdown time, since both times happened when shutting down the X server. The call chains were different: - VT ioctl(KDSETMODE, KD_TEXT): intel_cleanup_plane_fb+0x5b/0xa0 [i915] drm_atomic_helper_cleanup_planes+0x6f/0x90 [drm_kms_helper] intel_atomic_commit_tail+0x749/0xfe0 [i915] intel_atomic_commit+0x3cb/0x4f0 [i915] drm_atomic_commit+0x4b/0x50 [drm] restore_fbdev_mode+0x14c/0x2a0 [drm_kms_helper] drm_fb_helper_restore_fbdev_mode_unlocked+0x34/0x80 [drm_kms_helper] drm_fb_helper_set_par+0x2d/0x60 [drm_kms_helper] intel_fbdev_set_par+0x18/0x70 [i915] fb_set_var+0x236/0x460 fbcon_blank+0x30f/0x350 do_unblank_screen+0xd2/0x1a0 vt_ioctl+0x507/0x12a0 tty_ioctl+0x355/0xc30 do_vfs_ioctl+0xa3/0x5e0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x13/0x94 - i915 unpin_work workqueue: intel_unpin_work_fn+0x58/0x140 [i915] process_one_work+0x1f1/0x480 worker_thread+0x48/0x4d0 kthread+0x101/0x140 and this patch purely papers over the issue by adding a NULL pointer check and a WARN_ON_ONCE() to avoid the oops that would then generally make the machine unresponsive. Other callers of i915_gem_object_to_ggtt() seem to also check for the returned pointer being NULL and warn about it, so this clearly has happened before in other places. [ Reported it originally to the i915 developers on Jan 8, applying the ugly workaround on my own now after triggering the problem for the second time with no feedback. This is likely to be the same bug reported as https://bugs.freedesktop.org/show_bug.cgi?id=98829 https://bugs.freedesktop.org/show_bug.cgi?id=99134 which has a patch for the underlying problem, but it hasn't gotten to me, so I'm applying the workaround. ] Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'tools/testing/selftests/memfd')