#ifndef ARCH_PERF_REGS_H #define ARCH_PERF_REGS_H #include #include #include void perf_regs_load(u64 *regs); #define PERF_REGS_MASK ((1ULL << PERF_REG_ARM64_MAX) - 1) #define PERF_REGS_MAX PERF_REG_ARM64_MAX #define PERF_SAMPLE_REGS_ABI PERF_SAMPLE_REGS_ABI_64 #define PERF_REG_IP PERF_REG_ARM64_PC #define PERF_REG_SP PERF_REG_ARM64_SP static inline const char *perf_reg_name(int id) { switch (id) { case PERF_REG_ARM64_X0: return "x0"; case PERF_REG_ARM64_X1: return "x1"; case PERF_REG_ARM64_X2: return "x2"; case PERF_REG_ARM64_X3: return "x3"; case PERF_REG_ARM64_X4: return "x4"; case PERF_REG_ARM64_X5: return "x5"; case PERF_REG_ARM64_X6: return "x6"; case PERF_REG_ARM64_X7: return "x7"; case PERF_REG_ARM64_X8: return "x8"; case PERF_REG_ARM64_X9: return "x9"; case PERF_REG_ARM64_X10: return "x10"; case PERF_REG_ARM64_X11: return "x11"; case PERF_REG_ARM64_X12: return "x12"; case PERF_REG_ARM64_X13: return "x13"; case PERF_REG_ARM64_X14: return "x14"; case PERF_REG_ARM64_X15: return "x15"; case PERF_REG_ARM64_X16: return "x16"; case PERF_REG_ARM64_X17: return "x17"; case PERF_REG_ARM64_X18: return "x18"; case PERF_REG_ARM64_X19: return "x19"; case PERF_REG_ARM64_X20: return "x20"; case PERF_REG_ARM64_X21: return "x21"; case PERF_REG_ARM64_X22: return "x22"; case PERF_REG_ARM64_X23: return "x23"; case PERF_REG_ARM64_X24: return "x24"; case PERF_REG_ARM64_X25: return "x25"; case PERF_REG_ARM64_X26: return "x26"; case PERF_REG_ARM64_X27: return "x27"; case PERF_REG_ARM64_X28: return "x28"; case PERF_REG_ARM64_X29: return "x29"; case PERF_REG_ARM64_SP: return "sp"; case PERF_REG_ARM64_LR: return "lr"; case PERF_REG_ARM64_PC: return "pc"; default: return NULL; } return NULL; } #endif /* ARCH_PERF_REGS_H */ ls/hv/hv_fcopy_daemon.c?id=e3426e12fee11cb7949b65428955127ca3dcb433'>commitdiff
414e54bf1a'>pmu-events/jsmn.c
diff options
AgeCommit message (Expand)AuthorFilesLines
context:
space:
mode:
authorIago Abal <mail@iagoabal.eu>2017-01-11 14:00:21 +0100
committerVinod Koul <vinod.koul@intel.com>2017-01-25 15:35:11 +0530
commit91539eb1fda2d530d3b268eef542c5414e54bf1a (patch)
tree960f5ca6342ad20837aff18aad6e8ecd7da32fd6 /tools/perf/pmu-events/jsmn.c
parent6610d0edf6dc7ee97e46ab3a538a565c79d26199 (diff)
dmaengine: pl330: fix double lock
The static bug finder EBA (http://www.iagoabal.eu/eba/) reported the following double-lock bug: Double lock: 1. spin_lock_irqsave(pch->lock, flags) at pl330_free_chan_resources:2236; 2. call to function `pl330_release_channel' immediately after; 3. call to function `dma_pl330_rqcb' in line 1753; 4. spin_lock_irqsave(pch->lock, flags) at dma_pl330_rqcb:1505. I have fixed it as suggested by Marek Szyprowski. First, I have replaced `pch->lock' with `pl330->lock' in functions `pl330_alloc_chan_resources' and `pl330_free_chan_resources'. This avoids the double-lock by acquiring a different lock than `dma_pl330_rqcb'. NOTE that, as a result, `pl330_free_chan_resources' executes `list_splice_tail_init' on `pch->work_list' under lock `pl330->lock', whereas in the rest of the code `pch->work_list' is protected by `pch->lock'. I don't know if this may cause race conditions. Similarly `pch->cyclic' is written by `pl330_alloc_chan_resources' under `pl330->lock' but read by `pl330_tx_submit' under `pch->lock'. Second, I have removed locking from `pl330_request_channel' and `pl330_release_channel' functions. Function `pl330_request_channel' is only called from `pl330_alloc_chan_resources', so the lock is already held. Function `pl330_release_channel' is called from `pl330_free_chan_resources', which already holds the lock, and from `pl330_del'. Function `pl330_del' is called in an error path of `pl330_probe' and at the end of `pl330_remove', but I assume that there cannot be concurrent accesses to the protected data at those points. Signed-off-by: Iago Abal <mail@iagoabal.eu> Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'tools/perf/pmu-events/jsmn.c')