#include #include #include "common.h" #include "../util/util.h" #include "../util/debug.h" const char *const arm_triplets[] = { "arm-eabi-", "arm-linux-androideabi-", "arm-unknown-linux-", "arm-unknown-linux-gnu-", "arm-unknown-linux-gnueabi-", "arm-linux-gnu-", "arm-linux-gnueabihf-", "arm-none-eabi-", NULL }; const char *const arm64_triplets[] = { "aarch64-linux-android-", "aarch64-linux-gnu-", NULL }; const char *const powerpc_triplets[] = { "powerpc-unknown-linux-gnu-", "powerpc64-unknown-linux-gnu-", "powerpc64-linux-gnu-", "powerpc64le-linux-gnu-", NULL }; const char *const s390_triplets[] = { "s390-ibm-linux-", "s390x-linux-gnu-", NULL }; const char *const sh_triplets[] = { "sh-unknown-linux-gnu-", "sh64-unknown-linux-gnu-", "sh-linux-gnu-", "sh64-linux-gnu-", NULL }; const char *const sparc_triplets[] = { "sparc-unknown-linux-gnu-", "sparc64-unknown-linux-gnu-", "sparc64-linux-gnu-", NULL }; const char *const x86_triplets[] = { "x86_64-pc-linux-gnu-", "x86_64-unknown-linux-gnu-", "i686-pc-linux-gnu-", "i586-pc-linux-gnu-", "i486-pc-linux-gnu-", "i386-pc-linux-gnu-", "i686-linux-android-", "i686-android-linux-", "x86_64-linux-gnu-", "i586-linux-gnu-", NULL }; const char *const mips_triplets[] = { "mips-unknown-linux-gnu-", "mipsel-linux-android-", "mips-linux-gnu-", "mips64-linux-gnu-", "mips64el-linux-gnuabi64-", "mips64-linux-gnuabi64-", "mipsel-linux-gnu-", NULL }; static bool lookup_path(char *name) { bool found = false; char *path, *tmp = NULL; char buf[PATH_MAX]; char *env = getenv("PATH"); if (!env) return false; env = strdup(env); if (!env) return false; path = strtok_r(env, ":", &tmp); while (path) { scnprintf(buf, sizeof(buf), "%s/%s", path, name); if (access(buf, F_OK) == 0) { found = true; break; } path = strtok_r(NULL, ":", &tmp); } free(env); return found; } static int lookup_triplets(const char *const *triplets, const char *name) { int i; char buf[PATH_MAX]; for (i = 0; triplets[i] != NULL; i++) { scnprintf(buf, sizeof(buf), "%s%s", triplets[i], name); if (lookup_path(buf)) return i; } return -1; } /* * Return architecture name in a normalized form. * The conversion logic comes from the Makefile. */ const char *normalize_arch(char *arch) { if (!strcmp(arch, "x86_64")) return "x86"; if (arch[0] == 'i' && arch[2] == '8' && arch[3] == '6') return "x86"; if (!strcmp(arch, "sun4u") || !strncmp(arch, "sparc", 5)) return "sparc"; if (!strcmp(arch, "aarch64") || !strcmp(arch, "arm64")) return "arm64"; if (!strncmp(arch, "arm", 3) || !strcmp(arch, "sa110")) return "arm"; if (!strncmp(arch, "s390", 4)) return "s390"; if (!strncmp(arch, "parisc", 6)) return "parisc"; if (!strncmp(arch, "powerpc", 7) || !strncmp(arch, "ppc", 3)) return "powerpc"; if (!strncmp(arch, "mips", 4)) return "mips"; if (!strncmp(arch, "sh", 2) && isdigit(arch[2])) return "sh"; return arch; } static int perf_env__lookup_binutils_path(struct perf_env *env, const char *name, const char **path) { int idx; const char *arch, *cross_env; struct utsname uts; const char *const *path_list; char *buf = NULL; arch = normalize_arch(env->arch); if (uname(&uts) < 0) goto out; /* * We don't need to try to find objdump path for native system. * Just use default binutils path (e.g.: "objdump"). */ if (!strcmp(normalize_arch(uts.machine), arch)) goto out; cross_env = getenv("CROSS_COMPILE"); if (cross_env) { if (asprintf(&buf, "%s%s", cross_env, name) < 0) goto out_error; if (buf[0] == '/') { if (access(buf, F_OK) == 0) goto out; goto out_error; } if (lookup_path(buf)) goto out; zfree(&buf); } if (!strcmp(arch, "arm")) path_list = arm_triplets; else if (!strcmp(arch, "arm64")) path_list = arm64_triplets; else if (!strcmp(arch, "powerpc")) path_list = powerpc_triplets; else if (!strcmp(arch, "sh")) path_list = sh_triplets; else if (!strcmp(arch, "s390")) path_list = s390_triplets; else if (!strcmp(arch, "sparc")) path_list = sparc_triplets; else if (!strcmp(arch, "x86")) path_list = x86_triplets; else if (!strcmp(arch, "mips")) path_list = mips_triplets; else { ui__error("binutils for %s not supported.\n", arch); goto out_error; } idx = lookup_triplets(path_list, name); if (idx < 0) { ui__error("Please install %s for %s.\n" "You can add it to PATH, set CROSS_COMPILE or " "override the default using --%s.\n", name, arch, name); goto out_error; } if (asprintf(&buf, "%s%s", path_list[idx], name) < 0) goto out_error; out: *path = buf; return 0; out_error: free(buf); *path = NULL; return -1; } int perf_env__lookup_objdump(struct perf_env *env) { /* * For live mode, env->arch will be NULL and we can use * the native objdump tool. */ if (env->arch == NULL) return 0; return perf_env__lookup_binutils_path(env, "objdump", &objdump_path); }
authorLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
commit39cb2c9a316e77f6dfba96c543e55b6672d5a37e (patch)
tree98fe974ee4e20121253de7f61fc8d01bdb3821c1 /tools/perf/util/demangle-rust.c
parent2c5d9555d6d937966d79d4c6529a5f7b9206e405 (diff)
drm/i915: Check for NULL i915_vma in intel_unpin_fb_obj()
I've seen this trigger twice now, where the i915_gem_object_to_ggtt() call in intel_unpin_fb_obj() returns NULL, resulting in an oops immediately afterwards as the (inlined) call to i915_vma_unpin_fence() tries to dereference it. It seems to be some race condition where the object is going away at shutdown time, since both times happened when shutting down the X server. The call chains were different: - VT ioctl(KDSETMODE, KD_TEXT): intel_cleanup_plane_fb+0x5b/0xa0 [i915] drm_atomic_helper_cleanup_planes+0x6f/0x90 [drm_kms_helper] intel_atomic_commit_tail+0x749/0xfe0 [i915] intel_atomic_commit+0x3cb/0x4f0 [i915] drm_atomic_commit+0x4b/0x50 [drm] restore_fbdev_mode+0x14c/0x2a0 [drm_kms_helper] drm_fb_helper_restore_fbdev_mode_unlocked+0x34/0x80 [drm_kms_helper] drm_fb_helper_set_par+0x2d/0x60 [drm_kms_helper] intel_fbdev_set_par+0x18/0x70 [i915] fb_set_var+0x236/0x460 fbcon_blank+0x30f/0x350 do_unblank_screen+0xd2/0x1a0 vt_ioctl+0x507/0x12a0 tty_ioctl+0x355/0xc30 do_vfs_ioctl+0xa3/0x5e0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x13/0x94 - i915 unpin_work workqueue: intel_unpin_work_fn+0x58/0x140 [i915] process_one_work+0x1f1/0x480 worker_thread+0x48/0x4d0 kthread+0x101/0x140 and this patch purely papers over the issue by adding a NULL pointer check and a WARN_ON_ONCE() to avoid the oops that would then generally make the machine unresponsive. Other callers of i915_gem_object_to_ggtt() seem to also check for the returned pointer being NULL and warn about it, so this clearly has happened before in other places. [ Reported it originally to the i915 developers on Jan 8, applying the ugly workaround on my own now after triggering the problem for the second time with no feedback. This is likely to be the same bug reported as https://bugs.freedesktop.org/show_bug.cgi?id=98829 https://bugs.freedesktop.org/show_bug.cgi?id=99134 which has a patch for the underlying problem, but it hasn't gotten to me, so I'm applying the workaround. ] Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'tools/perf/util/demangle-rust.c')