#include #include #include #include #include #include "tests.h" #include "debug.h" #include "probe-file.h" #include "build-id.h" /* To test SDT event, we need libelf support to scan elf binary */ #if defined(HAVE_SDT_EVENT) && defined(HAVE_LIBELF_SUPPORT) #include static int target_function(void) { DTRACE_PROBE(perf, test_target); return TEST_OK; } /* Copied from builtin-buildid-cache.c */ static int build_id_cache__add_file(const char *filename) { char sbuild_id[SBUILD_ID_SIZE]; u8 build_id[BUILD_ID_SIZE]; int err; err = filename__read_build_id(filename, &build_id, sizeof(build_id)); if (err < 0) { pr_debug("Failed to read build id of %s\n", filename); return err; } build_id__sprintf(build_id, sizeof(build_id), sbuild_id); err = build_id_cache__add_s(sbuild_id, filename, false, false); if (err < 0) pr_debug("Failed to add build id cache of %s\n", filename); return err; } static char *get_self_path(void) { char *buf = calloc(PATH_MAX, sizeof(char)); if (buf && readlink("/proc/self/exe", buf, PATH_MAX) < 0) { pr_debug("Failed to get correct path of perf\n"); free(buf); return NULL; } return buf; } static int search_cached_probe(const char *target, const char *group, const char *event) { struct probe_cache *cache = probe_cache__new(target); int ret = 0; if (!cache) { pr_debug("Failed to open probe cache of %s\n", target); return -EINVAL; } if (!probe_cache__find_by_name(cache, group, event)) { pr_debug("Failed to find %s:%s in the cache\n", group, event); ret = -ENOENT; } probe_cache__delete(cache); return ret; } int test__sdt_event(int subtests __maybe_unused) { int ret = TEST_FAIL; char __tempdir[] = "./test-buildid-XXXXXX"; char *tempdir = NULL, *myself = get_self_path(); if (myself == NULL || mkdtemp(__tempdir) == NULL) { pr_debug("Failed to make a tempdir for build-id cache\n"); goto error; } /* Note that buildid_dir must be an absolute path */ tempdir = realpath(__tempdir, NULL); /* At first, scan itself */ set_buildid_dir(tempdir); if (build_id_cache__add_file(myself) < 0) goto error_rmdir; /* Open a cache and make sure the SDT is stored */ if (search_cached_probe(myself, "sdt_perf", "test_target") < 0) goto error_rmdir; /* TBD: probing on the SDT event and collect logs */ /* Call the target and get an event */ ret = target_function(); error_rmdir: /* Cleanup temporary buildid dir */ rm_rf(tempdir); error: free(tempdir); free(myself); return ret; } #else int test__sdt_event(int subtests __maybe_unused) { pr_debug("Skip SDT event test because SDT support is not compiled\n"); return TEST_SKIP; } #endif '>root/drivers/usb/class
diff options
context:
space:
mode:
authorJisheng Zhang <jszhang@marvell.com>2016-11-10 17:21:29 +0800
committerMark Brown <broonie@kernel.org>2016-11-11 15:38:08 +0000
commit09f2ba0b0b7c44ecea49cf69a708203b76ba5535 (patch)
tree042df33ac99f77d8b86ac427431e267c33561c35 /drivers/usb/class
parent1001354ca34179f3db924eb66672442a173147dc (diff)
regulator: gpio: properly check return value of of_get_named_gpio
The function of_get_named_gpio() could return -ENOENT, -EPROBE_DEFER -EINVAL and so on. Currently, for the optional property "enable-gpio", we only check -EPROBE_DEFER, this is not enough since there may be misconfigured "enable-gpio" in the DTB, of_get_named_gpio() will return -EINVAL in this case, we should return immediately here. And for the optional property "gpios", we didn't check the return value, the driver will continue to the point where gpio_request_array() is called, it doesn't make sense to continue if we got -EPROBE_DEFER or -EINVAL here. This patch tries to address these two issues by properly checking the return value of of_get_named_gpio. Signed-off-by: Jisheng Zhang <jszhang@marvell.com> Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/usb/class')