#include <stdio.h>
#include <stdlib.h>
#include <string.h>

#include "../debug.h"
#include "helpline.h"
#include "ui.h"
#include "../util.h"

char ui_helpline__current[512];

static void nop_helpline__pop(void)
{
}

static void nop_helpline__push(const char *msg __maybe_unused)
{
}

static int nop_helpline__show(const char *fmt __maybe_unused,
			       va_list ap __maybe_unused)
{
	return 0;
}

static struct ui_helpline default_helpline_fns = {
	.pop	= nop_helpline__pop,
	.push	= nop_helpline__push,
	.show	= nop_helpline__show,
};

struct ui_helpline *helpline_fns = &default_helpline_fns;

void ui_helpline__pop(void)
{
	helpline_fns->pop();
}

void ui_helpline__push(const char *msg)
{
	helpline_fns->push(msg);
}

void ui_helpline__vpush(const char *fmt, va_list ap)
{
	char *s;

	if (vasprintf(&s, fmt, ap) < 0)
		vfprintf(stderr, fmt, ap);
	else {
		ui_helpline__push(s);
		free(s);
	}
}

void ui_helpline__fpush(const char *fmt, ...)
{
	va_list ap;

	va_start(ap, fmt);
	ui_helpline__vpush(fmt, ap);
	va_end(ap);
}

void ui_helpline__puts(const char *msg)
{
	ui_helpline__pop();
	ui_helpline__push(msg);
}

int ui_helpline__vshow(const char *fmt, va_list ap)
{
	return helpline_fns->show(fmt, ap);
}

void ui_helpline__printf(const char *fmt, ...)
{
	va_list ap;

	ui_helpline__pop();
	va_start(ap, fmt);
	ui_helpline__vpush(fmt, ap);
	va_end(ap);
}
/option>
</select> <input type='submit' value='switch'/></form></td></tr>
<tr><td class='sub'>net-next plumbings</td><td class='sub right'>Tobias Klauser</td></tr></table>
<table class='tabs'><tr><td>
<a href='/cgit.cgi/linux/net-next.git/'>summary</a><a href='/cgit.cgi/linux/net-next.git/refs/?id=07cd12945551b63ecb1a349d50a6d69d1d6feb4a'>refs</a><a href='/cgit.cgi/linux/net-next.git/log/net/sunrpc/svc_xprt.c'>log</a><a href='/cgit.cgi/linux/net-next.git/tree/net/sunrpc/svc_xprt.c?id=07cd12945551b63ecb1a349d50a6d69d1d6feb4a'>tree</a><a class='active' href='/cgit.cgi/linux/net-next.git/commit/net/sunrpc/svc_xprt.c?id=07cd12945551b63ecb1a349d50a6d69d1d6feb4a'>commit</a><a href='/cgit.cgi/linux/net-next.git/diff/net/sunrpc/svc_xprt.c?id=07cd12945551b63ecb1a349d50a6d69d1d6feb4a'>diff</a></td><td class='form'><form class='right' method='get' action='/cgit.cgi/linux/net-next.git/log/net/sunrpc/svc_xprt.c'>
<input type='hidden' name='id' value='07cd12945551b63ecb1a349d50a6d69d1d6feb4a'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/cgit.cgi/linux/net-next.git/commit/?id=07cd12945551b63ecb1a349d50a6d69d1d6feb4a'>root</a>/<a href='/cgit.cgi/linux/net-next.git/commit/net?id=07cd12945551b63ecb1a349d50a6d69d1d6feb4a'>net</a>/<a href='/cgit.cgi/linux/net-next.git/commit/net/sunrpc?id=07cd12945551b63ecb1a349d50a6d69d1d6feb4a'>sunrpc</a>/<a href='/cgit.cgi/linux/net-next.git/commit/net/sunrpc/svc_xprt.c?id=07cd12945551b63ecb1a349d50a6d69d1d6feb4a'>svc_xprt.c</a></div><div class='content'><div class='cgit-panel'><b>diff options</b><form method='get'><input type='hidden' name='id' value='07cd12945551b63ecb1a349d50a6d69d1d6feb4a'/><table><tr><td colspan='2'/></tr><tr><td class='label'>context:</td><td class='ctrl'><select name='context' onchange='this.form.submit();'><option value='1'>1</option><option value='2'>2</option><option value='3' selected='selected'>3</option><option value='4'>4</option><option value='5'>5</option><option value='6'>6</option><option value='7'>7</option><option value='8'>8</option><option value='9'>9</option><option value='10'>10</option><option value='15'>15</option><option value='20'>20</option><option value='25'>25</option><option value='30'>30</option><option value='35'>35</option><option value='40'>40</option></select></td></tr><tr><td class='label'>space:</td><td class='ctrl'><select name='ignorews' onchange='this.form.submit();'><option value='0' selected='selected'>include</option><option value='1'>ignore</option></select></td></tr><tr><td class='label'>mode:</td><td class='ctrl'><select name='dt' onchange='this.form.submit();'><option value='0' selected='selected'>unified</option><option value='1'>ssdiff</option><option value='2'>stat only</option></select></td></tr><tr><td/><td class='ctrl'><noscript><input type='submit' value='reload'/></noscript></td></tr></table></form></div><table summary='commit info' class='commit-info'>
<tr><th>author</th><td>Tejun Heo &lt;tj@kernel.org&gt;</td><td class='right'>2017-01-26 16:47:28 -0500</td></tr>
<tr><th>committer</th><td>Tejun Heo &lt;tj@kernel.org&gt;</td><td class='right'>2017-01-26 16:47:28 -0500</td></tr>
<tr><th>commit</th><td colspan='2' class='oid'><a href='/cgit.cgi/linux/net-next.git/commit/net/sunrpc/svc_xprt.c?id=07cd12945551b63ecb1a349d50a6d69d1d6feb4a'>07cd12945551b63ecb1a349d50a6d69d1d6feb4a</a> (<a href='/cgit.cgi/linux/net-next.git/patch/net/sunrpc/svc_xprt.c?id=07cd12945551b63ecb1a349d50a6d69d1d6feb4a'>patch</a>)</td></tr>
<tr><th>tree</th><td colspan='2' class='oid'><a href='/cgit.cgi/linux/net-next.git/tree/?id=07cd12945551b63ecb1a349d50a6d69d1d6feb4a'>75f65eba7eac9277971082a2d5a4cf1370562c0c</a> /<a href='/cgit.cgi/linux/net-next.git/tree/net/sunrpc/svc_xprt.c?id=07cd12945551b63ecb1a349d50a6d69d1d6feb4a'>net/sunrpc/svc_xprt.c</a></td></tr>
<tr><th>parent</th><td colspan='2' class='oid'><a href='/cgit.cgi/linux/net-next.git/commit/net/sunrpc/svc_xprt.c?id=7ce7d89f48834cefece7804d38fc5d85382edf77'>7ce7d89f48834cefece7804d38fc5d85382edf77</a> (<a href='/cgit.cgi/linux/net-next.git/diff/net/sunrpc/svc_xprt.c?id=07cd12945551b63ecb1a349d50a6d69d1d6feb4a&amp;id2=7ce7d89f48834cefece7804d38fc5d85382edf77'>diff</a>)</td></tr></table>
<div class='commit-subject'>cgroup: don't online subsystems before cgroup_name/path() are operational</div><div class='commit-msg'>While refactoring cgroup creation, a5bca2152036 ("cgroup: factor out
cgroup_create() out of cgroup_mkdir()") incorrectly onlined subsystems
before the new cgroup is associated with it kernfs_node.  This is fine
for cgroup proper but cgroup_name/path() depend on the associated
kernfs_node and if a subsystem makes the new cgroup_subsys_state
visible, which they're allowed to after onlining, it can lead to NULL
dereference.

The current code performs cgroup creation and subsystem onlining in
cgroup_create() and cgroup_mkdir() makes the cgroup and subsystems
visible afterwards.  There's no reason to online the subsystems early
and we can simply drop cgroup_apply_control_enable() call from
cgroup_create() so that the subsystems are onlined and made visible at
the same time.

Signed-off-by: Tejun Heo &lt;tj@kernel.org&gt;
Reported-by: Konstantin Khlebnikov &lt;khlebnikov@yandex-team.ru&gt;
Fixes: a5bca2152036 ("cgroup: factor out cgroup_create() out of cgroup_mkdir()") 
Cc: stable@vger.kernel.org # v4.6+
</div><div class='diffstat-header'><a href='/cgit.cgi/linux/net-next.git/diff/?id=07cd12945551b63ecb1a349d50a6d69d1d6feb4a'>Diffstat</a> (limited to 'net/sunrpc/svc_xprt.c')</div><table summary='diffstat' class='diffstat'>