#include "util.h" #include "../debug.h" /* * Default error logging functions */ static int perf_stdio__error(const char *format, va_list args) { fprintf(stderr, "Error:\n"); vfprintf(stderr, format, args); return 0; } static int perf_stdio__warning(const char *format, va_list args) { fprintf(stderr, "Warning:\n"); vfprintf(stderr, format, args); return 0; } static struct perf_error_ops default_eops = { .error = perf_stdio__error, .warning = perf_stdio__warning, }; static struct perf_error_ops *perf_eops = &default_eops; int ui__error(const char *format, ...) { int ret; va_list args; va_start(args, format); ret = perf_eops->error(format, args); va_end(args); return ret; } int ui__warning(const char *format, ...) { int ret; va_list args; va_start(args, format); ret = perf_eops->warning(format, args); va_end(args); return ret; } /** * perf_error__register - Register error logging functions * @eops: The pointer to error logging function struct * * Register UI-specific error logging functions. Before calling this, * other logging functions should be unregistered, if any. */ int perf_error__register(struct perf_error_ops *eops) { if (perf_eops != &default_eops) return -1; perf_eops = eops; return 0; } /** * perf_error__unregister - Unregister error logging functions * @eops: The pointer to error logging function struct * * Unregister already registered error logging functions. */ int perf_error__unregister(struct perf_error_ops *eops) { if (perf_eops != eops) return -1; perf_eops = &default_eops; return 0; } xt.git/refs/?id=dd86e373e09fb16b83e8adf5c48c421a4ca76468'>refslogtreecommitdiff
path: root/net/ceph
diff options
context:
space:
mode:
authorThomas Gleixner <tglx@linutronix.de>2017-01-31 23:58:38 +0100
committerIngo Molnar <mingo@kernel.org>2017-02-01 08:37:27 +0100
commitdd86e373e09fb16b83e8adf5c48c421a4ca76468 (patch)
tree55703c2ea8584e303e342090614e0aab3509ab21 /net/ceph
parent0b3589be9b98994ce3d5aeca52445d1f5627c4ba (diff)
perf/x86/intel/rapl: Make package handling more robust
The package management code in RAPL relies on package mapping being available before a CPU is started. This changed with: 9d85eb9119f4 ("x86/smpboot: Make logical package management more robust") because the ACPI/BIOS information turned out to be unreliable, but that left RAPL in broken state. This was not noticed because on a regular boot all CPUs are online before RAPL is initialized. A possible fix would be to reintroduce the mess which allocates a package data structure in CPU prepare and when it turns out to already exist in starting throw it away later in the CPU online callback. But that's a horrible hack and not required at all because RAPL becomes functional for perf only in the CPU online callback. That's correct because user space is not yet informed about the CPU being onlined, so nothing caan rely on RAPL being available on that particular CPU. Move the allocation to the CPU online callback and simplify the hotplug handling. At this point the package mapping is established and correct. This also adds a missing check for available package data in the event_init() function. Reported-by: Yasuaki Ishimatsu <yasu.isimatu@gmail.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Sebastian Siewior <bigeasy@linutronix.de> Cc: Stephane Eranian <eranian@google.com> Cc: Vince Weaver <vincent.weaver@maine.edu> Fixes: 9d85eb9119f4 ("x86/smpboot: Make logical package management more robust") Link: http://lkml.kernel.org/r/20170131230141.212593966@linutronix.de Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'net/ceph')