/* * Simple pointer stack * * (c) 2010 Arnaldo Carvalho de Melo */ #include "util.h" #include "pstack.h" #include "debug.h" #include #include struct pstack { unsigned short top; unsigned short max_nr_entries; void *entries[0]; }; struct pstack *pstack__new(unsigned short max_nr_entries) { struct pstack *pstack = zalloc((sizeof(*pstack) + max_nr_entries * sizeof(void *))); if (pstack != NULL) pstack->max_nr_entries = max_nr_entries; return pstack; } void pstack__delete(struct pstack *pstack) { free(pstack); } bool pstack__empty(const struct pstack *pstack) { return pstack->top == 0; } void pstack__remove(struct pstack *pstack, void *key) { unsigned short i = pstack->top, last_index = pstack->top - 1; while (i-- != 0) { if (pstack->entries[i] == key) { if (i < last_index) memmove(pstack->entries + i, pstack->entries + i + 1, (last_index - i) * sizeof(void *)); --pstack->top; return; } } pr_err("%s: %p not on the pstack!\n", __func__, key); } void pstack__push(struct pstack *pstack, void *key) { if (pstack->top == pstack->max_nr_entries) { pr_err("%s: top=%d, overflow!\n", __func__, pstack->top); return; } pstack->entries[pstack->top++] = key; } void *pstack__pop(struct pstack *pstack) { void *ret; if (pstack->top == 0) { pr_err("%s: underflow!\n", __func__); return NULL; } ret = pstack->entries[--pstack->top]; pstack->entries[pstack->top] = NULL; return ret; } void *pstack__peek(struct pstack *pstack) { if (pstack->top == 0) return NULL; return pstack->entries[pstack->top - 1]; } 0cd4'>refslogtreecommitdiff
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2017-01-30 10:55:04 +0100
committerDavid S. Miller <davem@davemloft.net>2017-01-30 16:37:55 -0500
commitcdaf25dfc058ee6f7a7b2e2353de00fa288c0cd4 (patch)
treea45096fd9e8aaeea2eac1f1999a3d17dfeb0d02b /net/wireless/sme.c
parent1930b60352e7e195f55b27cde15d2a8f43342a8b (diff)
smc: some potential use after free bugs
Say we got really unlucky and these failed on the last iteration, then it could lead to a use after free bug. Fixes: cd6851f30386 ("smc: remote memory buffers (RMBs)") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Ursula Braun <ubraun@linux.vnet.ibm.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/wireless/sme.c')