/****************************************************************************** * * Module Name: getopt * *****************************************************************************/ /* * Copyright (C) 2000 - 2016, Intel Corp. * All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions * are met: * 1. Redistributions of source code must retain the above copyright * notice, this list of conditions, and the following disclaimer, * without modification. * 2. Redistributions in binary form must reproduce at minimum a disclaimer * substantially similar to the "NO WARRANTY" disclaimer below * ("Disclaimer") and any redistribution must be conditioned upon * including a substantially similar Disclaimer requirement for further * binary redistribution. * 3. Neither the names of the above-listed copyright holders nor the names * of any contributors may be used to endorse or promote products derived * from this software without specific prior written permission. * * Alternatively, this software may be distributed under the terms of the * GNU General Public License ("GPL") version 2 as published by the Free * Software Foundation. * * NO WARRANTY * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTIBILITY AND FITNESS FOR * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT * HOLDERS OR CONTRIBUTORS BE LIABLE FOR SPECIAL, EXEMPLARY, OR CONSEQUENTIAL * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, * STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING * IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE * POSSIBILITY OF SUCH DAMAGES. */ /* * ACPICA getopt() implementation * * Option strings: * "f" - Option has no arguments * "f:" - Option requires an argument * "f+" - Option has an optional argument * "f^" - Option has optional single-char sub-options * "f|" - Option has required single-char sub-options */ #include #include "accommon.h" #include "acapps.h" #define ACPI_OPTION_ERROR(msg, badchar) \ if (acpi_gbl_opterr) {fprintf (stderr, "%s%c\n", msg, badchar);} int acpi_gbl_opterr = 1; int acpi_gbl_optind = 1; int acpi_gbl_sub_opt_char = 0; char *acpi_gbl_optarg; static int current_char_ptr = 1; /******************************************************************************* * * FUNCTION: acpi_getopt_argument * * PARAMETERS: argc, argv - from main * * RETURN: 0 if an argument was found, -1 otherwise. Sets acpi_gbl_Optarg * to point to the next argument. * * DESCRIPTION: Get the next argument. Used to obtain arguments for the * two-character options after the original call to acpi_getopt. * Note: Either the argument starts at the next character after * the option, or it is pointed to by the next argv entry. * (After call to acpi_getopt, we need to backup to the previous * argv entry). * ******************************************************************************/ int acpi_getopt_argument(int argc, char **argv) { acpi_gbl_optind--; current_char_ptr++; if (argv[acpi_gbl_optind][(int)(current_char_ptr + 1)] != '\0') { acpi_gbl_optarg = &argv[acpi_gbl_optind++][(int)(current_char_ptr + 1)]; } else if (++acpi_gbl_optind >= argc) { ACPI_OPTION_ERROR("\nOption requires an argument", 0); current_char_ptr = 1; return (-1); } else { acpi_gbl_optarg = argv[acpi_gbl_optind++]; } current_char_ptr = 1; return (0); } /******************************************************************************* * * FUNCTION: acpi_getopt * * PARAMETERS: argc, argv - from main * opts - options info list * * RETURN: Option character or ACPI_OPT_END * * DESCRIPTION: Get the next option * ******************************************************************************/ int acpi_getopt(int argc, char **argv, char *opts) { int current_char; char *opts_ptr; if (current_char_ptr == 1) { if (acpi_gbl_optind >= argc || argv[acpi_gbl_optind][0] != '-' || argv[acpi_gbl_optind][1] == '\0') { return (ACPI_OPT_END); } else if (strcmp(argv[acpi_gbl_optind], "--") == 0) { acpi_gbl_optind++; return (ACPI_OPT_END); } } /* Get the option */ current_char = argv[acpi_gbl_optind][current_char_ptr]; /* Make sure that the option is legal */ if (current_char == ':' || (opts_ptr = strchr(opts, current_char)) == NULL) { ACPI_OPTION_ERROR("Illegal option: -", current_char); if (argv[acpi_gbl_optind][++current_char_ptr] == '\0') { acpi_gbl_optind++; current_char_ptr = 1; } return ('?'); } /* Option requires an argument? */ if (*++opts_ptr == ':') { if (argv[acpi_gbl_optind][(int)(current_char_ptr + 1)] != '\0') { acpi_gbl_optarg = &argv[acpi_gbl_optind++][(int) (current_char_ptr + 1)]; } else if (++acpi_gbl_optind >= argc) { ACPI_OPTION_ERROR("Option requires an argument: -", current_char); current_char_ptr = 1; return ('?'); } else { acpi_gbl_optarg = argv[acpi_gbl_optind++]; } current_char_ptr = 1; } /* Option has an optional argument? */ else if (*opts_ptr == '+') { if (argv[acpi_gbl_optind][(int)(current_char_ptr + 1)] != '\0') { acpi_gbl_optarg = &argv[acpi_gbl_optind++][(int) (current_char_ptr + 1)]; } else if (++acpi_gbl_optind >= argc) { acpi_gbl_optarg = NULL; } else { acpi_gbl_optarg = argv[acpi_gbl_optind++]; } current_char_ptr = 1; } /* Option has optional single-char arguments? */ else if (*opts_ptr == '^') { if (argv[acpi_gbl_optind][(int)(current_char_ptr + 1)] != '\0') { acpi_gbl_optarg = &argv[acpi_gbl_optind][(int)(current_char_ptr + 1)]; } else { acpi_gbl_optarg = "^"; } acpi_gbl_sub_opt_char = acpi_gbl_optarg[0]; acpi_gbl_optind++; current_char_ptr = 1; } /* Option has a required single-char argument? */ else if (*opts_ptr == '|') { if (argv[acpi_gbl_optind][(int)(current_char_ptr + 1)] != '\0') { acpi_gbl_optarg = &argv[acpi_gbl_optind][(int)(current_char_ptr + 1)]; } else { ACPI_OPTION_ERROR ("Option requires a single-character suboption: -", current_char); current_char_ptr = 1; return ('?'); } acpi_gbl_sub_opt_char = acpi_gbl_optarg[0]; acpi_gbl_optind++; current_char_ptr = 1; } /* Option with no arguments */ else { if (argv[acpi_gbl_optind][++current_char_ptr] == '\0') { current_char_ptr = 1; acpi_gbl_optind++; } acpi_gbl_optarg = NULL; } return (current_char); } ted, but more crtc's were included by atomic check and then failing. This can mostly happen when you do an atomic modeset in i915 and the display clock is changed, which forces all crtc's to be included to the state. This has been broken worse by adding in-fences support, which caused the double free to be done unconditionally. [IGT] kms_rotation_crc: starting subtest primary-rotation-180 ============================================================================= BUG kmalloc-128 (Tainted: G U ): Object already free ----------------------------------------------------------------------------- Disabling lock debugging due to kernel taint INFO: Allocated in drm_atomic_helper_setup_commit+0x285/0x2f0 [drm_kms_helper] age=0 cpu=3 pid=1529 ___slab_alloc+0x308/0x3b0 __slab_alloc+0xd/0x20 kmem_cache_alloc_trace+0x92/0x1c0 drm_atomic_helper_setup_commit+0x285/0x2f0 [drm_kms_helper] intel_atomic_commit+0x35/0x4f0 [i915] drm_atomic_commit+0x46/0x50 [drm] drm_mode_atomic_ioctl+0x7d4/0xab0 [drm] drm_ioctl+0x2b3/0x490 [drm] do_vfs_ioctl+0x69c/0x700 SyS_ioctl+0x4e/0x80 entry_SYSCALL_64_fastpath+0x13/0x94 INFO: Freed in drm_event_cancel_free+0xa3/0xb0 [drm] age=0 cpu=3 pid=1529 __slab_free+0x48/0x2e0 kfree+0x159/0x1a0 drm_event_cancel_free+0xa3/0xb0 [drm] drm_mode_atomic_ioctl+0x86d/0xab0 [drm] drm_ioctl+0x2b3/0x490 [drm] do_vfs_ioctl+0x69c/0x700 SyS_ioctl+0x4e/0x80 entry_SYSCALL_64_fastpath+0x13/0x94 INFO: Slab 0xffffde1f0997b080 objects=17 used=2 fp=0xffff92fb65ec2578 flags=0x200000000008101 INFO: Object 0xffff92fb65ec2578 @offset=1400 fp=0xffff92fb65ec2ae8 Redzone ffff92fb65ec2570: bb bb bb bb bb bb bb bb ........ Object ffff92fb65ec2578: 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object ffff92fb65ec2588: 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object ffff92fb65ec2598: 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object ffff92fb65ec25a8: 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object ffff92fb65ec25b8: 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object ffff92fb65ec25c8: 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object ffff92fb65ec25d8: 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object ffff92fb65ec25e8: 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b a5 kkkkkkkkkkkkkkk. Redzone ffff92fb65ec25f8: bb bb bb bb bb bb bb bb ........ Padding ffff92fb65ec2738: 5a 5a 5a 5a 5a 5a 5a 5a ZZZZZZZZ CPU: 3 PID: 180 Comm: kworker/3:2 Tainted: G BU 4.10.0-rc6-patser+ #5039 Hardware name: /NUC5PPYB, BIOS PYBSWCEL.86A.0031.2015.0601.1712 06/01/2015 Workqueue: events intel_atomic_helper_free_state [i915] Call Trace: dump_stack+0x4d/0x6d print_trailer+0x20c/0x220 free_debug_processing+0x1c6/0x330 ? drm_atomic_state_default_clear+0xf7/0x1c0 [drm] __slab_free+0x48/0x2e0 ? drm_atomic_state_default_clear+0xf7/0x1c0 [drm] kfree+0x159/0x1a0 drm_atomic_state_default_clear+0xf7/0x1c0 [drm] ? drm_atomic_state_clear+0x30/0x30 [drm] intel_atomic_state_clear+0xd/0x20 [i915] drm_atomic_state_clear+0x1a/0x30 [drm] __drm_atomic_state_free+0x13/0x60 [drm] intel_atomic_helper_free_state+0x5d/0x70 [i915] process_one_work+0x260/0x4a0 worker_thread+0x2d1/0x4f0 kthread+0x127/0x130 ? process_one_work+0x4a0/0x4a0 ? kthread_stop+0x120/0x120 ret_from_fork+0x29/0x40 FIX kmalloc-128: Object at 0xffff92fb65ec2578 not freed Fixes: 3b24f7d67581 ("drm/atomic: Add struct drm_crtc_commit to track async updates") Fixes: 9626014258a5 ("drm/fence: add in-fences support") Cc: <stable@vger.kernel.org> # v4.8+ Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.com> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> Link: http://patchwork.freedesktop.org/patch/msgid/1485854725-27640-1-git-send-email-maarten.lankhorst@linux.intel.com
Diffstat (limited to 'include/net/sctp/command.h')