#include #include #include #include "utils.h" #define SIZE 256 #define ITERATIONS 10000 int test_memcmp(const void *s1, const void *s2, size_t n); /* test all offsets and lengths */ static void test_one(char *s1, char *s2) { unsigned long offset, size; for (offset = 0; offset < SIZE; offset++) { for (size = 0; size < (SIZE-offset); size++) { int x, y; unsigned long i; y = memcmp(s1+offset, s2+offset, size); x = test_memcmp(s1+offset, s2+offset, size); if (((x ^ y) < 0) && /* Trick to compare sign */ ((x | y) != 0)) { /* check for zero */ printf("memcmp returned %d, should have returned %d (offset %ld size %ld)\n", x, y, offset, size); for (i = offset; i < offset+size; i++) printf("%02x ", s1[i]); printf("\n"); for (i = offset; i < offset+size; i++) printf("%02x ", s2[i]); printf("\n"); abort(); } } } } static int testcase(void) { char *s1; char *s2; unsigned long i; s1 = memalign(128, SIZE); if (!s1) { perror("memalign"); exit(1); } s2 = memalign(128, SIZE); if (!s2) { perror("memalign"); exit(1); } srandom(1); for (i = 0; i < ITERATIONS; i++) { unsigned long j; unsigned long change; for (j = 0; j < SIZE; j++) s1[j] = random(); memcpy(s2, s1, SIZE); /* change one byte */ change = random() % SIZE; s2[change] = random() & 0xff; test_one(s1, s2); } srandom(1); for (i = 0; i < ITERATIONS; i++) { unsigned long j; unsigned long change; for (j = 0; j < SIZE; j++) s1[j] = random(); memcpy(s2, s1, SIZE); /* change multiple bytes, 1/8 of total */ for (j = 0; j < SIZE / 8; j++) { change = random() % SIZE; s2[change] = random() & 0xff; } test_one(s1, s2); } return 0; } int main(void) { return test_harness(testcase, "memcmp"); } cgit.cgi/linux/net-next.git/tree/tools/testing/selftests/timers/nsleep-lat.c?id=07cd12945551b63ecb1a349d50a6d69d1d6feb4a'>treecommitdiff
diff options
context:
space:
mode:
authorTejun Heo <tj@kernel.org>2017-01-26 16:47:28 -0500
committerTejun Heo <tj@kernel.org>2017-01-26 16:47:28 -0500
commit07cd12945551b63ecb1a349d50a6d69d1d6feb4a (patch)
tree75f65eba7eac9277971082a2d5a4cf1370562c0c /tools/testing/selftests/timers/nsleep-lat.c
parent7ce7d89f48834cefece7804d38fc5d85382edf77 (diff)
cgroup: don't online subsystems before cgroup_name/path() are operational
While refactoring cgroup creation, a5bca2152036 ("cgroup: factor out cgroup_create() out of cgroup_mkdir()") incorrectly onlined subsystems before the new cgroup is associated with it kernfs_node. This is fine for cgroup proper but cgroup_name/path() depend on the associated kernfs_node and if a subsystem makes the new cgroup_subsys_state visible, which they're allowed to after onlining, it can lead to NULL dereference. The current code performs cgroup creation and subsystem onlining in cgroup_create() and cgroup_mkdir() makes the cgroup and subsystems visible afterwards. There's no reason to online the subsystems early and we can simply drop cgroup_apply_control_enable() call from cgroup_create() so that the subsystems are onlined and made visible at the same time. Signed-off-by: Tejun Heo <tj@kernel.org> Reported-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru> Fixes: a5bca2152036 ("cgroup: factor out cgroup_create() out of cgroup_mkdir()") Cc: stable@vger.kernel.org # v4.6+
Diffstat (limited to 'tools/testing/selftests/timers/nsleep-lat.c')