#define _GNU_SOURCE #include #include #include #include #include #include #include #include #include #include "linux/ptrace.h" static int sys_rt_sigqueueinfo(pid_t tgid, int sig, siginfo_t *uinfo) { return syscall(SYS_rt_sigqueueinfo, tgid, sig, uinfo); } static int sys_rt_tgsigqueueinfo(pid_t tgid, pid_t tid, int sig, siginfo_t *uinfo) { return syscall(SYS_rt_tgsigqueueinfo, tgid, tid, sig, uinfo); } static int sys_ptrace(int request, pid_t pid, void *addr, void *data) { return syscall(SYS_ptrace, request, pid, addr, data); } #define SIGNR 10 #define TEST_SICODE_PRIV -1 #define TEST_SICODE_SHARE -2 #ifndef PAGE_SIZE #define PAGE_SIZE sysconf(_SC_PAGESIZE) #endif #define err(fmt, ...) \ fprintf(stderr, \ "Error (%s:%d): " fmt, \ __FILE__, __LINE__, ##__VA_ARGS__) static int check_error_paths(pid_t child) { struct ptrace_peeksiginfo_args arg; int ret, exit_code = -1; void *addr_rw, *addr_ro; /* * Allocate two contiguous pages. The first one is for read-write, * another is for read-only. */ addr_rw = mmap(NULL, 2 * PAGE_SIZE, PROT_READ | PROT_WRITE, MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); if (addr_rw == MAP_FAILED) { err("mmap() failed: %m\n"); return 1; } addr_ro = mmap(addr_rw + PAGE_SIZE, PAGE_SIZE, PROT_READ, MAP_PRIVATE | MAP_ANONYMOUS | MAP_FIXED, -1, 0); if (addr_ro == MAP_FAILED) { err("mmap() failed: %m\n"); goto out; } arg.nr = SIGNR; arg.off = 0; /* Unsupported flags */ arg.flags = ~0; ret = sys_ptrace(PTRACE_PEEKSIGINFO, child, &arg, addr_rw); if (ret != -1 || errno != EINVAL) { err("sys_ptrace() returns %d (expected -1)," " errno %d (expected %d): %m\n", ret, errno, EINVAL); goto out; } arg.flags = 0; /* A part of the buffer is read-only */ ret = sys_ptrace(PTRACE_PEEKSIGINFO, child, &arg, addr_ro - sizeof(siginfo_t) * 2); if (ret != 2) { err("sys_ptrace() returns %d (expected 2): %m\n", ret); goto out; } /* Read-only buffer */ ret = sys_ptrace(PTRACE_PEEKSIGINFO, child, &arg, addr_ro); if (ret != -1 && errno != EFAULT) { err("sys_ptrace() returns %d (expected -1)," " errno %d (expected %d): %m\n", ret, errno, EFAULT); goto out; } exit_code = 0; out: munmap(addr_rw, 2 * PAGE_SIZE); return exit_code; } int check_direct_path(pid_t child, int shared, int nr) { struct ptrace_peeksiginfo_args arg = {.flags = 0, .nr = nr, .off = 0}; int i, j, ret, exit_code = -1; siginfo_t siginfo[SIGNR]; int si_code; if (shared == 1) { arg.flags = PTRACE_PEEKSIGINFO_SHARED; si_code = TEST_SICODE_SHARE; } else { arg.flags = 0; si_code = TEST_SICODE_PRIV; } for (i = 0; i < SIGNR; ) { arg.off = i; ret = sys_ptrace(PTRACE_PEEKSIGINFO, child, &arg, siginfo); if (ret == -1) { err("ptrace() failed: %m\n"); goto out; } if (ret == 0) break; for (j = 0; j < ret; j++, i++) { if (siginfo[j].si_code == si_code && siginfo[j].si_int == i) continue; err("%d: Wrong siginfo i=%d si_code=%d si_int=%d\n", shared, i, siginfo[j].si_code, siginfo[j].si_int); goto out; } } if (i != SIGNR) { err("Only %d signals were read\n", i); goto out; } exit_code = 0; out: return exit_code; } int main(int argc, char *argv[]) { siginfo_t siginfo[SIGNR]; int i, exit_code = 1; sigset_t blockmask; pid_t child; sigemptyset(&blockmask); sigaddset(&blockmask, SIGRTMIN); sigprocmask(SIG_BLOCK, &blockmask, NULL); child = fork(); if (child == -1) { err("fork() failed: %m"); return 1; } else if (child == 0) { pid_t ppid = getppid(); while (1) { if (ppid != getppid()) break; sleep(1); } return 1; } /* Send signals in process-wide and per-thread queues */ for (i = 0; i < SIGNR; i++) { siginfo->si_code = TEST_SICODE_SHARE; siginfo->si_int = i; sys_rt_sigqueueinfo(child, SIGRTMIN, siginfo); siginfo->si_code = TEST_SICODE_PRIV; siginfo->si_int = i; sys_rt_tgsigqueueinfo(child, child, SIGRTMIN, siginfo); } if (sys_ptrace(PTRACE_ATTACH, child, NULL, NULL) == -1) return 1; waitpid(child, NULL, 0); /* Dump signals one by one*/ if (check_direct_path(child, 0, 1)) goto out; /* Dump all signals for one call */ if (check_direct_path(child, 0, SIGNR)) goto out; /* * Dump signal from the process-wide queue. * The number of signals is not multible to the buffer size */ if (check_direct_path(child, 1, 3)) goto out; if (check_error_paths(child)) goto out; printf("PASS\n"); exit_code = 0; out: if (sys_ptrace(PTRACE_KILL, child, NULL, NULL) == -1) return 1; waitpid(child, NULL, 0); return exit_code; } alue='0' selected='selected'>unified
authorThomas Gleixner <tglx@linutronix.de>2017-01-31 23:58:38 +0100
committerIngo Molnar <mingo@kernel.org>2017-02-01 08:37:27 +0100
commitdd86e373e09fb16b83e8adf5c48c421a4ca76468 (patch)
tree55703c2ea8584e303e342090614e0aab3509ab21 /net/nfc/nci/data.c
parent0b3589be9b98994ce3d5aeca52445d1f5627c4ba (diff)
perf/x86/intel/rapl: Make package handling more robust
The package management code in RAPL relies on package mapping being available before a CPU is started. This changed with: 9d85eb9119f4 ("x86/smpboot: Make logical package management more robust") because the ACPI/BIOS information turned out to be unreliable, but that left RAPL in broken state. This was not noticed because on a regular boot all CPUs are online before RAPL is initialized. A possible fix would be to reintroduce the mess which allocates a package data structure in CPU prepare and when it turns out to already exist in starting throw it away later in the CPU online callback. But that's a horrible hack and not required at all because RAPL becomes functional for perf only in the CPU online callback. That's correct because user space is not yet informed about the CPU being onlined, so nothing caan rely on RAPL being available on that particular CPU. Move the allocation to the CPU online callback and simplify the hotplug handling. At this point the package mapping is established and correct. This also adds a missing check for available package data in the event_init() function. Reported-by: Yasuaki Ishimatsu <yasu.isimatu@gmail.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Sebastian Siewior <bigeasy@linutronix.de> Cc: Stephane Eranian <eranian@google.com> Cc: Vince Weaver <vincent.weaver@maine.edu> Fixes: 9d85eb9119f4 ("x86/smpboot: Make logical package management more robust") Link: http://lkml.kernel.org/r/20170131230141.212593966@linutronix.de Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'net/nfc/nci/data.c')