/* * sync / sw_sync abstraction * Copyright 2015-2016 Collabora Ltd. * * Based on the implementation from the Android Open Source Project, * * Copyright 2012 Google, Inc * * Permission is hereby granted, free of charge, to any person obtaining a * copy of this software and associated documentation files (the "Software"), * to deal in the Software without restriction, including without limitation * the rights to use, copy, modify, merge, publish, distribute, sublicense, * and/or sell copies of the Software, and to permit persons to whom the * Software is furnished to do so, subject to the following conditions: * * The above copyright notice and this permission notice shall be included in * all copies or substantial portions of the Software. * * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR * OTHER DEALINGS IN THE SOFTWARE. */ #include #include #include #include #include #include #include #include #include #include "sync.h" #include "sw_sync.h" #include /* SW_SYNC ioctls */ struct sw_sync_create_fence_data { __u32 value; char name[32]; __s32 fence; }; #define SW_SYNC_IOC_MAGIC 'W' #define SW_SYNC_IOC_CREATE_FENCE _IOWR(SW_SYNC_IOC_MAGIC, 0,\ struct sw_sync_create_fence_data) #define SW_SYNC_IOC_INC _IOW(SW_SYNC_IOC_MAGIC, 1, __u32) int sync_wait(int fd, int timeout) { struct pollfd fds; fds.fd = fd; fds.events = POLLIN | POLLERR; return poll(&fds, 1, timeout); } int sync_merge(const char *name, int fd1, int fd2) { struct sync_merge_data data = {}; int err; data.fd2 = fd2; strncpy(data.name, name, sizeof(data.name) - 1); data.name[sizeof(data.name) - 1] = '\0'; err = ioctl(fd1, SYNC_IOC_MERGE, &data); if (err < 0) return err; return data.fence; } static struct sync_file_info *sync_file_info(int fd) { struct sync_file_info *info; struct sync_fence_info *fence_info; int err, num_fences; info = calloc(1, sizeof(*info)); if (info == NULL) return NULL; err = ioctl(fd, SYNC_IOC_FILE_INFO, info); if (err < 0) { free(info); return NULL; } num_fences = info->num_fences; if (num_fences) { info->flags = 0; info->num_fences = num_fences; fence_info = calloc(num_fences, sizeof(*fence_info)); if (!fence_info) { free(info); return NULL; } info->sync_fence_info = (uint64_t)fence_info; err = ioctl(fd, SYNC_IOC_FILE_INFO, info); if (err < 0) { free(fence_info); free(info); return NULL; } } return info; } static void sync_file_info_free(struct sync_file_info *info) { free((void *)info->sync_fence_info); free(info); } int sync_fence_size(int fd) { int count; struct sync_file_info *info = sync_file_info(fd); if (!info) return 0; count = info->num_fences; sync_file_info_free(info); return count; } int sync_fence_count_with_status(int fd, int status) { unsigned int i, count = 0; struct sync_fence_info *fence_info = NULL; struct sync_file_info *info = sync_file_info(fd); if (!info) return -1; fence_info = (struct sync_fence_info *)info->sync_fence_info; for (i = 0 ; i < info->num_fences ; i++) { if (fence_info[i].status == status) count++; } sync_file_info_free(info); return count; } int sw_sync_timeline_create(void) { return open("/sys/kernel/debug/sync/sw_sync", O_RDWR); } int sw_sync_timeline_inc(int fd, unsigned int count) { __u32 arg = count; return ioctl(fd, SW_SYNC_IOC_INC, &arg); } int sw_sync_timeline_is_valid(int fd) { int status; if (fd == -1) return 0; status = fcntl(fd, F_GETFD, 0); return (status >= 0); } void sw_sync_timeline_destroy(int fd) { if (sw_sync_timeline_is_valid(fd)) close(fd); } int sw_sync_fence_create(int fd, const char *name, unsigned int value) { struct sw_sync_create_fence_data data = {}; int err; data.value = value; strncpy(data.name, name, sizeof(data.name) - 1); data.name[sizeof(data.name) - 1] = '\0'; err = ioctl(fd, SW_SYNC_IOC_CREATE_FENCE, &data); if (err < 0) return err; return data.fence; } int sw_sync_fence_is_valid(int fd) { /* Same code! */ return sw_sync_timeline_is_valid(fd); } void sw_sync_fence_destroy(int fd) { if (sw_sync_fence_is_valid(fd)) close(fd); } ed'>unified
authorLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
commit39cb2c9a316e77f6dfba96c543e55b6672d5a37e (patch)
tree98fe974ee4e20121253de7f61fc8d01bdb3821c1 /sound/soc/intel/atom/sst/sst.c
parent2c5d9555d6d937966d79d4c6529a5f7b9206e405 (diff)
drm/i915: Check for NULL i915_vma in intel_unpin_fb_obj()
I've seen this trigger twice now, where the i915_gem_object_to_ggtt() call in intel_unpin_fb_obj() returns NULL, resulting in an oops immediately afterwards as the (inlined) call to i915_vma_unpin_fence() tries to dereference it. It seems to be some race condition where the object is going away at shutdown time, since both times happened when shutting down the X server. The call chains were different: - VT ioctl(KDSETMODE, KD_TEXT): intel_cleanup_plane_fb+0x5b/0xa0 [i915] drm_atomic_helper_cleanup_planes+0x6f/0x90 [drm_kms_helper] intel_atomic_commit_tail+0x749/0xfe0 [i915] intel_atomic_commit+0x3cb/0x4f0 [i915] drm_atomic_commit+0x4b/0x50 [drm] restore_fbdev_mode+0x14c/0x2a0 [drm_kms_helper] drm_fb_helper_restore_fbdev_mode_unlocked+0x34/0x80 [drm_kms_helper] drm_fb_helper_set_par+0x2d/0x60 [drm_kms_helper] intel_fbdev_set_par+0x18/0x70 [i915] fb_set_var+0x236/0x460 fbcon_blank+0x30f/0x350 do_unblank_screen+0xd2/0x1a0 vt_ioctl+0x507/0x12a0 tty_ioctl+0x355/0xc30 do_vfs_ioctl+0xa3/0x5e0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x13/0x94 - i915 unpin_work workqueue: intel_unpin_work_fn+0x58/0x140 [i915] process_one_work+0x1f1/0x480 worker_thread+0x48/0x4d0 kthread+0x101/0x140 and this patch purely papers over the issue by adding a NULL pointer check and a WARN_ON_ONCE() to avoid the oops that would then generally make the machine unresponsive. Other callers of i915_gem_object_to_ggtt() seem to also check for the returned pointer being NULL and warn about it, so this clearly has happened before in other places. [ Reported it originally to the i915 developers on Jan 8, applying the ugly workaround on my own now after triggering the problem for the second time with no feedback. This is likely to be the same bug reported as https://bugs.freedesktop.org/show_bug.cgi?id=98829 https://bugs.freedesktop.org/show_bug.cgi?id=99134 which has a patch for the underlying problem, but it hasn't gotten to me, so I'm applying the workaround. ] Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'sound/soc/intel/atom/sst/sst.c')