/* * Read/write thread of a guest agent for virtio-trace * * Copyright (C) 2012 Hitachi, Ltd. * Created by Yoshihiro Yunomae * Masami Hiramatsu * * Licensed under GPL version 2 only. * */ #define _GNU_SOURCE #include #include #include #include #include #include "trace-agent.h" #define READ_WAIT_USEC 100000 void *rw_thread_info_new(void) { struct rw_thread_info *rw_ti; rw_ti = zalloc(sizeof(struct rw_thread_info)); if (rw_ti == NULL) { pr_err("rw_thread_info zalloc error\n"); exit(EXIT_FAILURE); } rw_ti->cpu_num = -1; rw_ti->in_fd = -1; rw_ti->out_fd = -1; rw_ti->read_pipe = -1; rw_ti->write_pipe = -1; rw_ti->pipe_size = PIPE_INIT; return rw_ti; } void *rw_thread_init(int cpu, const char *in_path, const char *out_path, bool stdout_flag, unsigned long pipe_size, struct rw_thread_info *rw_ti) { int data_pipe[2]; rw_ti->cpu_num = cpu; /* set read(input) fd */ rw_ti->in_fd = open(in_path, O_RDONLY); if (rw_ti->in_fd == -1) { pr_err("Could not open in_fd (CPU:%d)\n", cpu); goto error; } /* set write(output) fd */ if (!stdout_flag) { /* virtio-serial output mode */ rw_ti->out_fd = open(out_path, O_WRONLY); if (rw_ti->out_fd == -1) { pr_err("Could not open out_fd (CPU:%d)\n", cpu); goto error; } } else /* stdout mode */ rw_ti->out_fd = STDOUT_FILENO; if (pipe2(data_pipe, O_NONBLOCK) < 0) { pr_err("Could not create pipe in rw-thread(%d)\n", cpu); goto error; } /* * Size of pipe is 64kB in default based on fs/pipe.c. * To read/write trace data speedy, pipe size is changed. */ if (fcntl(*data_pipe, F_SETPIPE_SZ, pipe_size) < 0) { pr_err("Could not change pipe size in rw-thread(%d)\n", cpu); goto error; } rw_ti->read_pipe = data_pipe[1]; rw_ti->write_pipe = data_pipe[0]; rw_ti->pipe_size = pipe_size; return NULL; error: exit(EXIT_FAILURE); } /* Bind a thread to a cpu */ static void bind_cpu(int cpu_num) { cpu_set_t mask; CPU_ZERO(&mask); CPU_SET(cpu_num, &mask); /* bind my thread to cpu_num by assigning zero to the first argument */ if (sched_setaffinity(0, sizeof(mask), &mask) == -1) pr_err("Could not set CPU#%d affinity\n", (int)cpu_num); } static void *rw_thread_main(void *thread_info) { ssize_t rlen, wlen; ssize_t ret; struct rw_thread_info *ts = (struct rw_thread_info *)thread_info; bind_cpu(ts->cpu_num); while (1) { /* Wait for a read order of trace data by Host OS */ if (!global_run_operation) { pthread_mutex_lock(&mutex_notify); pthread_cond_wait(&cond_wakeup, &mutex_notify); pthread_mutex_unlock(&mutex_notify); } if (global_sig_receive) break; /* * Each thread read trace_pipe_raw of each cpu bounding the * thread, so contention of multi-threads does not occur. */ rlen = splice(ts->in_fd, NULL, ts->read_pipe, NULL, ts->pipe_size, SPLICE_F_MOVE | SPLICE_F_MORE); if (rlen < 0) { pr_err("Splice_read in rw-thread(%d)\n", ts->cpu_num); goto error; } else if (rlen == 0) { /* * If trace data do not exist or are unreadable not * for exceeding the page size, splice_read returns * NULL. Then, this waits for being filled the data in a * ring-buffer. */ usleep(READ_WAIT_USEC); pr_debug("Read retry(cpu:%d)\n", ts->cpu_num); continue; } wlen = 0; do { ret = splice(ts->write_pipe, NULL, ts->out_fd, NULL, rlen - wlen, SPLICE_F_MOVE | SPLICE_F_MORE); if (ret < 0) { pr_err("Splice_write in rw-thread(%d)\n", ts->cpu_num); goto error; } else if (ret == 0) /* * When host reader is not in time for reading * trace data, guest will be stopped. This is * because char dev in QEMU is not supported * non-blocking mode. Then, writer might be * sleep in that case. * This sleep will be removed by supporting * non-blocking mode. */ sleep(1); wlen += ret; } while (wlen < rlen); } return NULL; error: exit(EXIT_FAILURE); } pthread_t rw_thread_run(struct rw_thread_info *rw_ti) { int ret; pthread_t rw_thread_per_cpu; ret = pthread_create(&rw_thread_per_cpu, NULL, rw_thread_main, rw_ti); if (ret != 0) { pr_err("Could not create a rw thread(%d)\n", rw_ti->cpu_num); exit(EXIT_FAILURE); } return rw_thread_per_cpu; } ted'>includemode:
authorGreg Kurz <groug@kaod.org>2017-01-24 17:50:26 +0100
committerAlex Williamson <alex.williamson@redhat.com>2017-01-24 10:12:04 -0700
commitbd00fdf198e2da475a2f4265a83686ab42d998a8 (patch)
tree55d55cea56a56eb2b1d4ffdef7ce7f3b37fd8434 /sound/pci/au88x0
parent7a308bb3016f57e5be11a677d15b821536419d36 (diff)
vfio/spapr: fail tce_iommu_attach_group() when iommu_data is null
The recently added mediated VFIO driver doesn't know about powerpc iommu. It thus doesn't register a struct iommu_table_group in the iommu group upon device creation. The iommu_data pointer hence remains null. This causes a kernel oops when userspace tries to set the iommu type of a container associated with a mediated device to VFIO_SPAPR_TCE_v2_IOMMU. [ 82.585440] mtty mtty: MDEV: Registered [ 87.655522] iommu: Adding device 83b8f4f2-509f-382f-3c1e-e6bfe0fa1001 to group 10 [ 87.655527] vfio_mdev 83b8f4f2-509f-382f-3c1e-e6bfe0fa1001: MDEV: group_id = 10 [ 116.297184] Unable to handle kernel paging request for data at address 0x00000030 [ 116.297389] Faulting instruction address: 0xd000000007870524 [ 116.297465] Oops: Kernel access of bad area, sig: 11 [#1] [ 116.297611] SMP NR_CPUS=2048 [ 116.297611] NUMA [ 116.297627] PowerNV ... [ 116.297954] CPU: 33 PID: 7067 Comm: qemu-system-ppc Not tainted 4.10.0-rc5-mdev-test #8 [ 116.297993] task: c000000e7718b680 task.stack: c000000e77214000 [ 116.298025] NIP: d000000007870524 LR: d000000007870518 CTR: 0000000000000000 [ 116.298064] REGS: c000000e77217990 TRAP: 0300 Not tainted (4.10.0-rc5-mdev-test) [ 116.298103] MSR: 9000000000009033 <SF,HV,EE,ME,IR,DR,RI,LE> [ 116.298107] CR: 84004444 XER: 00000000 [ 116.298154] CFAR: c00000000000888c DAR: 0000000000000030 DSISR: 40000000 SOFTE: 1 GPR00: d000000007870518 c000000e77217c10 d00000000787b0ed c000000eed2103c0 GPR04: 0000000000000000 0000000000000000 c000000eed2103e0 0000000f24320000 GPR08: 0000000000000104 0000000000000001 0000000000000000 d0000000078729b0 GPR12: c00000000025b7e0 c00000000fe08400 0000000000000001 000001002d31d100 GPR16: 000001002c22c850 00003ffff315c750 0000000043145680 0000000043141bc0 GPR20: ffffffffffffffed fffffffffffff000 0000000020003b65 d000000007706018 GPR24: c000000f16cf0d98 d000000007706000 c000000003f42980 c000000003f42980 GPR28: c000000f1575ac00 c000000003f429c8 0000000000000000 c000000eed2103c0 [ 116.298504] NIP [d000000007870524] tce_iommu_attach_group+0x10c/0x360 [vfio_iommu_spapr_tce] [ 116.298555] LR [d000000007870518] tce_iommu_attach_group+0x100/0x360 [vfio_iommu_spapr_tce] [ 116.298601] Call Trace: [ 116.298610] [c000000e77217c10] [d000000007870518] tce_iommu_attach_group+0x100/0x360 [vfio_iommu_spapr_tce] (unreliable) [ 116.298671] [c000000e77217cb0] [d0000000077033a0] vfio_fops_unl_ioctl+0x278/0x3e0 [vfio] [ 116.298713] [c000000e77217d40] [c0000000002a3ebc] do_vfs_ioctl+0xcc/0x8b0 [ 116.298745] [c000000e77217de0] [c0000000002a4700] SyS_ioctl+0x60/0xc0 [ 116.298782] [c000000e77217e30] [c00000000000b220] system_call+0x38/0xfc [ 116.298812] Instruction dump: [ 116.298828] 7d3f4b78 409effc8 3d220000 e9298020 3c800140 38a00018 608480c0 e8690028 [ 116.298869] 4800249d e8410018 7c7f1b79 41820230 <e93e0030> 2fa90000 419e0114 e9090020 [ 116.298914] ---[ end trace 1e10b0ced08b9120 ]--- This patch fixes the oops. Reported-by: Vaibhav Jain <vaibhav@linux.vnet.ibm.com> Signed-off-by: Greg Kurz <groug@kaod.org> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Diffstat (limited to 'sound/pci/au88x0')