summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTobias Klauser <tklauser@distanz.ch>2013-05-16 23:00:29 +0200
committerTobias Klauser <tklauser@distanz.ch>2013-05-16 23:00:29 +0200
commitac31518c8c8af043d157b294d99177b86f0bccd7 (patch)
tree60fe5afcefb89f8e3139dd35fa814ed35a4ffd3d
parentffc523fc240e072e924b042b19f11c5930b1397d (diff)
dissector: igmp: Fix another erroneous null pointer check
We need to break if we get NULL from pkt_pull() but the actual check was inverted. This was discovered by the coverity scanner and missed in commit b76adfd1 ("dissector: igmp: Fix erroneous null pointer check"). Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
-rw-r--r--proto_igmp.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/proto_igmp.c b/proto_igmp.c
index 6869fa6..f071f6c 100644
--- a/proto_igmp.c
+++ b/proto_igmp.c
@@ -435,7 +435,7 @@ static void dissect_igmp_v3_membership_report(struct pkt_buff *pkt)
while (n--) {
src_addr = (uint32_t *)
pkt_pull(pkt, sizeof(*src_addr));
- if (src_addr != NULL)
+ if (src_addr == NULL)
break;
inet_ntop(AF_INET, src_addr, addr, sizeof(addr));
tprintf(", %s", addr);