diff options
author | Vadim Kochan <vadim4j@gmail.com> | 2015-03-31 12:29:58 +0300 |
---|---|---|
committer | Tobias Klauser <tklauser@distanz.ch> | 2015-03-31 17:28:49 +0200 |
commit | 48097ae5585c856ce676baa006dd018f86eda565 (patch) | |
tree | 0c3a47d2490a9a51fd09f40da2a99d7172faf7a0 | |
parent | 2d76b0b011d451eac6dd08645e5958a25c4b8944 (diff) |
trafgen: Alloc cpus according to specified number of packets
Trafgen uses all the online CPUs even if the number of packets specified
by -n is less than the number of selected CPUs. Such behaviour leads to
issues:
- trafgen re-calculates number of packets per CPU which
leads to rounding it to 0 then no packets will be sent.
- trafgen might send more packets than specified by -n because
of using all the online cpus.
Fixed by taking min(#CPUs, #packets) as the number of CPUs if a number
of packets is specified by -n.
Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
[tklauser: moved code and added explanatory comment]
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
-rw-r--r-- | trafgen.c | 8 |
1 files changed, 8 insertions, 0 deletions
@@ -1070,6 +1070,14 @@ int main(int argc, char **argv) sleep(0); } + /* + * If number of packets is smaller than number of CPUs use only as + * many CPUs as there are packets. Otherwise we end up sending more + * packets than intended or none at all. + */ + if (ctx.num) + ctx.cpus = min_t(unsigned int, ctx.num, ctx.cpus); + irq = device_irq_number(ctx.device); if (set_irq_aff) device_set_irq_affinity_list(irq, 0, ctx.cpus - 1); |