summaryrefslogtreecommitdiff
path: root/CodingStyle
diff options
context:
space:
mode:
authorDaniel Borkmann <dborkman@redhat.com>2013-07-12 10:52:07 +0200
committerDaniel Borkmann <dborkman@redhat.com>2013-07-12 10:52:07 +0200
commit138f28aaafc3bd3087efbc25f49f752c66d14157 (patch)
treea2f83cbb692fc020ee1eb71379c94901989b8ff6 /CodingStyle
parent8f92276156b1fbdeebd085b731ed4aeab3960432 (diff)
configure: do not use bash's expr match
It looks like there are some incompatibilities in bash's expr match among different versions. Using set -x, gives us on bash 4.2.45: + TOOLS=' netsniff-ng trafgen ifpps bpfc' + for tool in '$_tools' + case "$tool" in ++ expr match '"curvetun' 'astraceroute"' '$1' expr: syntax error + m= + '[' '' == 0 ']' So rather avoid using "expr match" and switch to "case" for substring matching, which should be more portable. Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Diffstat (limited to 'CodingStyle')
0 files changed, 0 insertions, 0 deletions
eae0d781f72a6d30545e17'>diff)
netfilter: nf_tables: Eliminate duplicated code in nf_tables_table_enable()
If something fails in nf_tables_table_enable(), it unregisters the chains. But the rollback code is the same as nf_tables_table_disable() almostly, except there is one counter check. Now create one wrapper function to eliminate the duplicated codes. Signed-off-by: Feng <fgao@ikuai8.com> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'include/net/netfilter/nf_conntrack_seqadj.h')