summaryrefslogtreecommitdiff
path: root/astraceroute/.gitignore
diff options
context:
space:
mode:
authorTobias Klauser <tklauser@distanz.ch>2013-05-12 13:52:12 +0200
committerTobias Klauser <tklauser@distanz.ch>2013-05-12 13:52:12 +0200
commitb76adfd12a21676abb82e9f1ebe134510d9a4766 (patch)
treef096abe714209b3d61dbe65acc1179f97b582d86 /astraceroute/.gitignore
parent06d60f51149ef960110431b228828c7bbc84e74c (diff)
dissector: igmp: Fix erroneous null pointer check
We need to break if we get NULL from pkt_pull() but the actual check was inverted. This was discovered by the coverity scanner. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Diffstat (limited to 'astraceroute/.gitignore')
0 files changed, 0 insertions, 0 deletions
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-12-04 23:33:44 +0000
on `pch->work_list' under lock `pl330->lock', whereas in the rest of the code `pch->work_list' is protected by `pch->lock'. I don't know if this may cause race conditions. Similarly `pch->cyclic' is written by `pl330_alloc_chan_resources' under `pl330->lock' but read by `pl330_tx_submit' under `pch->lock'. Second, I have removed locking from `pl330_request_channel' and `pl330_release_channel' functions. Function `pl330_request_channel' is only called from `pl330_alloc_chan_resources', so the lock is already held. Function `pl330_release_channel' is called from `pl330_free_chan_resources', which already holds the lock, and from `pl330_del'. Function `pl330_del' is called in an error path of `pl330_probe' and at the end of `pl330_remove', but I assume that there cannot be concurrent accesses to the protected data at those points. Signed-off-by: Iago Abal <mail@iagoabal.eu> Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'net/batman-adv')