docs: authors: Move Vadim to major contributors - netsniff-ng.git - A high-performance Linux networking toolkit

diff options

author	Tobias Klauser <tklauser@distanz.ch>	2015-05-05 12:00:48 +0200
committer	Tobias Klauser <tklauser@distanz.ch>	2015-05-05 12:00:48 +0200
commit	67e0574edb3c6919382ff96da1bcd800f9bfe45e (patch)
tree	e2ca93c127b5d06b9db61b4de7da95cad2a0feee /astraceroute
parent	0757f825dd4b0e3653a98264bbe3933d54b3c1ef (diff)

docs: authors: Move Vadim to major contributors

Vadim has contributed numerous improvements and bug fixes for netsniff-ng and hopefully continues to do so. Move him to the major contributors section in the AUTHORS file. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>

Diffstat (limited to 'astraceroute')

0 files changed, 0 insertions, 0 deletions

function `dma_pl330_rqcb' in line 1753; 4. spin_lock_irqsave(pch->lock, flags) at dma_pl330_rqcb:1505. I have fixed it as suggested by Marek Szyprowski. First, I have replaced `pch->lock' with `pl330->lock' in functions `pl330_alloc_chan_resources' and `pl330_free_chan_resources'. This avoids the double-lock by acquiring a different lock than `dma_pl330_rqcb'. NOTE that, as a result, `pl330_free_chan_resources' executes `list_splice_tail_init' on `pch->work_list' under lock `pl330->lock', whereas in the rest of the code `pch->work_list' is protected by `pch->lock'. I don't know if this may cause race conditions. Similarly `pch->cyclic' is written by `pl330_alloc_chan_resources' under `pl330->lock' but read by `pl330_tx_submit' under `pch->lock'. Second, I have removed locking from `pl330_request_channel' and `pl330_release_channel' functions. Function `pl330_request_channel' is only called from `pl330_alloc_chan_resources', so the lock is already held. Function `pl330_release_channel' is called from `pl330_free_chan_resources', which already holds the lock, and from `pl330_del'. Function `pl330_del' is called in an error path of `pl330_probe' and at the end of `pl330_remove', but I assume that there cannot be concurrent accesses to the protected data at those points. Signed-off-by: Iago Abal <mail@iagoabal.eu> Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>

Diffstat (limited to 'tools/lib/api')


context:
space:
mode: