summaryrefslogtreecommitdiff
path: root/bpf_parser.y
diff options
context:
space:
mode:
authorTobias Klauser <tklauser@distanz.ch>2013-05-16 23:00:29 +0200
committerTobias Klauser <tklauser@distanz.ch>2013-05-16 23:00:29 +0200
commitac31518c8c8af043d157b294d99177b86f0bccd7 (patch)
tree60fe5afcefb89f8e3139dd35fa814ed35a4ffd3d /bpf_parser.y
parentffc523fc240e072e924b042b19f11c5930b1397d (diff)
dissector: igmp: Fix another erroneous null pointer check
We need to break if we get NULL from pkt_pull() but the actual check was inverted. This was discovered by the coverity scanner and missed in commit b76adfd1 ("dissector: igmp: Fix erroneous null pointer check"). Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Diffstat (limited to 'bpf_parser.y')
0 files changed, 0 insertions, 0 deletions
can_shift_osds(pi)) 2090 continue; 2091 2092 temp->osds[temp->size++] = CRUSH_ITEM_NONE; and so requests get directed to the second OSD in the set instead of the first, resulting in OSD-side errors like: [WRN] : client.4239 192.168.122.21:0/2444980242 misdirected client.4239.1:2827 pg 2.5df899f2 to osd.4 not [1,4,6] in e680/680 and hung rbds on the client: [ 493.566367] rbd: rbd0: write 400000 at 11cc00000 (0) [ 493.566805] rbd: rbd0: result -6 xferred 400000 [ 493.567011] blk_update_request: I/O error, dev rbd0, sector 9330688 The fix is to decouple application from the decoding and: - apply new_weight first - apply new_state before new_up_client - twiddle osd_state flags if marking in - clear out some of the state if osd is destroyed Fixes: http://tracker.ceph.com/issues/14901 Cc: stable@vger.kernel.org # 3.15+: 6dd74e44dc1d: libceph: set 'exists' flag for newly up osd Cc: stable@vger.kernel.org # 3.15+ Signed-off-by: Ilya Dryomov <idryomov@gmail.com> Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Diffstat (limited to 'Documentation/devicetree')