summaryrefslogtreecommitdiff
path: root/colors.h
diff options
context:
space:
mode:
authorDaniel Borkmann <dborkman@redhat.com>2013-03-16 13:43:16 +0100
committerDaniel Borkmann <dborkman@redhat.com>2013-03-16 13:43:16 +0100
commitc69b4960fa4f48fcc7bd320bc34e4fc8de613bdc (patch)
tree0416dff0bb17c4fdbbc789bbed7243f957e8a213 /colors.h
parent30e1aafbae487e63a1f1f294391bbdc993808c4b (diff)
geoip: reorder statements, so that file handles are closed first
Coverty detected, when we are in an error condition, we do not close file handles, but just return instead. Thus, reorder statements, so that file handles are closed for sure. Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Diffstat (limited to 'colors.h')
0 files changed, 0 insertions, 0 deletions
incorrectly onlined subsystems before the new cgroup is associated with it kernfs_node. This is fine for cgroup proper but cgroup_name/path() depend on the associated kernfs_node and if a subsystem makes the new cgroup_subsys_state visible, which they're allowed to after onlining, it can lead to NULL dereference. The current code performs cgroup creation and subsystem onlining in cgroup_create() and cgroup_mkdir() makes the cgroup and subsystems visible afterwards. There's no reason to online the subsystems early and we can simply drop cgroup_apply_control_enable() call from cgroup_create() so that the subsystems are onlined and made visible at the same time. Signed-off-by: Tejun Heo <tj@kernel.org> Reported-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru> Fixes: a5bca2152036 ("cgroup: factor out cgroup_create() out of cgroup_mkdir()") Cc: stable@vger.kernel.org # v4.6+
Diffstat (limited to 'net/ipv6/xfrm6_output.c')