diff options
author | Tobias Klauser <tklauser@distanz.ch> | 2013-03-19 10:58:21 +0100 |
---|---|---|
committer | Tobias Klauser <tklauser@distanz.ch> | 2013-03-19 10:58:21 +0100 |
commit | e4c98bb91e35dba56a077e8e5b9c70556fdd4e24 (patch) | |
tree | e7469f9f3f96cd19779d6dc48f60e0d4b9ead3b2 /curvetun.c | |
parent | 0a021ca83742e2da23041c3fee602ba861dea6bb (diff) |
curvetun: Only close() file descriptor if open
Only attempt to close the file descriptor in error cases where it is
actually open.
This was discovered by the coverity scanner.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Diffstat (limited to 'curvetun.c')
-rw-r--r-- | curvetun.c | 6 |
1 files changed, 3 insertions, 3 deletions
@@ -280,7 +280,7 @@ static void create_keypair(char *home) if (fd < 0) { err = EIO; errstr = "Cannot open pubkey file!\n"; - goto out; + goto out_noclose; } ret = write(fd, publickey, sizeof(publickey)); @@ -301,7 +301,7 @@ static void create_keypair(char *home) if (fd < 0) { err = EIO; errstr = "Cannot open privkey file!\n"; - goto out; + goto out_noclose; } ret = write(fd, secretkey, sizeof(secretkey)); @@ -312,7 +312,7 @@ static void create_keypair(char *home) } out: close(fd); - +out_noclose: xmemset(publickey, 0, sizeof(publickey)); xmemset(secretkey, 0, sizeof(secretkey)); |