summaryrefslogtreecommitdiff
path: root/locking.h
diff options
context:
space:
mode:
authorTobias Klauser <tklauser@distanz.ch>2013-08-21 10:28:27 +0200
committerTobias Klauser <tklauser@distanz.ch>2013-08-21 10:28:27 +0200
commit6d651c88488fc04e71c25bafab2a5af18195508f (patch)
tree38a6a85e577b2d7332a06672733370d3c49d04b6 /locking.h
parent74a4979266860005c0013cdc86208be204cddd1d (diff)
netsniff-ng 0.5.8-rc3v0.5.8-rc3
Signed-off-by: Daniel Borkmann <dborkman@redhat.com> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Diffstat (limited to 'locking.h')
0 files changed, 0 insertions, 0 deletions
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-11-15 23:50:24 +0000
_free_chan_resources' executes `list_splice_tail_init' on `pch->work_list' under lock `pl330->lock', whereas in the rest of the code `pch->work_list' is protected by `pch->lock'. I don't know if this may cause race conditions. Similarly `pch->cyclic' is written by `pl330_alloc_chan_resources' under `pl330->lock' but read by `pl330_tx_submit' under `pch->lock'. Second, I have removed locking from `pl330_request_channel' and `pl330_release_channel' functions. Function `pl330_request_channel' is only called from `pl330_alloc_chan_resources', so the lock is already held. Function `pl330_release_channel' is called from `pl330_free_chan_resources', which already holds the lock, and from `pl330_del'. Function `pl330_del' is called in an error path of `pl330_probe' and at the end of `pl330_remove', but I assume that there cannot be concurrent accesses to the protected data at those points. Signed-off-by: Iago Abal <mail@iagoabal.eu> Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'tools/leds/Makefile')