summaryrefslogtreecommitdiff
path: root/trafgen.8
diff options
context:
space:
mode:
authorDaniel Borkmann <dborkman@redhat.com>2013-06-04 12:01:56 +0200
committerDaniel Borkmann <dborkman@redhat.com>2013-06-04 12:01:56 +0200
commit7ea4576392b014490e6308ad82d695cc85a0b8bd (patch)
tree82b2c8d497acfa9c2b1e8f3d75f1153d00583a62 /trafgen.8
parentb1d59d3eda7ee4f09b30f807d72aac2af58409ac (diff)
rnd: move entropy source definition to rnd
It's better off there anyway. Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Diffstat (limited to 'trafgen.8')
0 files changed, 0 insertions, 0 deletions
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-12-04 12:27:22 +0000
ock
The static bug finder EBA (http://www.iagoabal.eu/eba/) reported the following double-lock bug: Double lock: 1. spin_lock_irqsave(pch->lock, flags) at pl330_free_chan_resources:2236; 2. call to function `pl330_release_channel' immediately after; 3. call to function `dma_pl330_rqcb' in line 1753; 4. spin_lock_irqsave(pch->lock, flags) at dma_pl330_rqcb:1505. I have fixed it as suggested by Marek Szyprowski. First, I have replaced `pch->lock' with `pl330->lock' in functions `pl330_alloc_chan_resources' and `pl330_free_chan_resources'. This avoids the double-lock by acquiring a different lock than `dma_pl330_rqcb'. NOTE that, as a result, `pl330_free_chan_resources' executes `list_splice_tail_init' on `pch->work_list' under lock `pl330->lock', whereas in the rest of the code `pch->work_list' is protected by `pch->lock'. I don't know if this may cause race conditions. Similarly `pch->cyclic' is written by `pl330_alloc_chan_resources' under `pl330->lock' but read by `pl330_tx_submit' under `pch->lock'. Second, I have removed locking from `pl330_request_channel' and `pl330_release_channel' functions. Function `pl330_request_channel' is only called from `pl330_alloc_chan_resources', so the lock is already held. Function `pl330_release_channel' is called from `pl330_free_chan_resources', which already holds the lock, and from `pl330_del'. Function `pl330_del' is called in an error path of `pl330_probe' and at the end of `pl330_remove', but I assume that there cannot be concurrent accesses to the protected data at those points. Signed-off-by: Iago Abal <mail@iagoabal.eu> Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'include/xen/interface/memory.h')
a1f04a3f66aebbe8665a28d9cf0b5e3d1c6f9d'>ib_pma.h
5579logplain
-rw-r--r--ib_sa.h16914logplain
-rw-r--r--ib_smi.h5633logplain
-rw-r--r--ib_umem.h3577logplain
-rw-r--r--ib_umem_odp.h5300logplain
-rw-r--r--ib_verbs.h100225logplain
-rw-r--r--iw_cm.h8793logplain
-rw-r--r--iw_portmap.h7688logplain
-rw-r--r--mr_pool.h954logplain
-rw-r--r--opa_port_info.h15063logplain
-rw-r--r--opa_smi.h4417logplain