diff options
author | Paolo Abeni <pabeni@redhat.com> | 2017-12-14 13:04:12 +0100 |
---|---|---|
committer | Tobias Klauser <tklauser@distanz.ch> | 2017-12-14 15:45:08 +0100 |
commit | e207624c6d92e9c2979e1e310cab660f0320ca48 (patch) | |
tree | 7ebcbe0596dae05d2449a6a2d75c42658cda838e /trafgen_conf.h | |
parent | fe87d2b6117de1e32769b388fe1704440e339d27 (diff) |
trafgen: fix dinc()/ddec() modifiers
currently, after dinc(), the valued stored inside the packet is
not in the (min, max) range but in the (0, max - min + 1) range,
'counter->val' should be used instead of 'val'.
Additionally the values computed for ddec() are corrupted, in:
val = (val - counter->inc) % (counter->min - counter->max + 1);
the divider is negative, we should use (counter->max - counter->min + 1)
as in the INC case.
Finally we can avoid the switch statement at update time, inverting
the value of 'counter->inc' for decrement and using a data type wide
enough for the 'inc' field.
v1 -> v2:
- changed 'counter->inc' type to int
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Diffstat (limited to 'trafgen_conf.h')
-rw-r--r-- | trafgen_conf.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/trafgen_conf.h b/trafgen_conf.h index a0bbe43..fcbbb17 100644 --- a/trafgen_conf.h +++ b/trafgen_conf.h @@ -22,8 +22,8 @@ enum csum { }; struct counter { - int type; - uint8_t min, max, inc, val; + int type, inc; + uint8_t min, max, val; off_t off; }; |