trafgen: fix dinc()/ddec() modifiers

currently, after dinc(), the valued stored inside the packet is
not in the (min, max) range but in the (0, max - min + 1) range,
'counter->val' should be used instead of 'val'.

Additionally the values computed for ddec() are corrupted, in:

val = (val - counter->inc) % (counter->min - counter->max + 1);

the divider is negative, we should use (counter->max - counter->min + 1)
as in the INC case.

Finally we can avoid the switch statement at update time, inverting
the value of 'counter->inc' for decrement and using a data type wide
enough for the 'inc' field.

v1 -> v2:
 - changed 'counter->inc' type to int

Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>

1 files changed, 1 insertions, 1 deletions

diff --git a/trafgen_parser.y b/trafgen_parser.y
index a42dc30..4d83af6 100644
--- a/trafgen_parser.y
+++ b/trafgen_parser.y
@@ -147,7 +147,7 @@ static inline void __setup_new_counter(struct counter *c, uint8_t start,
 {
 	c->min = start;
 	c->max = stop;
-	c->inc = stepping;
+	c->inc = (type == TYPE_INC) ? stepping : -stepping;
 	c->val = (type == TYPE_INC) ? start : stop;
 	c->off = payload_last;
 	c->type = type;