summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--ioops.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/ioops.c b/ioops.c
index a5dc94a..7cec2fd 100644
--- a/ioops.c
+++ b/ioops.c
@@ -102,7 +102,7 @@ int read_blob_or_die(const char *file, void *blob, size_t count)
int fd, ret;
fd = open_or_die(file, O_RDONLY);
- ret = read_or_die(fd, blob, len);
+ ret = read_or_die(fd, blob, count);
close(fd);
return ret;
@@ -113,7 +113,7 @@ int write_blob_or_die(const char *file, const void *blob, size_t count)
int fd, ret;
fd = open_or_die_m(file, O_WRONLY | O_CREAT | O_TRUNC, S_IRUSR | S_IWUSR);
- ret = write_or_die(fd, blob, len);
+ ret = write_or_die(fd, blob, count);
fdatasync(fd);
close(fd);
when the HWP.EPP (Energy Performance Preference) is set to "balance_power" (0x80) -- the default on most systems. It occurs because the platform BIOS may erroneously enable an energy-efficiency setting -- MSR_IA32_POWER_CTL BIT-EE, which is not recommended to be enabled on this SKU. On the failing systems, this BIOS issue was not discovered when the desktop motherboard was tested with Windows, because the BIOS also neglects to provide the ACPI/CPPC table, that Windows requires to enable HWP, and so Windows runs in legacy P-state mode, where this setting has no effect. Linux' intel_pstate driver does not require ACPI/CPPC to enable HWP, and so it runs in HWP mode, exposing this incorrect BIOS configuration. There are several ways to address this problem. First, Linux can also run in legacy P-state mode on this system. As intel_pstate is how Linux enables HWP, booting with "intel_pstate=disable" will run in acpi-cpufreq/ondemand legacy p-state mode. Or second, the "performance" governor can be used with intel_pstate, which will modify HWP.EPP to 0. Or third, starting in 4.10, the /sys/devices/system/cpu/cpufreq/policy*/energy_performance_preference attribute in can be updated from "balance_power" to "performance". Or fourth, apply this patch, which fixes the erroneous setting of MSR_IA32_POWER_CTL BIT_EE on this model, allowing the default configuration to function as designed. Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Reviewed-by: Len Brown <len.brown@intel.com> Cc: 4.6+ <stable@vger.kernel.org> # 4.6+ Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'net/kcm/Kconfig')